[PATCH 4/7] dt-bindings: timers: Add Tenstorrent Blackhole compatible

Drew Fustini posted 7 patches 2 weeks, 4 days ago
[PATCH 4/7] dt-bindings: timers: Add Tenstorrent Blackhole compatible
Posted by Drew Fustini 2 weeks, 4 days ago
From: Drew Fustini <dfustini@tenstorrent.com>

Document clint compatible for the Tenstorrent Blackhole A0 SoC.

Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
---
 Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index d85a1a088b35dabc0aa202475b926302705c4cf1..198146c59de0c95a2ffa052c8d4d7aa3f91f8e92 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -36,6 +36,7 @@ properties:
               - starfive,jh7100-clint   # StarFive JH7100
               - starfive,jh7110-clint   # StarFive JH7110
               - starfive,jh8100-clint   # StarFive JH8100
+              - tenstorrent,blackhole-a0-clint # Tenstorrent Blackhole
           - const: sifive,clint0        # SiFive CLINT v0 IP block
       - items:
           - {}

-- 
2.34.1
Re: [PATCH 4/7] dt-bindings: timers: Add Tenstorrent Blackhole compatible
Posted by Rob Herring 2 weeks, 2 days ago
On Sat, Sep 13, 2025 at 02:31:03PM -0700, Drew Fustini wrote:
> From: Drew Fustini <dfustini@tenstorrent.com>
> 
> Document clint compatible for the Tenstorrent Blackhole A0 SoC.
> 
> Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
> ---
>  Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index d85a1a088b35dabc0aa202475b926302705c4cf1..198146c59de0c95a2ffa052c8d4d7aa3f91f8e92 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -36,6 +36,7 @@ properties:
>                - starfive,jh7100-clint   # StarFive JH7100
>                - starfive,jh7110-clint   # StarFive JH7110
>                - starfive,jh8100-clint   # StarFive JH8100
> +              - tenstorrent,blackhole-a0-clint # Tenstorrent Blackhole

We usually don't put Si versions (A0) in compatible strings unless later 
versions changed in incompatible ways. Perhaps if you already knew that 
B0 was different, then it would be appropriate. Or am I misunderstanding 
what A0 means?

Rob
Re: [PATCH 4/7] dt-bindings: timers: Add Tenstorrent Blackhole compatible
Posted by Drew Fustini 2 weeks, 1 day ago
On Tue, Sep 16, 2025 at 08:44:00AM -0500, Rob Herring wrote:
> On Sat, Sep 13, 2025 at 02:31:03PM -0700, Drew Fustini wrote:
> > From: Drew Fustini <dfustini@tenstorrent.com>
> > 
> > Document clint compatible for the Tenstorrent Blackhole A0 SoC.
> > 
> > Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
> > ---
> >  Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > index d85a1a088b35dabc0aa202475b926302705c4cf1..198146c59de0c95a2ffa052c8d4d7aa3f91f8e92 100644
> > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> > @@ -36,6 +36,7 @@ properties:
> >                - starfive,jh7100-clint   # StarFive JH7100
> >                - starfive,jh7110-clint   # StarFive JH7110
> >                - starfive,jh8100-clint   # StarFive JH8100
> > +              - tenstorrent,blackhole-a0-clint # Tenstorrent Blackhole
> 
> We usually don't put Si versions (A0) in compatible strings unless later 
> versions changed in incompatible ways. Perhaps if you already knew that 
> B0 was different, then it would be appropriate. Or am I misunderstanding 
> what A0 means?
> 
> Rob

Okay, thanks for explaining. A0 is the silicon revision, and it is
currently the only version that exists. I was just trying to be as
specific as possible. I'm okay with dropping '-a0'.

Should I change the plic compatible to 'tenstorrent,blackhole-plic' too?

I see you gave a Rb for riscv/tenstorrent.yaml but that does have
'tenstorrent,blackhole-a0-card' and 'tenstorrent,blackhole-a0'. Should I
drop '-a0' from those too or leave as-is?

Thanks,
Drew