[PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id

Paul Sajna posted 11 patches 2 weeks, 4 days ago
There is a newer version of this series
[PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id
Posted by Paul Sajna 2 weeks, 4 days ago
SDM845 msm-id and board-id added

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 3 +++
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 1 +
 2 files changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index cc1c78162eedd50d30a70810ac3790efe6c0492f..3853f0e5d89ca87b6fe7882e50ab9421a42efb0d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -5,6 +5,7 @@
  * Copyright (c) 2022, The Linux Foundation. All rights reserved.
  */
 
+#include <dt-bindings/arm/qcom,ids.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
@@ -28,6 +29,8 @@
 /delete-node/ &wlan_msa_mem;
 
 / {
+	qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
+
 	chosen {
 		#address-cells = <2>;
 		#size-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 1596a3408659323d60f1b7c395098ed628782dfa..467aa0fd0ef3938e4a8c08b2240d4dca2f74dbcd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -12,6 +12,7 @@
 / {
 	model = "LG G7 ThinQ";
 	compatible = "lg,judyln", "qcom,sdm845";
+	qcom,board-id = <0x020C0008 0>;
 
 	chosen {
 		framebuffer@9d400000 {

-- 
2.51.0
Re: [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id
Posted by Krzysztof Kozlowski 2 weeks, 4 days ago
On 14/09/2025 01:56, Paul Sajna wrote:
> SDM845 msm-id and board-id added


We see this from the diff. Don't repeat the diff in the commit msg,
that's not its purpose. You need to explain why. Especially that these
properties are deprecated and should not be used in general.


Best regards,
Krzysztof