[PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2

Mikko Rapeli posted 4 patches 2 weeks, 6 days ago
There is a newer version of this series
[PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
Posted by Mikko Rapeli 2 weeks, 6 days ago
It fails to link due to undeclared dependency
to regmap which is not enabled for COMPILE_TEST:

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/mmc/host/loongson2-mmc.ko] undefined!

Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 2db46291ae442..e2d9a7cf9f855 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1113,7 +1113,7 @@ config MMC_OWL
 
 config MMC_LOONGSON2
 	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
-	depends on LOONGARCH || COMPILE_TEST
+	depends on LOONGARCH
 	depends on HAS_DMA
 	help
 	  This selects support for the SD/SDIO/eMMC Host Controller on
-- 
2.34.1
Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
Posted by Binbin Zhou 2 weeks, 5 days ago
Hi Mikko:

Thanks for your patch.

On 2025/9/12 22:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
> 
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
>   drivers/mmc/host/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 2db46291ae442..e2d9a7cf9f855 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1113,7 +1113,7 @@ config MMC_OWL
>   
>   config MMC_LOONGSON2
>   	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on LOONGARCH

How about add `select REGMAP_MMIO` instead.

>   	depends on HAS_DMA
>   	help
>   	  This selects support for the SD/SDIO/eMMC Host Controller on

Thanks.
Binbin
Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
Posted by Mikko Rapeli 2 weeks, 3 days ago
Hi,

On Fri, Sep 12, 2025 at 04:50:38PM +0200, Arnd Bergmann wrote:
> On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> > It fails to link due to undeclared dependency
> > to regmap which is not enabled for COMPILE_TEST:
> >
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/mmc/host/loongson2-mmc.ko] undefined!
> 
> Nice catch! I assume my normal randconfig builds never
> run into this because there is always something selecting
> REGMAP_MMIO.
> 
> >  config MMC_LOONGSON2
> >  	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > -	depends on LOONGARCH || COMPILE_TEST
> > +	depends on LOONGARCH
> >  	depends on HAS_DMA
> 
> I would instead add 'select REGMAP_MMIO' here, which is what
> we do for other drivers using this.

On Sat, Sep 13, 2025 at 12:58:00PM +0800, Binbin Zhou wrote:
<snip>
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1113,7 +1113,7 @@ config MMC_OWL
> >   config MMC_LOONGSON2
> >   	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> > -	depends on LOONGARCH || COMPILE_TEST
> > +	depends on LOONGARCH
> 
> How about add `select REGMAP_MMIO` instead.

Sorry, my bad. I just checked drivers/base/regmap/Kconfig for COMPILE_TEST
and since it was not found thought that it's not supported with
COMPILE_TEST.

I will add the REGMAP_MMIO dependency instead in v4.

Cheers,

-Mikko
Re: [PATCH v3 3/4] mmc: remove COMPILE_TEST from MMC_LOONGSON2
Posted by Arnd Bergmann 2 weeks, 6 days ago
On Fri, Sep 12, 2025, at 16:22, Mikko Rapeli wrote:
> It fails to link due to undeclared dependency
> to regmap which is not enabled for COMPILE_TEST:
>
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/mmc/host/loongson2-mmc.ko] undefined!

Nice catch! I assume my normal randconfig builds never
run into this because there is always something selecting
REGMAP_MMIO.

>  config MMC_LOONGSON2
>  	tristate "Loongson-2K SD/SDIO/eMMC Host Interface support"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on LOONGARCH
>  	depends on HAS_DMA

I would instead add 'select REGMAP_MMIO' here, which is what
we do for other drivers using this.

     Arnd