From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>

Add device tree bindings for the CCI controller on the
Qualcomm QCS8300 SoC.
Introduce the "qcom,qcs8300-cci" compatible string.

Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index 1687b069e032..edd2e77d717b 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -25,6 +25,7 @@ properties:
 
       - items:
           - enum:
+              - qcom,qcs8300-cci
               - qcom,sc7280-cci
               - qcom,sc8280xp-cci
               - qcom,sdm670-cci
@@ -223,6 +224,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,qcs8300-cci
               - qcom,sm8550-cci
               - qcom,sm8650-cci
               - qcom,x1e80100-cci
-- 
2.25.1

On Fri, Sep 12, 2025 at 07:41:32PM +0530, Vikram Sharma wrote:
> From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> 
> Add device tree bindings for the CCI controller on the
> Qualcomm QCS8300 SoC.
> Introduce the "qcom,qcs8300-cci" compatible string.

Wrap commit messages at 72 chars. And explain how it's the same or 
different from existing SoCs in the commit message. Don't explain the 
diff. We can read that ourselves.

> 
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 1687b069e032..edd2e77d717b 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -25,6 +25,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - qcom,qcs8300-cci
>                - qcom,sc7280-cci
>                - qcom,sc8280xp-cci
>                - qcom,sdm670-cci
> @@ -223,6 +224,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,qcs8300-cci
>                - qcom,sm8550-cci
>                - qcom,sm8650-cci
>                - qcom,x1e80100-cci
> -- 
> 2.25.1
>

On 16-09-2025 08:18, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 07:41:32PM +0530, Vikram Sharma wrote:
>> From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>>
>> Add device tree bindings for the CCI controller on the
>> Qualcomm QCS8300 SoC.
>> Introduce the "qcom,qcs8300-cci" compatible string.
> Wrap commit messages at 72 chars. And explain how it's the same or 
> different from existing SoCs in the commit message. Don't explain the 
> diff. We can read that ourselves.
> 

SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the 
only difference being the GPIOs used for SDA/SCL pins.

Currently, the CCI driver probe happens through the "qcom,msm8996-cci" 
compatible string. Could we use the existing SA8775P compatible string
"qcom,sa8775p-cci" or we should remove it? 

Please advise on the preferred approach for upstream compliance.

>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>>  1 file changed, 2 insertions(+)

Regards,
Nihal Kumar Gupta

On 9/16/25 1:07 PM, Nihal Kumar Gupta wrote:
> 
> 
> On 16-09-2025 08:18, Rob Herring wrote:
>> On Fri, Sep 12, 2025 at 07:41:32PM +0530, Vikram Sharma wrote:
>>> From: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>>>
>>> Add device tree bindings for the CCI controller on the
>>> Qualcomm QCS8300 SoC.
>>> Introduce the "qcom,qcs8300-cci" compatible string.
>> Wrap commit messages at 72 chars. And explain how it's the same or 
>> different from existing SoCs in the commit message. Don't explain the 
>> diff. We can read that ourselves.
>>
> 
> SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the 
> only difference being the GPIOs used for SDA/SCL pins.
> 
> Currently, the CCI driver probe happens through the "qcom,msm8996-cci" 
> compatible string. Could we use the existing SA8775P compatible string
> "qcom,sa8775p-cci" or we should remove it? 
> 
> Please advise on the preferred approach for upstream compliance.

Try:

"""
The three instances of CCI found on the QCS8300 are functionally
the same as on a number of existing Qualcomm SoCs.

Introduce a new SoC-specific compatible, with a common fallback.
"""

Konrad

On 16-09-2025 16:41, Konrad Dybcio wrote:
>>> Wrap commit messages at 72 chars. And explain how it's the same or 
>>> different from existing SoCs in the commit message. Don't explain the 
>>> diff. We can read that ourselves.
>>>
>> SA8775P(Lemans) has 4 CCIs, while QCS8300 (Monaco) has 3 CCI, with the 
>> only difference being the GPIOs used for SDA/SCL pins.
>>
>> Currently, the CCI driver probe happens through the "qcom,msm8996-cci" 
>> compatible string. Could we use the existing SA8775P compatible string
>> "qcom,sa8775p-cci" or we should remove it? 
>>
>> Please advise on the preferred approach for upstream compliance.
> Try:
> 
> """
> The three instances of CCI found on the QCS8300 are functionally
> the same as on a number of existing Qualcomm SoCs.
> 
> Introduce a new SoC-specific compatible, with a common fallback.
> """
> 

ACK, Will address this in next version.
> Konrad