drivers/gpu/drm/bridge/analogix/Kconfig | 1 + .../drm/bridge/analogix/analogix_dp_core.c | 394 ++++++++++-------- .../drm/bridge/analogix/analogix_dp_core.h | 5 +- drivers/gpu/drm/exynos/exynos_dp.c | 168 ++++---- drivers/gpu/drm/rockchip/Kconfig | 1 - .../gpu/drm/rockchip/analogix_dp-rockchip.c | 74 ++-- include/drm/bridge/analogix_dp.h | 9 +- 7 files changed, 342 insertions(+), 310 deletions(-)
PATCH 1 is a small format optimization for struct analogid_dp_device.
PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable.
PATCH 3-9 are preparations for apply drm_bridge_connector helper.
PATCH 10 is to apply the drm_bridge_connector helper.
PATCH 11-14 are to move the panel/bridge parsing to the Analogix side.
PATCH 15-16 are preparations for apply panel_bridge helper.
PATCH 17 is to apply the panel_bridge helper.
Damon Ding (17):
drm/bridge: analogix_dp: Formalize the struct analogix_dp_device
drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to
&drm_bridge_funcs.atomic_enable
drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge
drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge
drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector
drm/bridge: analogix_dp: Remove redundant
&analogix_dp_plat_data.skip_connector
drm/exynos: exynos_dp: Add legacy bridge to parse the display-timings
node
drm/bridge: analogix_dp: Move the color format check to
.atomic_check() for Rockchip platforms
drm/bridge: analogix_dp: Remove unused
&analogix_dp_plat_data.get_modes()
drm/bridge: analogix_dp: Apply drm_bridge_connector helper
drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe()
drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe()
drm/rockchip: analogix_dp: Apply &analogix_dp_plat_data.attach() to
attach next bridge
drm/exynos: exynos_dp: Apply analogix_dp_finish_probe()
drm/bridge: analogix_dp: Remove panel disabling and enabling in
analogix_dp_set_bridge()
drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing
in analogix_dp_unbind()
drm/bridge: analogix_dp: Apply panel_bridge helper
drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
.../drm/bridge/analogix/analogix_dp_core.c | 394 ++++++++++--------
.../drm/bridge/analogix/analogix_dp_core.h | 5 +-
drivers/gpu/drm/exynos/exynos_dp.c | 168 ++++----
drivers/gpu/drm/rockchip/Kconfig | 1 -
.../gpu/drm/rockchip/analogix_dp-rockchip.c | 74 ++--
include/drm/bridge/analogix_dp.h | 9 +-
7 files changed, 342 insertions(+), 310 deletions(-)
---
Changes in v2:
- Update Exynos DP driver synchronously.
- Move the panel/bridge parsing to the Analogix side.
Changes in v3:
- Rebase for the existing devm_drm_bridge_alloc() applying commit.
- Fix the typographical error of panel/bridge check in exynos_dp_bind().
- Squash all commits related to skip_connector deletion in both Exynos and
Analogix code into one.
- Apply panel_bridge helper to make the codes more concise.
- Fix the handing of bridge in analogix_dp_bridge_get_modes().
- Remove unnecessary parameter struct drm_connector* for callback
&analogix_dp_plat_data.attach().
- In order to decouple the connector driver and the bridge driver, move
the bridge connector initilization to the Rockchip and Exynos sides.
Changes in v4:
- Rebase for the applied &drm_bridge_funcs.detect() modification commit.
- Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe().
- Drop the drmm_encoder_init() modification commit.
- Rename the &analogix_dp_plat_data.bridge to
&analogix_dp_plat_data.next_bridge.
Changes in v5:
- Add legacy bridge to parse the display-timings node under the dp node
for Exynos side.
- Move color format check to &drm_connector_helper_funcs.atomic_check()
in order to get rid of &analogix_dp_plat_data.get_modes().
- Remove unused callback &analogix_dp_plat_data.get_modes().
- Distinguish the &drm_bridge->ops of Analogix bridge based on whether
the downstream device is a panel, a bridge or neither.
- Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for
ROCKCHIP_ANALOGIX_DP.
- Apply rockchip_dp_attach() to support the next bridge attachment for
the Rockchip side.
- Move next_bridge attachment from Analogix side to Rockchip/Exynos sides.
--
2.34.1
On 12.09.2025 10:58, Damon Ding wrote: > PATCH 1 is a small format optimization for struct analogid_dp_device. > PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable. > PATCH 3-9 are preparations for apply drm_bridge_connector helper. > PATCH 10 is to apply the drm_bridge_connector helper. > PATCH 11-14 are to move the panel/bridge parsing to the Analogix side. > PATCH 15-16 are preparations for apply panel_bridge helper. > PATCH 17 is to apply the panel_bridge helper. > > Damon Ding (17): > drm/bridge: analogix_dp: Formalize the struct analogix_dp_device > drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to > &drm_bridge_funcs.atomic_enable > drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge > drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge > drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector > drm/bridge: analogix_dp: Remove redundant > &analogix_dp_plat_data.skip_connector > drm/exynos: exynos_dp: Add legacy bridge to parse the display-timings > node > drm/bridge: analogix_dp: Move the color format check to > .atomic_check() for Rockchip platforms > drm/bridge: analogix_dp: Remove unused > &analogix_dp_plat_data.get_modes() > drm/bridge: analogix_dp: Apply drm_bridge_connector helper > drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() > drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() > drm/rockchip: analogix_dp: Apply &analogix_dp_plat_data.attach() to > attach next bridge > drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() > drm/bridge: analogix_dp: Remove panel disabling and enabling in > analogix_dp_set_bridge() > drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing > in analogix_dp_unbind() > drm/bridge: analogix_dp: Apply panel_bridge helper > > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > .../drm/bridge/analogix/analogix_dp_core.c | 394 ++++++++++-------- > .../drm/bridge/analogix/analogix_dp_core.h | 5 +- > drivers/gpu/drm/exynos/exynos_dp.c | 168 ++++---- > drivers/gpu/drm/rockchip/Kconfig | 1 - > .../gpu/drm/rockchip/analogix_dp-rockchip.c | 74 ++-- > include/drm/bridge/analogix_dp.h | 9 +- > 7 files changed, 342 insertions(+), 310 deletions(-) > > --- > > Changes in v2: > - Update Exynos DP driver synchronously. > - Move the panel/bridge parsing to the Analogix side. > > Changes in v3: > - Rebase for the existing devm_drm_bridge_alloc() applying commit. > - Fix the typographical error of panel/bridge check in exynos_dp_bind(). > - Squash all commits related to skip_connector deletion in both Exynos and > Analogix code into one. > - Apply panel_bridge helper to make the codes more concise. > - Fix the handing of bridge in analogix_dp_bridge_get_modes(). > - Remove unnecessary parameter struct drm_connector* for callback > &analogix_dp_plat_data.attach(). > - In order to decouple the connector driver and the bridge driver, move > the bridge connector initilization to the Rockchip and Exynos sides. > > Changes in v4: > - Rebase for the applied &drm_bridge_funcs.detect() modification commit. > - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). > - Drop the drmm_encoder_init() modification commit. > - Rename the &analogix_dp_plat_data.bridge to > &analogix_dp_plat_data.next_bridge. > > Changes in v5: > - Add legacy bridge to parse the display-timings node under the dp node > for Exynos side. > - Move color format check to &drm_connector_helper_funcs.atomic_check() > in order to get rid of &analogix_dp_plat_data.get_modes(). > - Remove unused callback &analogix_dp_plat_data.get_modes(). > - Distinguish the &drm_bridge->ops of Analogix bridge based on whether > the downstream device is a panel, a bridge or neither. > - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for > ROCKCHIP_ANALOGIX_DP. > - Apply rockchip_dp_attach() to support the next bridge attachment for > the Rockchip side. > - Move next_bridge attachment from Analogix side to Rockchip/Exynos sides. Exynos part still lacks "select DRM_BRIDGE_CONNECTOR" in Kconfig, besides that it works fine on all my test boards. Fix this issue and feel free to add: Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
Hi Marek, On 9/12/2025 5:56 PM, Marek Szyprowski wrote: > On 12.09.2025 10:58, Damon Ding wrote: >> PATCH 1 is a small format optimization for struct analogid_dp_device. >> PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable. >> PATCH 3-9 are preparations for apply drm_bridge_connector helper. >> PATCH 10 is to apply the drm_bridge_connector helper. >> PATCH 11-14 are to move the panel/bridge parsing to the Analogix side. >> PATCH 15-16 are preparations for apply panel_bridge helper. >> PATCH 17 is to apply the panel_bridge helper. >> >> Damon Ding (17): >> drm/bridge: analogix_dp: Formalize the struct analogix_dp_device >> drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to >> &drm_bridge_funcs.atomic_enable >> drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge >> drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge >> drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector >> drm/bridge: analogix_dp: Remove redundant >> &analogix_dp_plat_data.skip_connector >> drm/exynos: exynos_dp: Add legacy bridge to parse the display-timings >> node >> drm/bridge: analogix_dp: Move the color format check to >> .atomic_check() for Rockchip platforms >> drm/bridge: analogix_dp: Remove unused >> &analogix_dp_plat_data.get_modes() >> drm/bridge: analogix_dp: Apply drm_bridge_connector helper >> drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() >> drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() >> drm/rockchip: analogix_dp: Apply &analogix_dp_plat_data.attach() to >> attach next bridge >> drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() >> drm/bridge: analogix_dp: Remove panel disabling and enabling in >> analogix_dp_set_bridge() >> drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing >> in analogix_dp_unbind() >> drm/bridge: analogix_dp: Apply panel_bridge helper >> >> drivers/gpu/drm/bridge/analogix/Kconfig | 1 + >> .../drm/bridge/analogix/analogix_dp_core.c | 394 ++++++++++-------- >> .../drm/bridge/analogix/analogix_dp_core.h | 5 +- >> drivers/gpu/drm/exynos/exynos_dp.c | 168 ++++---- >> drivers/gpu/drm/rockchip/Kconfig | 1 - >> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 74 ++-- >> include/drm/bridge/analogix_dp.h | 9 +- >> 7 files changed, 342 insertions(+), 310 deletions(-) >> >> --- >> >> Changes in v2: >> - Update Exynos DP driver synchronously. >> - Move the panel/bridge parsing to the Analogix side. >> >> Changes in v3: >> - Rebase for the existing devm_drm_bridge_alloc() applying commit. >> - Fix the typographical error of panel/bridge check in exynos_dp_bind(). >> - Squash all commits related to skip_connector deletion in both Exynos and >> Analogix code into one. >> - Apply panel_bridge helper to make the codes more concise. >> - Fix the handing of bridge in analogix_dp_bridge_get_modes(). >> - Remove unnecessary parameter struct drm_connector* for callback >> &analogix_dp_plat_data.attach(). >> - In order to decouple the connector driver and the bridge driver, move >> the bridge connector initilization to the Rockchip and Exynos sides. >> >> Changes in v4: >> - Rebase for the applied &drm_bridge_funcs.detect() modification commit. >> - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). >> - Drop the drmm_encoder_init() modification commit. >> - Rename the &analogix_dp_plat_data.bridge to >> &analogix_dp_plat_data.next_bridge. >> >> Changes in v5: >> - Add legacy bridge to parse the display-timings node under the dp node >> for Exynos side. >> - Move color format check to &drm_connector_helper_funcs.atomic_check() >> in order to get rid of &analogix_dp_plat_data.get_modes(). >> - Remove unused callback &analogix_dp_plat_data.get_modes(). >> - Distinguish the &drm_bridge->ops of Analogix bridge based on whether >> the downstream device is a panel, a bridge or neither. >> - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for >> ROCKCHIP_ANALOGIX_DP. >> - Apply rockchip_dp_attach() to support the next bridge attachment for >> the Rockchip side. >> - Move next_bridge attachment from Analogix side to Rockchip/Exynos sides. > > Exynos part still lacks "select DRM_BRIDGE_CONNECTOR" in Kconfig, > besides that it works fine on all my test boards. Fix this issue and > feel free to add: > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > Thank you for the testing. I will add the DRM_BRIDGE_CONNECTOR selection for DRM_EXYNOS_DP in the next version, with the Tested-by tags. Best regards, Damon
On Fri, Sep 12, 2025 at 04:58:29PM +0800, Damon Ding wrote: > PATCH 1 is a small format optimization for struct analogid_dp_device. > PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable. > PATCH 3-9 are preparations for apply drm_bridge_connector helper. > PATCH 10 is to apply the drm_bridge_connector helper. > PATCH 11-14 are to move the panel/bridge parsing to the Analogix side. > PATCH 15-16 are preparations for apply panel_bridge helper. > PATCH 17 is to apply the panel_bridge helper. > > Damon Ding (17): > drm/bridge: analogix_dp: Formalize the struct analogix_dp_device > drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to > &drm_bridge_funcs.atomic_enable > drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge > drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge > drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector > drm/bridge: analogix_dp: Remove redundant > &analogix_dp_plat_data.skip_connector > drm/exynos: exynos_dp: Add legacy bridge to parse the display-timings > node > drm/bridge: analogix_dp: Move the color format check to > .atomic_check() for Rockchip platforms > drm/bridge: analogix_dp: Remove unused > &analogix_dp_plat_data.get_modes() > drm/bridge: analogix_dp: Apply drm_bridge_connector helper > drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() > drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() > drm/rockchip: analogix_dp: Apply &analogix_dp_plat_data.attach() to > attach next bridge > drm/exynos: exynos_dp: Apply analogix_dp_finish_probe() > drm/bridge: analogix_dp: Remove panel disabling and enabling in > analogix_dp_set_bridge() > drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing > in analogix_dp_unbind() > drm/bridge: analogix_dp: Apply panel_bridge helper This patch didn't make it to the maling list. > > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > .../drm/bridge/analogix/analogix_dp_core.c | 394 ++++++++++-------- > .../drm/bridge/analogix/analogix_dp_core.h | 5 +- > drivers/gpu/drm/exynos/exynos_dp.c | 168 ++++---- > drivers/gpu/drm/rockchip/Kconfig | 1 - > .../gpu/drm/rockchip/analogix_dp-rockchip.c | 74 ++-- > include/drm/bridge/analogix_dp.h | 9 +- > 7 files changed, 342 insertions(+), 310 deletions(-) > > --- > > Changes in v2: > - Update Exynos DP driver synchronously. > - Move the panel/bridge parsing to the Analogix side. > > Changes in v3: > - Rebase for the existing devm_drm_bridge_alloc() applying commit. > - Fix the typographical error of panel/bridge check in exynos_dp_bind(). > - Squash all commits related to skip_connector deletion in both Exynos and > Analogix code into one. > - Apply panel_bridge helper to make the codes more concise. > - Fix the handing of bridge in analogix_dp_bridge_get_modes(). > - Remove unnecessary parameter struct drm_connector* for callback > &analogix_dp_plat_data.attach(). > - In order to decouple the connector driver and the bridge driver, move > the bridge connector initilization to the Rockchip and Exynos sides. > > Changes in v4: > - Rebase for the applied &drm_bridge_funcs.detect() modification commit. > - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). > - Drop the drmm_encoder_init() modification commit. > - Rename the &analogix_dp_plat_data.bridge to > &analogix_dp_plat_data.next_bridge. > > Changes in v5: > - Add legacy bridge to parse the display-timings node under the dp node > for Exynos side. > - Move color format check to &drm_connector_helper_funcs.atomic_check() > in order to get rid of &analogix_dp_plat_data.get_modes(). > - Remove unused callback &analogix_dp_plat_data.get_modes(). > - Distinguish the &drm_bridge->ops of Analogix bridge based on whether > the downstream device is a panel, a bridge or neither. > - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP, and remove it for > ROCKCHIP_ANALOGIX_DP. > - Apply rockchip_dp_attach() to support the next bridge attachment for > the Rockchip side. > - Move next_bridge attachment from Analogix side to Rockchip/Exynos sides. > > -- > 2.34.1 > -- With best wishes Dmitry
© 2016 - 2025 Red Hat, Inc.