From: Shangjuan Wei <weishangjuan@eswincomputing.com>
Add ESWIN EIC7700 Ethernet controller, supporting clock
configuration, delay adjustment and speed adaptive functions.
Signed-off-by: Zhi Li <lizhi2@eswincomputing.com>
Signed-off-by: Shangjuan Wei <weishangjuan@eswincomputing.com>
---
.../bindings/net/eswin,eic7700-eth.yaml | 128 ++++++++++++++++++
1 file changed, 128 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
new file mode 100644
index 000000000000..9771fed9604e
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
@@ -0,0 +1,128 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/eswin,eic7700-eth.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Eswin EIC7700 SOC Eth Controller
+
+maintainers:
+ - Shuang Liang <liangshuang@eswincomputing.com>
+ - Zhi Li <lizhi2@eswincomputing.com>
+ - Shangjuan Wei <weishangjuan@eswincomputing.com>
+
+description:
+ Platform glue layer implementation for STMMAC Ethernet driver.
+
+select:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - eswin,eic7700-qos-eth
+ required:
+ - compatible
+
+allOf:
+ - $ref: snps,dwmac.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: eswin,eic7700-qos-eth
+ - const: snps,dwmac-5.20
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-names:
+ const: macirq
+
+ clocks:
+ items:
+ - description: AXI clock
+ - description: Configuration clock
+ - description: GMAC main clock
+ - description: Tx clock
+
+ clock-names:
+ items:
+ - const: axi
+ - const: cfg
+ - const: stmmaceth
+ - const: tx
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: stmmaceth
+
+ rx-internal-delay-ps:
+ enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]
+
+ tx-internal-delay-ps:
+ enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]
+
+ eswin,hsp-sp-csr:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ - description: Phandle to HSP(High-Speed Peripheral) device
+ - description: Offset of phy control register for internal
+ or external clock selection
+ - description: Offset of AXI clock controller Low-Power request
+ register
+ - description: Offset of register controlling TX/RX clock delay
+ description: |
+ High-Speed Peripheral device needed to configure clock selection,
+ clock low-power mode and clock delay.
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+ - interrupt-names
+ - phy-mode
+ - resets
+ - reset-names
+ - rx-internal-delay-ps
+ - tx-internal-delay-ps
+ - eswin,hsp-sp-csr
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ ethernet@50400000 {
+ compatible = "eswin,eic7700-qos-eth", "snps,dwmac-5.20";
+ reg = <0x50400000 0x10000>;
+ clocks = <&d0_clock 186>, <&d0_clock 171>, <&d0_clock 40>,
+ <&d0_clock 193>;
+ clock-names = "axi", "cfg", "stmmaceth", "tx";
+ interrupt-parent = <&plic>;
+ interrupts = <61>;
+ interrupt-names = "macirq";
+ phy-mode = "rgmii-id";
+ phy-handle = <&phy0>;
+ resets = <&reset 95>;
+ reset-names = "stmmaceth";
+ rx-internal-delay-ps = <200>;
+ tx-internal-delay-ps = <200>;
+ eswin,hsp-sp-csr = <&hsp_sp_csr 0x100 0x108 0x118>;
+ snps,axi-config = <&stmmac_axi_setup>;
+ snps,aal;
+ snps,fixed-burst;
+ snps,tso;
+ stmmac_axi_setup: stmmac-axi-config {
+ snps,blen = <0 0 0 0 16 8 4>;
+ snps,rd_osr_lmt = <2>;
+ snps,wr_osr_lmt = <2>;
+ };
+ };
--
2.17.1On 12/09/2025 07:56, weishangjuan@eswincomputing.com wrote: > From: Shangjuan Wei <weishangjuan@eswincomputing.com> > > Add ESWIN EIC7700 Ethernet controller, supporting clock > configuration, delay adjustment and speed adaptive functions. > > Signed-off-by: Zhi Li <lizhi2@eswincomputing.com> > Signed-off-by: Shangjuan Wei <weishangjuan@eswincomputing.com> There is no explanation of dropping the tag. Please read CAREFULLY submitting patches. Comparing also fails: b4 diff '<20250912055352.2832-1-weishangjuan@eswincomputing.com>' Using cached copy of the lookup --- Analyzing 55 messages in the thread Preparing fake-am for v6: dt-bindings: ethernet: eswin: Document for EIC7700 SoC ERROR: Could not fake-am version v6 --- Could not create fake-am range for upper series v6 I am not going to review twice, so you can drop my tag again without explanation. Best regards, Krzysztof
Dear Krzysztof Kozlowski, I am writing to sincerely apologize for omitting your "Reviewed-by" tag in the v6 patch series without providing an explanation. This was an oversight on my part, and I truly regret any inconvenience or frustration it has caused. The reason why I didn't add tags is that I made modifications to the description in the YAML file. Due to these changes that alter the content you have previously viewed, I believe these modifications may require a re examination and therefore should not be retained without your confirmation. I understand that when submitting the patch, I should clearly state the reason. I have carefully read the submission guidelines and will ensure full compliance with the process in all future contributions, including proper use of b4 and clear communication of changes. Thank you for your patience and guidance. Best regards, Shangjuan Wei > -----原始邮件----- > 发件人: "Krzysztof Kozlowski" <krzk@kernel.org> > 发送时间:2025-09-12 21:14:24 (星期五) > 收件人: weishangjuan@eswincomputing.com, devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, yong.liang.choong@linux.intel.com, vladimir.oltean@nxp.com, rmk+kernel@armlinux.org.uk, faizal.abdul.rahim@linux.intel.com, prabhakar.mahadev-lad.rj@bp.renesas.com, inochiama@gmail.com, jan.petrous@oss.nxp.com, jszhang@kernel.org, p.zabel@pengutronix.de, boon.khai.ng@altera.com, 0x1207@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, emil.renner.berthing@canonical.com > 抄送: ningyu@eswincomputing.com, linmin@eswincomputing.com, lizhi2@eswincomputing.com, pinkesh.vaghela@einfochips.com > 主题: Re: [PATCH v6 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC > > On 12/09/2025 07:56, weishangjuan@eswincomputing.com wrote: > > From: Shangjuan Wei <weishangjuan@eswincomputing.com> > > > > Add ESWIN EIC7700 Ethernet controller, supporting clock > > configuration, delay adjustment and speed adaptive functions. > > > > Signed-off-by: Zhi Li <lizhi2@eswincomputing.com> > > Signed-off-by: Shangjuan Wei <weishangjuan@eswincomputing.com> > > There is no explanation of dropping the tag. Please read CAREFULLY > submitting patches. > > Comparing also fails: > > b4 diff '<20250912055352.2832-1-weishangjuan@eswincomputing.com>' > Using cached copy of the lookup > --- > Analyzing 55 messages in the thread > Preparing fake-am for v6: dt-bindings: ethernet: eswin: Document for > EIC7700 SoC > ERROR: Could not fake-am version v6 > --- > Could not create fake-am range for upper series v6 > > I am not going to review twice, so you can drop my tag again without > explanation. > > Best regards, > Krzysztof
On 12/09/2025 15:14, Krzysztof Kozlowski wrote: > On 12/09/2025 07:56, weishangjuan@eswincomputing.com wrote: >> From: Shangjuan Wei <weishangjuan@eswincomputing.com> >> >> Add ESWIN EIC7700 Ethernet controller, supporting clock >> configuration, delay adjustment and speed adaptive functions. >> >> Signed-off-by: Zhi Li <lizhi2@eswincomputing.com> >> Signed-off-by: Shangjuan Wei <weishangjuan@eswincomputing.com> > > There is no explanation of dropping the tag. Please read CAREFULLY > submitting patches. > > Comparing also fails: > > b4 diff '<20250912055352.2832-1-weishangjuan@eswincomputing.com>' > Using cached copy of the lookup > --- > Analyzing 55 messages in the thread > Preparing fake-am for v6: dt-bindings: ethernet: eswin: Document for > EIC7700 SoC > ERROR: Could not fake-am version v6 > --- > Could not create fake-am range for upper series v6 Ah, that because your patchset is broken. Please start using b4, which would solve such problems. Otherwise you just waste your own and ours time, because this cannot be applied and cannot be tested. > > I am not going to review twice, so you can drop my tag again without > explanation. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.