The whole driver was converted to the devm APIs except for this last
for-loop. This loop is buggy due to three reasons:
1) It removes the channels without removing the users first. This can
lead to very bad situations.
2) The loop starts at 0 and which is channel0 which is a special
control channel not registered via vchan_init(). Therefore the
remove() always Oops because of NULL pointer exception.
3) sdma_free_chan_resources() disable the clks unconditional without
checking if the clks are enabled. This is done for all
MAX_DMA_CHANNELS which hang the system if there is at least one unused
channel.
The first issue is fixed by making use of the dmaengine devlink support.
The second issue is fixed by not doing anything on channel0.
The last issue is also fixed by the devlink support because during the
consumer teardown phase each requested channel is dropped accordingly so
the dmaengine driver doesn't need to this.
To sum-up, all issues are fixed by dropping the .remove() callback and
let the frameworks do their job.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/dma/imx-sdma.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index d4430e6e56deda7de3538e42af7987a456957b43..a11317c8827297d1d6b8ddc0254ecf549e486001 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -2393,6 +2393,7 @@ static int sdma_probe(struct platform_device *pdev)
sdma->dma_device.device_prep_dma_memcpy = sdma_prep_memcpy;
sdma->dma_device.device_issue_pending = sdma_issue_pending;
sdma->dma_device.copy_align = 2;
+ sdma->dma_device.create_devlink = true;
dma_set_max_seg_size(sdma->dma_device.dev, SDMA_BD_MAX_CNT);
platform_set_drvdata(pdev, sdma);
@@ -2432,25 +2433,11 @@ static int sdma_probe(struct platform_device *pdev)
return 0;
}
-static void sdma_remove(struct platform_device *pdev)
-{
- struct sdma_engine *sdma = platform_get_drvdata(pdev);
- int i;
-
- /* Kill the tasklet */
- for (i = 0; i < MAX_DMA_CHANNELS; i++) {
- struct sdma_channel *sdmac = &sdma->channel[i];
-
- sdma_free_chan_resources(&sdmac->vc.chan);
- }
-}
-
static struct platform_driver sdma_driver = {
.driver = {
.name = "imx-sdma",
.of_match_table = sdma_dt_ids,
},
- .remove = sdma_remove,
.probe = sdma_probe,
};
--
2.47.3