[PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize

Ravi Patel posted 3 patches 3 weeks ago
[PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize
Posted by Ravi Patel 3 weeks ago
Update the axis,artpec8-uart compatible such that it uses the
samsung,uart-fifosize as required property.

This is to remove the axis,artpec8-uart specific code (which is
kind of duplicated) from the driver and use the other matching
exynos8895 uart code for ARTPEC-8.

Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
---
 Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 1a1f991d5364..08eceaae2921 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -152,7 +152,6 @@ allOf:
           contains:
             enum:
               - apple,s5l-uart
-              - axis,artpec8-uart
               - samsung,exynos4210-uart
               - samsung,exynos5433-uart
     then:
@@ -168,6 +167,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - axis,artpec8-uart
               - google,gs101-uart
               - samsung,exynos8895-uart
     then:
--
2.17.1
Re: [PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize
Posted by Krzysztof Kozlowski 3 weeks ago
On 11/09/2025 16:16, Ravi Patel wrote:
> Update the axis,artpec8-uart compatible such that it uses the
> samsung,uart-fifosize as required property.
> 
> This is to remove the axis,artpec8-uart specific code (which is
> kind of duplicated) from the driver and use the other matching
> exynos8895 uart code for ARTPEC-8.
> 
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> ---
>  Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 1a1f991d5364..08eceaae2921 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -152,7 +152,6 @@ allOf:
>            contains:
>              enum:
>                - apple,s5l-uart
> -              - axis,artpec8-uart
>                - samsung,exynos4210-uart
>                - samsung,exynos5433-uart

You need to start testing patches, because this obviously fails basic
tests. And toolset would tell you if you bothered.

This does not fit documented Samsung SoC maintainer rules (because of (1)).

Best regards,
Krzysztof
RE: [PATCH 1/3] dt-bindings: serial: samsung: Update axis,artpec8-uart to use samsung,uart-fifosize
Posted by Ravi Patel 3 weeks ago

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 September 2025 20:03
...
> 
> On 11/09/2025 16:16, Ravi Patel wrote:
> > Update the axis,artpec8-uart compatible such that it uses the
> > samsung,uart-fifosize as required property.
> >
> > This is to remove the axis,artpec8-uart specific code (which is
> > kind of duplicated) from the driver and use the other matching
> > exynos8895 uart code for ARTPEC-8.
> >
> > Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> > ---
> >  Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> > index 1a1f991d5364..08eceaae2921 100644
> > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> > @@ -152,7 +152,6 @@ allOf:
> >            contains:
> >              enum:
> >                - apple,s5l-uart
> > -              - axis,artpec8-uart
> >                - samsung,exynos4210-uart
> >                - samsung,exynos5433-uart
> 
> You need to start testing patches, because this obviously fails basic
> tests. And toolset would tell you if you bothered.

Oh my bad, somehow I missed it.
Will fix (dtbs_check) in next version

Thanks for pointing out.

Thanks,
Ravi

> 
> This does not fit documented Samsung SoC maintainer rules (because of (1)).
> 
> Best regards,
> Krzysztof