[PATCH] completion: Use designated initializers for struct completion

Thorsten Blum posted 1 patch 3 weeks ago
include/linux/completion.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] completion: Use designated initializers for struct completion
Posted by Thorsten Blum 3 weeks ago
Switch COMPLETION_INITIALIZER to the more modern and flexible designated
initializers. This improves readability and allows struct fields to be
reordered.  No functional changes intended.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 include/linux/completion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/completion.h b/include/linux/completion.h
index fb2915676574..36291cb3c0df 100644
--- a/include/linux/completion.h
+++ b/include/linux/completion.h
@@ -33,7 +33,7 @@ static inline void complete_acquire(struct completion *x) {}
 static inline void complete_release(struct completion *x) {}
 
 #define COMPLETION_INITIALIZER(work) \
-	{ 0, __SWAIT_QUEUE_HEAD_INITIALIZER((work).wait) }
+	{ .done = 0, .wait = __SWAIT_QUEUE_HEAD_INITIALIZER((work).wait) }
 
 #define COMPLETION_INITIALIZER_ONSTACK_MAP(work, map) \
 	(*({ init_completion_map(&(work), &(map)); &(work); }))
-- 
2.51.0
Re: [PATCH] completion: Use designated initializers for struct completion
Posted by Valentin Schneider 2 weeks ago
On 11/09/25 12:30, Thorsten Blum wrote:
> Switch COMPLETION_INITIALIZER to the more modern and flexible designated
> initializers. This improves readability and allows struct fields to be
> reordered.  No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>