rust: resolve safety comment TODO in `as_str_unchecked`

[PATCH] rust: resolve safety comment TODO in `as_str_unchecked`

Posted by Onur Özkan 4 months, 4 weeks ago

Resolved the TODO comment with a proper safety explanation.

Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
 rust/kernel/str.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
index 6c892550c0ba..11c30c765828 100644
--- a/rust/kernel/str.rs
+++ b/rust/kernel/str.rs
@@ -380,7 +380,8 @@ pub fn to_str(&self) -> Result<&str, core::str::Utf8Error> {
     /// ```
     #[inline]
     pub unsafe fn as_str_unchecked(&self) -> &str {
-        // SAFETY: TODO.
+        // SAFETY: The safety precondition guarantees that the contents
+        // of this `CStr` are valid UTF-8.
         unsafe { core::str::from_utf8_unchecked(self.as_bytes()) }
     }

--
2.50.0

Re: [PATCH] rust: resolve safety comment TODO in `as_str_unchecked`

Posted by Miguel Ojeda 2 weeks, 5 days ago

On Fri, Sep 12, 2025 at 6:53 AM Onur Özkan <work@onurozkan.dev> wrote:
>
> Resolved the TODO comment with a proper safety explanation.
>
> Signed-off-by: Onur Özkan <work@onurozkan.dev>

I saw this patch without replies -- for future reference, commit
3b83f5d5e78a ("rust: replace `CStr` with `core::ffi::CStr`") made this
one not needed.

Thanks!

Cheers,
Miguel