[RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface

Mohammad Rafi Shaik posted 3 patches 3 weeks ago
sound/soc/qcom/qdsp6/audioreach.c       | 1 +
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
sound/soc/qcom/sc8280xp.c               | 4 ++++
3 files changed, 6 insertions(+)
[RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface
Posted by Mohammad Rafi Shaik 3 weeks ago
Fix the lpaif_type configuration for the I2S interface.
The proper lpaif interface type required to allow DSP to vote
appropriate clock setting for I2S interface and also Add support
for configuring the DAI format on MI2S interfaces to allow setting
the appropriate bit clock and frame clock polarity, ensuring correct
audio data transmissionover MI2S.

changes in [v4]:
	- Updated commit message in patch v4-0003, suggested by Srinivas Kandagatla.
	- Link to V3: https://lore.kernel.org/linux-sound/20250905150445.2596140-1-mohammad.rafi.shaik@oss.qualcomm.com/

changes in [v3]:
	- Added Cc: <stable@vger.kernel.org>, suggested by Srinivas Kandagatla.
	- Added QUINARY MI2S case in patch 3, suggested by Konrad.
	- Link to V2: https://lore.kernel.org/lkml/20250905104020.2463473-1-mohammad.rafi.shaik@oss.qualcomm.com/

changes in [v2]:
	- Used snd_soc_dai_set_fmt() API to set the current clock settings,
	  instead of the default WS source setting, as suggested by Srinivas Kandagatla.
	- Link to V1: https://lore.kernel.org/lkml/20250822171440.2040324-1-mohammad.rafi.shaik@oss.qualcomm.com/

Mohammad Rafi Shaik (3):
  ASoC: qcom: audioreach: Fix lpaif_type configuration for the I2S
    interface
  ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt DAI op for I2S
  ASoC: qcom: sc8280xp: Enable DAI format configuration for MI2S
    interfaces

 sound/soc/qcom/qdsp6/audioreach.c       | 1 +
 sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
 sound/soc/qcom/sc8280xp.c               | 4 ++++
 3 files changed, 6 insertions(+)

-- 
2.34.1
Re: [RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface
Posted by Neil Armstrong 1 week, 6 days ago
On 11/09/2025 08:36, Mohammad Rafi Shaik wrote:
> Fix the lpaif_type configuration for the I2S interface.
> The proper lpaif interface type required to allow DSP to vote
> appropriate clock setting for I2S interface and also Add support
> for configuring the DAI format on MI2S interfaces to allow setting
> the appropriate bit clock and frame clock polarity, ensuring correct
> audio data transmissionover MI2S.
> 
> changes in [v4]:
> 	- Updated commit message in patch v4-0003, suggested by Srinivas Kandagatla.
> 	- Link to V3: https://lore.kernel.org/linux-sound/20250905150445.2596140-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> changes in [v3]:
> 	- Added Cc: <stable@vger.kernel.org>, suggested by Srinivas Kandagatla.
> 	- Added QUINARY MI2S case in patch 3, suggested by Konrad.
> 	- Link to V2: https://lore.kernel.org/lkml/20250905104020.2463473-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> changes in [v2]:
> 	- Used snd_soc_dai_set_fmt() API to set the current clock settings,
> 	  instead of the default WS source setting, as suggested by Srinivas Kandagatla.
> 	- Link to V1: https://lore.kernel.org/lkml/20250822171440.2040324-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> Mohammad Rafi Shaik (3):
>    ASoC: qcom: audioreach: Fix lpaif_type configuration for the I2S
>      interface
>    ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt DAI op for I2S
>    ASoC: qcom: sc8280xp: Enable DAI format configuration for MI2S
>      interfaces
> 
>   sound/soc/qcom/qdsp6/audioreach.c       | 1 +
>   sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
>   sound/soc/qcom/sc8280xp.c               | 4 ++++
>   3 files changed, 6 insertions(+)
> 

Fixes a long-term issue I had with I2S with audioreach platforms, thanks!

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK

Neil
Re: [RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface
Posted by Mark Brown 3 weeks ago
On Thu, Sep 11, 2025 at 12:06:09PM +0530, Mohammad Rafi Shaik wrote:
> Fix the lpaif_type configuration for the I2S interface.
> The proper lpaif interface type required to allow DSP to vote
> appropriate clock setting for I2S interface and also Add support
> for configuring the DAI format on MI2S interfaces to allow setting
> the appropriate bit clock and frame clock polarity, ensuring correct
> audio data transmissionover MI2S.

You previously sent this on *Monday* - please allow reasonable time for
review.