[PATCH 3/5] Documentation: trace: historgram-design: Separate sched_waking histogram section heading and the following diagram

Bagas Sanjaya posted 5 patches 3 weeks ago
[PATCH 3/5] Documentation: trace: historgram-design: Separate sched_waking histogram section heading and the following diagram
Posted by Bagas Sanjaya 3 weeks ago
Section heading for sched_waking histogram is shown as normal paragraph
instead due to codeblock marker for the following diagram being in the
same line as the section underline. Separate them.

Fixes: daceabf1b494 ("tracing/doc: Fix ascii-art in histogram-design.rst")
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 Documentation/trace/histogram-design.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/trace/histogram-design.rst b/Documentation/trace/histogram-design.rst
index 231a12bd7d461c..4faff1669b77bd 100644
--- a/Documentation/trace/histogram-design.rst
+++ b/Documentation/trace/histogram-design.rst
@@ -380,7 +380,9 @@ entry, ts0, corresponding to the ts0 variable in the sched_waking
 trigger above.
 
 sched_waking histogram
-----------------------::
+----------------------
+
+.. code-block::
 
   +------------------+
   | hist_data        |<-------------------------------------------------------+
-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 3/5] Documentation: trace: historgram-design: Separate sched_waking histogram section heading and the following diagram
Posted by Tom Zanussi 2 weeks, 3 days ago
On Thu, 2025-09-11 at 11:25 +0700, Bagas Sanjaya wrote:
> Section heading for sched_waking histogram is shown as normal
> paragraph
> instead due to codeblock marker for the following diagram being in
> the
> same line as the section underline. Separate them.
> 
> 

Small typo in the subject line, s/historgram/histogram but otherwise
looks good.

Thanks,

Reviewed-by: Tom Zanussi <zanussi@kernel.org>

> Fixes: daceabf1b494 ("tracing/doc: Fix ascii-art in histogram-
> design.rst")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Documentation/trace/histogram-design.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/histogram-design.rst
> b/Documentation/trace/histogram-design.rst
> index 231a12bd7d461c..4faff1669b77bd 100644
> --- a/Documentation/trace/histogram-design.rst
> +++ b/Documentation/trace/histogram-design.rst
> @@ -380,7 +380,9 @@ entry, ts0, corresponding to the ts0 variable in
> the sched_waking
>  trigger above.
>  
>  sched_waking histogram
> -----------------------::
> +----------------------
> +
> +.. code-block::
>  
>    +------------------+
>    | hist_data        |<---------------------------------------------
> ----------+
Re: [PATCH 3/5] Documentation: trace: historgram-design: Separate sched_waking histogram section heading and the following diagram
Posted by Masami Hiramatsu (Google) 2 weeks, 6 days ago
On Thu, 11 Sep 2025 11:25:25 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:

> Section heading for sched_waking histogram is shown as normal paragraph
> instead due to codeblock marker for the following diagram being in the
> same line as the section underline. Separate them.
> 

Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you!

> Fixes: daceabf1b494 ("tracing/doc: Fix ascii-art in histogram-design.rst")
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Documentation/trace/histogram-design.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/histogram-design.rst b/Documentation/trace/histogram-design.rst
> index 231a12bd7d461c..4faff1669b77bd 100644
> --- a/Documentation/trace/histogram-design.rst
> +++ b/Documentation/trace/histogram-design.rst
> @@ -380,7 +380,9 @@ entry, ts0, corresponding to the ts0 variable in the sched_waking
>  trigger above.
>  
>  sched_waking histogram
> -----------------------::
> +----------------------
> +
> +.. code-block::
>  
>    +------------------+
>    | hist_data        |<-------------------------------------------------------+
> -- 
> An old man doll... just what I always wanted! - Clara
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>