1. Patchew
  2. linux
  3. View series

[PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec

Stephan Gerhold posted 4 patches 2 weeks, 6 days ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
.../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
4 files changed, 101 insertions(+)
[PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Stephan Gerhold 2 weeks, 6 days ago 
Add the necessary definitions to enable the IRIS video codec for
accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
additions are largely copied as-is from sm8550.dtsi with some minor changes
necessary for X1E.

The PAS interface used to boot the IRIS firmware is not functional in EL2.
The code to start it without using PAS exists already in the Venus driver,
but was not ported over to IRIS yet. Discussions how to model the
video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
now to avoid regressions when running in EL2.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Stephan Gerhold (4):
      arm64: dts: qcom: x1e80100: Add IRIS video codec
      arm64: dts: qcom: x1-el2: Disable IRIS for now
      arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
      arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS

 arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
 .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
 arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
 4 files changed, 101 insertions(+)
---
base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
change-id: 20250909-x1e-iris-dt-eb0494a130ca

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Trilok Soni 2 weeks, 6 days ago 
On 9/11/2025 11:38 AM, Stephan Gerhold wrote:
> Add the necessary definitions to enable the IRIS video codec for
> accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> additions are largely copied as-is from sm8550.dtsi with some minor changes
> necessary for X1E.
> 
> The PAS interface used to boot the IRIS firmware is not functional in EL2.

Just to confirm my understanding of above statement. The patches below
works w/ the Gunyah and Linux running at NS-EL1 and "not functional in
EL2" means Video working w/ the KVM Hypervisor on X1E right? 

> The code to start it without using PAS exists already in the Venus driver,
> but was not ported over to IRIS yet. Discussions how to model the
> video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
> now to avoid regressions when running in EL2.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (4):
>       arm64: dts: qcom: x1e80100: Add IRIS video codec
>       arm64: dts: qcom: x1-el2: Disable IRIS for now
>       arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
>       arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS
> 
>  arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
>  4 files changed, 101 insertions(+)
> ---
> base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
> change-id: 20250909-x1e-iris-dt-eb0494a130ca
> 
> Best regards,


-- 
---Trilok Soni
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Stephan Gerhold 2 weeks, 6 days ago 
On Thu, Sep 11, 2025 at 12:02:54PM -0700, Trilok Soni wrote:
> On 9/11/2025 11:38 AM, Stephan Gerhold wrote:
> > Add the necessary definitions to enable the IRIS video codec for
> > accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> > additions are largely copied as-is from sm8550.dtsi with some minor changes
> > necessary for X1E.
> > 
> > The PAS interface used to boot the IRIS firmware is not functional in EL2.
> 
> Just to confirm my understanding of above statement. The patches below
> works w/ the Gunyah and Linux running at NS-EL1 and "not functional in
> EL2" means Video working w/ the KVM Hypervisor on X1E right? 
> 

Yes, the patches enable video acceleration when running Linux with
Gunyah as usual. I added an extra patch to disable IRIS when running
with KVM, because my patches would introduce regressions otherwise.

The old Venus driver does support starting the video firmware when
running without Gunyah (for KVM on the Chrome platforms). The same code
works for KVM on X1E, so we could easily enable it once there is a
solution for the describing the video-firmware IOMMU in the device tree.
Mukesh is working on solving that for SA8775p [1].

[1]: https://lore.kernel.org/linux-arm-msm/20250819165447.4149674-12-mukesh.ojha@oss.qualcomm.com/

Thanks,
Stephan
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Neil Armstrong 2 weeks, 6 days ago 
On 11/09/2025 20:38, Stephan Gerhold wrote:
> Add the necessary definitions to enable the IRIS video codec for
> accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> additions are largely copied as-is from sm8550.dtsi with some minor changes
> necessary for X1E.
> 
> The PAS interface used to boot the IRIS firmware is not functional in EL2.
> The code to start it without using PAS exists already in the Venus driver,
> but was not ported over to IRIS yet. Discussions how to model the
> video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
> now to avoid regressions when running in EL2.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (4):
>        arm64: dts: qcom: x1e80100: Add IRIS video codec
>        arm64: dts: qcom: x1-el2: Disable IRIS for now
>        arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
>        arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS
> 
>   arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
>   .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
>   arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
>   arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
>   4 files changed, 101 insertions(+)
> ---
> base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
> change-id: 20250909-x1e-iris-dt-eb0494a130ca
> 
> Best regards,

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on Thinkpad T14S OLED

Thanks,
Neil
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Bryan O'Donoghue 2 weeks, 6 days ago 
On 11/09/2025 19:38, Stephan Gerhold wrote:
> Add the necessary definitions to enable the IRIS video codec for
> accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> additions are largely copied as-is from sm8550.dtsi with some minor changes
> necessary for X1E.
> 
> The PAS interface used to boot the IRIS firmware is not functional in EL2.
> The code to start it without using PAS exists already in the Venus driver,
> but was not ported over to IRIS yet. Discussions how to model the
> video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
> now to avoid regressions when running in EL2.
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (4):
>        arm64: dts: qcom: x1e80100: Add IRIS video codec
>        arm64: dts: qcom: x1-el2: Disable IRIS for now
>        arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
>        arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS
> 
>   arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
>   .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
>   arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
>   arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
>   4 files changed, 101 insertions(+)
> ---
> base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
> change-id: 20250909-x1e-iris-dt-eb0494a130ca
> 
> Best regards,
> --
> Stephan Gerhold <stephan.gerhold@linaro.org>
> 
> 

Could you please include the Dell Thena variants in v2 ?

---
bod
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Stephan Gerhold 2 weeks, 6 days ago 
On Fri, Sep 12, 2025 at 11:24:21AM +0100, Bryan O'Donoghue wrote:
> On 11/09/2025 19:38, Stephan Gerhold wrote:
> > Add the necessary definitions to enable the IRIS video codec for
> > accelerated video decoding on the X1E CRD and Lenovo ThinkPad T14s. The
> > additions are largely copied as-is from sm8550.dtsi with some minor changes
> > necessary for X1E.
> > 
> > The PAS interface used to boot the IRIS firmware is not functional in EL2.
> > The code to start it without using PAS exists already in the Venus driver,
> > but was not ported over to IRIS yet. Discussions how to model the
> > video-firmware IOMMU are still ongoing, so disable IRIS in x1-el2.dtso for
> > now to avoid regressions when running in EL2.
> > 
> > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> > ---
> > Stephan Gerhold (4):
> >        arm64: dts: qcom: x1e80100: Add IRIS video codec
> >        arm64: dts: qcom: x1-el2: Disable IRIS for now
> >        arm64: dts: qcom: x1e80100-crd: Enable IRIS video codec
> >        arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Enable IRIS
> > 
> >   arch/arm64/boot/dts/qcom/x1-el2.dtso               |  5 ++
> >   .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi    |  5 ++
> >   arch/arm64/boot/dts/qcom/x1e80100-crd.dts          |  4 +
> >   arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 87 ++++++++++++++++++++++
> >   4 files changed, 101 insertions(+)
> > ---
> > base-commit: 8f21d9da46702c4d6951ba60ca8a05f42870fe8f
> > change-id: 20250909-x1e-iris-dt-eb0494a130ca
> > 
> > Best regards,
> > --
> > Stephan Gerhold <stephan.gerhold@linaro.org>
> > 
> > 
> 
> Could you please include the Dell Thena variants in v2 ?
> 

I didn't include that because the firmware-name setup isn't as
straightforward for that as for the T14s. I think all the Thena variants
have existing "firmware-name"s for ADSP though, so I can try to make a
patch that adopts the existing prefix for all the laptops that make use
of x1-dell-thena.dtsi. Or even better would be if you can send me a
tested patch to include. :-)

Thanks,
Stephan
Re: [PATCH 0/4] arm64: dts: qcom: x1e80100: Add IRIS video codec
Posted by Anthony Ruhier 2 weeks, 3 days ago 
Thanks Stephan!

Tested-by: Anthony Ruhier <aruhier@mailbox.org>

Here is the diff for the Slim 7x (with a Signed-off-by, not sure if it's necessary):

Signed-off-by: Anthony Ruhier <aruhier@mailbox.org>
---

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index b7dc436a99da..6fe93d0a05a4 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -1102,6 +1102,11 @@ touchscreen@14 {
 	};
 };

+&iris {
+	firmware-name = "qcom/x1e80100/LENOVO/83ED/qcvss8380.mbn";
+	status = "okay";
+};
+
 &lpass_tlmm {
 	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
 		pins = "gpio12";

--
Anthony Ruhier

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.