[PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

Marco Felsch posted 5 patches 2 weeks, 6 days ago
[PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example
Posted by Marco Felsch 2 weeks, 6 days ago
Add an usb hub vbus-supply example to make it easier for users to
understand the binding, after the usb-device.yaml gained the support for
it.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index 4e3901efed3fcd4fbbd8cb777f9df4fcadf2ca00..9874bbd03e31fd7ff1c439eb860a15617f147406 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -86,5 +86,12 @@ examples:
                 compatible = "usbb95,772b";
                 reg = <1>;
             };
+
+            /* VBUS on the 2nd port is managed by the host */
+            ethernet@2 {
+                compatible = "usbb95,772b";
+                reg = <2>;
+                vbus-supply = <&reg_5v0_vbus>;
+            };
         };
     };

-- 
2.47.3
Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example
Posted by Rob Herring (Arm) 2 weeks, 6 days ago
On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> Add an usb hub vbus-supply example to make it easier for users to
> understand the binding, after the usb-device.yaml gained the support for
> it.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250911-v6-16-topic-usb-onboard-dev-v4-4-1af288125d74@pengutronix.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example
Posted by Marco Felsch 2 weeks, 6 days ago
On 25-09-11, Rob Herring (Arm) wrote:
> 
> On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > Add an usb hub vbus-supply example to make it easier for users to
> > understand the binding, after the usb-device.yaml gained the support for
> > it.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#

Well this is just an example on how to use it, we can drop this patch of
course.

Regards,
  Marco
Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example
Posted by Rob Herring 2 weeks, 6 days ago
On Fri, Sep 12, 2025 at 10:51:56AM +0200, Marco Felsch wrote:
> On 25-09-11, Rob Herring (Arm) wrote:
> > 
> > On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > > Add an usb hub vbus-supply example to make it easier for users to
> > > understand the binding, after the usb-device.yaml gained the support for
> > > it.
> > > 
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
> 
> Well this is just an example on how to use it, we can drop this patch of
> course.

Yes, but how's it going to work for an actual user?

Rob
Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example
Posted by Marco Felsch 2 weeks, 6 days ago
On 25-09-12, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 10:51:56AM +0200, Marco Felsch wrote:
> > On 25-09-11, Rob Herring (Arm) wrote:
> > > 
> > > On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > > > Add an usb hub vbus-supply example to make it easier for users to
> > > > understand the binding, after the usb-device.yaml gained the support for
> > > > it.
> > > > 
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > > >  Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > > 	from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
> > 
> > Well this is just an example on how to use it, we can drop this patch of
> > course.
> 
> Yes, but how's it going to work for an actual user?

What do you mean? It's working as you requested:

  hub@1 {
  	compatible = "..";
	reg = <1>;

	device@1 {
		compatible = "..";
		reg = <1>;
		
		vbus-supply = <&vbus_supply_port1>;
	};

	device@4 {
		compatible = "..";
		reg = <4>;
		
		vbus-supply = <&vbus_supply_port4>;
	};
  };

> 
> Rob
>