Document the MDSS hardware found on the Qualcomm QCS8300 platform.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../bindings/display/msm/qcom,qcs8300-mdss.yaml | 286 +++++++++++++++++++++
1 file changed, 286 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
new file mode 100644
index 000000000000..e96baaae9ba9
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
@@ -0,0 +1,286 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/qcom,qcs8300-mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. QCS8300 Display MDSS
+
+maintainers:
+ - Yongxing Mou <yongxing.mou@oss.qualcomm.com>
+
+description:
+ QCS8300 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
+ DPU display controller, DP interfaces and EDP etc.
+
+$ref: /schemas/display/msm/mdss-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,qcs8300-mdss
+
+ clocks:
+ items:
+ - description: Display AHB
+ - description: Display hf AXI
+ - description: Display core
+
+ iommus:
+ maxItems: 1
+
+ interconnects:
+ maxItems: 3
+
+ interconnect-names:
+ maxItems: 3
+
+patternProperties:
+ "^display-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-dpu
+
+ "^displayport-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-dp
+
+ "^phy@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ contains:
+ const: qcom,qcs8300-edp-phy
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,qcs8300-gcc.h>
+ #include <dt-bindings/clock/qcom,sa8775p-dispcc.h>
+ #include <dt-bindings/interconnect/qcom,qcs8300-rpmh.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ mdss: display-subsystem@ae00000 {
+ compatible = "qcom,qcs8300-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+
+ interconnects = <&mmss_noc MASTER_MDP0 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_MDP1 QCOM_ICC_TAG_ACTIVE_ONLY
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "mdp0-mem",
+ "mdp1-mem",
+ "cpu-cfg";
+
+ resets = <&dispcc_core_bcr>;
+ power-domains = <&dispcc_gdsc>;
+
+ clocks = <&dispcc_ahb_clk>,
+ <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc_mdp_clk>;
+
+ interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu 0x1000 0x402>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ display-controller@ae01000 {
+ compatible = "qcom,qcs8300-dpu", "qcom,sa8775p-dpu";
+ reg = <0x0ae01000 0x8f000>,
+ <0x0aeb0000 0x2008>;
+ reg-names = "mdp", "vbif";
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "nrt_bus",
+ "iface",
+ "lut",
+ "core",
+ "vsync";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ assigned-clock-rates = <19200000>;
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
+ };
+ };
+ };
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-375000000 {
+ opp-hz = /bits/ 64 <375000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-500000000 {
+ opp-hz = /bits/ 64 <500000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+
+ opp-575000000 {
+ opp-hz = /bits/ 64 <575000000>;
+ required-opps = <&rpmhpd_opp_turbo>;
+ };
+
+ opp-650000000 {
+ opp-hz = /bits/ 64 <650000000>;
+ required-opps = <&rpmhpd_opp_turbo_l1>;
+ };
+ };
+ };
+
+ mdss_dp0_phy: phy@aec2a00 {
+ compatible = "qcom,qcs8300-edp-phy", "qcom,sa8775p-edp-phy";
+
+ reg = <0x0aec2a00 0x200>,
+ <0x0aec2200 0xd0>,
+ <0x0aec2600 0xd0>,
+ <0x0aec2000 0x1c8>;
+
+ clocks = <&dispcc MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc MDSS_DISP_CC_MDSS_AHB_CLK>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4a>;
+ };
+
+ displayport-controller@af54000 {
+ compatible = "qcom,qcs8300-dp", "qcom,sa8775p-dp";
+
+ pinctrl-0 = <&dp_hot_plug_det>;
+ pinctrl-names = "default";
+
+ reg = <0xaf54000 0x104>,
+ <0xaf54200 0x0c0>,
+ <0xaf55000 0x770>,
+ <0xaf56000 0x09c>,
+ <0xaf57000 0x09c>,
+ <0xaf58000 0x09c>,
+ <0xaf59000 0x09c>,
+ <0xaf5a000 0x23c>,
+ <0xaf5b000 0x23c>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <12>;
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel",
+ "stream_1_pixel",
+ "stream_2_pixel",
+ "stream_3_pixel";
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK_SRC>;
+ assigned-clock-parents = <&mdss_dp0_phy 0>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>,
+ <&mdss_dp0_phy 1>;
+ phys = <&mdss_dp0_phy>;
+ phy-names = "dp";
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mdss_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mdss_dp_out: endpoint { };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+ };
+...
--
2.43.0On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote: > Document the MDSS hardware found on the Qualcomm QCS8300 platform. > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> Patch v11 and still basic issues. I am very dissapointed. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 9/18/2025 9:01 AM, Krzysztof Kozlowski wrote: > On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote: >> Document the MDSS hardware found on the Qualcomm QCS8300 platform. >> >> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > > Patch v11 and still basic issues. I am very dissapointed. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. > > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > Hi, Sorry for the confusion. I did intend to remove the Reviewed-by tag, and I mentioned this in the cover letter, but maybe explanation in cover-letter was probe not clear at all. This patch includes three changes: 1.In the displayport-controller compatible property, "items" was changed to "contains". 2.Use "qcom,sa8775p-dp" as fallback. These changes might not be considered significant. So I’ll be more careful next time. Thanks~
On 18/09/2025 13:14, Yongxing Mou wrote: > > > On 9/18/2025 9:01 AM, Krzysztof Kozlowski wrote: >> On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote: >>> Document the MDSS hardware found on the Qualcomm QCS8300 platform. >>> >>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> >> >> Patch v11 and still basic issues. I am very dissapointed. >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions of patchset, under or above your Signed-off-by tag, unless >> patch changed significantly (e.g. new properties added to the DT >> bindings). Tag is "received", when provided in a message replied to you >> on the mailing list. Tools like b4 can help here. However, there's no >> need to repost patches *only* to add the tags. The upstream maintainer >> will do that for tags received on the version they apply. >> >> Please read: >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> >> >> Best regards, >> Krzysztof >> > Hi, > Sorry for the confusion. I did intend to remove the Reviewed-by tag, and > I mentioned this in the cover letter, but maybe explanation in > cover-letter was probe not clear at all. > > This patch includes three changes: > > 1.In the displayport-controller compatible property, "items" was changed > to "contains". > 2.Use "qcom,sa8775p-dp" as fallback. > > These changes might not be considered significant. So I’ll be more > careful next time. Thanks~ I really do not expect v12 to receive so significant changes in the first place. If you keep sending us buggy code, which then you keep changing after review, I will just not do the review. It's easier for me to wait for v20... Best regards, Krzysztof
On Fri, Sep 19, 2025 at 01:34:39PM +0900, Krzysztof Kozlowski wrote: > On 18/09/2025 13:14, Yongxing Mou wrote: > > > > > > On 9/18/2025 9:01 AM, Krzysztof Kozlowski wrote: > >> On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote: > >>> Document the MDSS hardware found on the Qualcomm QCS8300 platform. > >>> > >>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > >> > >> Patch v11 and still basic issues. I am very dissapointed. > >> > >> <form letter> > >> This is a friendly reminder during the review process. > >> > >> It looks like you received a tag and forgot to add it. > >> > >> If you do not know the process, here is a short explanation: > >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new > >> versions of patchset, under or above your Signed-off-by tag, unless > >> patch changed significantly (e.g. new properties added to the DT > >> bindings). Tag is "received", when provided in a message replied to you > >> on the mailing list. Tools like b4 can help here. However, there's no > >> need to repost patches *only* to add the tags. The upstream maintainer > >> will do that for tags received on the version they apply. > >> > >> Please read: > >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > >> > >> If a tag was not added on purpose, please state why and what changed. > >> </form letter> > >> > >> Best regards, > >> Krzysztof > >> > > Hi, > > Sorry for the confusion. I did intend to remove the Reviewed-by tag, and > > I mentioned this in the cover letter, but maybe explanation in > > cover-letter was probe not clear at all. > > > > This patch includes three changes: > > > > 1.In the displayport-controller compatible property, "items" was changed > > to "contains". > > 2.Use "qcom,sa8775p-dp" as fallback. > > > > These changes might not be considered significant. So I’ll be more > > careful next time. Thanks~ > > > I really do not expect v12 to receive so significant changes in the > first place. If you keep sending us buggy code, which then you keep > changing after review, I will just not do the review. It's easier for me > to wait for v20... I'm not sure how to react to this missage. The changes reflect the process in other patchsets and in my understanding on how to describe the particular hardware block. The changes were reflected in the changelog. If you plan to review this patchset once you get back from your vacation, that's fine. If you don't plan to, I can ask Yongxing to send v20 just for that number. -- With best wishes Dmitry
On 9/19/2025 12:34 PM, Krzysztof Kozlowski wrote: > On 18/09/2025 13:14, Yongxing Mou wrote: >> >> >> On 9/18/2025 9:01 AM, Krzysztof Kozlowski wrote: >>> On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote: >>>> Document the MDSS hardware found on the Qualcomm QCS8300 platform. >>>> >>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> >>> >>> Patch v11 and still basic issues. I am very dissapointed. >>> >>> <form letter> >>> This is a friendly reminder during the review process. >>> >>> It looks like you received a tag and forgot to add it. >>> >>> If you do not know the process, here is a short explanation: >>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >>> versions of patchset, under or above your Signed-off-by tag, unless >>> patch changed significantly (e.g. new properties added to the DT >>> bindings). Tag is "received", when provided in a message replied to you >>> on the mailing list. Tools like b4 can help here. However, there's no >>> need to repost patches *only* to add the tags. The upstream maintainer >>> will do that for tags received on the version they apply. >>> >>> Please read: >>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 >>> >>> If a tag was not added on purpose, please state why and what changed. >>> </form letter> >>> >>> Best regards, >>> Krzysztof >>> >> Hi, >> Sorry for the confusion. I did intend to remove the Reviewed-by tag, and >> I mentioned this in the cover letter, but maybe explanation in >> cover-letter was probe not clear at all. >> >> This patch includes three changes: >> >> 1.In the displayport-controller compatible property, "items" was changed >> to "contains". >> 2.Use "qcom,sa8775p-dp" as fallback. >> >> These changes might not be considered significant. So I’ll be more >> careful next time. Thanks~ > > > I really do not expect v12 to receive so significant changes in the > first place. If you keep sending us buggy code, which then you keep > changing after review, I will just not do the review. It's easier for me > to wait for v20... > > > Best regards, > Krzysztof Hi, this is the final version and i will be careful going forward.. Thanks~~
© 2016 - 2025 Red Hat, Inc.