[PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment

Johan Hovold posted 1 patch 3 weeks, 1 day ago
drivers/clk/qcom/gcc-sc8280xp.c | 4 ----
1 file changed, 4 deletions(-)
[PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
Posted by Johan Hovold 3 weeks, 1 day ago
Drop an obsolete comment about keeping the PCIe GDSCs always-on,
something which is no longer the case since commit db382dd55bcb ("clk:
qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/clk/qcom/gcc-sc8280xp.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
index f27d0003f427..b683795475e3 100644
--- a/drivers/clk/qcom/gcc-sc8280xp.c
+++ b/drivers/clk/qcom/gcc-sc8280xp.c
@@ -6775,10 +6775,6 @@ static struct gdsc pcie_1_tunnel_gdsc = {
 	.flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
-/*
- * The Qualcomm PCIe driver does not yet implement suspend so to keep the
- * PCIe power domains always-on for now.
- */
 static struct gdsc pcie_2a_gdsc = {
 	.gdscr = 0x9d004,
 	.collapse_ctrl = 0x52128,
-- 
2.49.1
Re: [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
Posted by Bjorn Andersson 2 weeks, 6 days ago
On Wed, 10 Sep 2025 15:47:37 +0200, Johan Hovold wrote:
> Drop an obsolete comment about keeping the PCIe GDSCs always-on,
> something which is no longer the case since commit db382dd55bcb ("clk:
> qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").
> 
> 

Applied, thanks!

[1/1] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
      commit: 4ca6a89f38718d6cd84304e6a26e7ddc90e03356

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
Posted by Konrad Dybcio 3 weeks, 1 day ago
On 9/10/25 3:47 PM, Johan Hovold wrote:
> Drop an obsolete comment about keeping the PCIe GDSCs always-on,
> something which is no longer the case since commit db382dd55bcb ("clk:
> qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

They're not quite off yet, but they're not perma-on either, so I
suppose it makes sense:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad