[PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC

Mohammad Rafi Shaik posted 1 patch 3 weeks, 1 day ago
arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
Posted by Mohammad Rafi Shaik 3 weeks, 1 day ago
The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
previously reused the sound card compatible as "qcom,qcs8275-sndcard",
which is based on existing coverage. To maintain clarity and consistency,
the naming conventions for the compatible should reflect actual SoC
rather than the board. Therefore, update the sound card compatible as
"qcom,qcs8300-sndcard" to avoid potential confusion.

Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
---
This patch series depends on patch series:
https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index f3c5d363921e..7187c1760ef5 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
 	};
 
 	sound {
-		compatible = "qcom,qcs8275-sndcard";
+		compatible = "qcom,qcs8300-sndcard";
 		model = "MONACO-EVK";
 
 		pinctrl-0 = <&hs0_mi2s_active>, <&mi2s1_active>;
-- 
2.34.1
Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
Posted by Krzysztof Kozlowski 3 weeks, 1 day ago
On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",
> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
> This patch series depends on patch series:
> https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index f3c5d363921e..7187c1760ef5 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
>  	};
>  
>  	sound {
> -		compatible = "qcom,qcs8275-sndcard";
> +		compatible = "qcom,qcs8300-sndcard";

The other patch claims that changing binding would be ABI break, so
obviously here is actual impact on users.

Also, the other patch explains that it is the same hardware, so we are
back at previous discussions (sc8380xp, sa8775p etc): we do not rename
compatibles just because your prefer something else now.

That's a NAK.

Best regards,
Krzysztof
Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC
Posted by Krzysztof Kozlowski 3 weeks, 1 day ago
On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",

So who is going to use qcom,qcs8275-sndcard compatible? I don't see any
DTS using it.

> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

Best regards,
Krzysztof