[PATCH v5] wifi: cfg80211: Remove the redundant wiphy_dev

Zheng tan posted 1 patch 3 weeks, 1 day ago
net/wireless/ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v5] wifi: cfg80211: Remove the redundant wiphy_dev
Posted by Zheng tan 3 weeks, 1 day ago
There is no need to call wiphy_dev again.Simplifying the
code makes it more readable.

Signed-off-by: Zheng tan <tanzheng@kylinos.cn>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
---
Changes in v5:
-Modify the From and Signed-off-by.

Changes in v4:
-Keep the from and Signed-off-by tags consistent.

Changes in v3:
- Modify the patch description.

Changes in v2:
- Delete the use of dev_name instead of pdev->driver->name.
  This is incorrect.

 net/wireless/ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/ethtool.c b/net/wireless/ethtool.c
index 2613d6ac0fda..46e4317cbd7e 100644
--- a/net/wireless/ethtool.c
+++ b/net/wireless/ethtool.c
@@ -23,7 +23,7 @@ void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
 	else
 		strscpy(info->fw_version, "N/A", sizeof(info->fw_version));
 
-	strscpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)),
+	strscpy(info->bus_info, dev_name(pdev),
 		sizeof(info->bus_info));
 }
 EXPORT_SYMBOL(cfg80211_get_drvinfo);
-- 
2.25.1
Re: [PATCH v5] wifi: cfg80211: Remove the redundant wiphy_dev
Posted by Johannes Berg 3 weeks, 1 day ago
On Wed, 2025-09-10 at 09:55 +0800, Zheng tan wrote:
> 
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

I'm going to remove that for you this time, but for the record: please
don't ever add tags that weren't _explicitly_ provided to you in email.

johannes