selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

[PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

Posted by Nai-Chen Cheng 3 weeks, 1 day ago

The selftests 'make clean' does not clean the net/lib because it only
processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
compiled objects in net/lib after cleaning, requiring manual cleanup.

Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
dependency is properly cleaned.

Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 030da61dbff3a7e4a22d61ba3972e248a43d374d..a2d8e1093b005c9af3570246dd8b10b59e44b46b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -314,7 +314,7 @@ gen_tar: install
 	@echo "Created ${TAR_PATH}"
 
 clean:
-	@for TARGET in $(TARGETS); do \
+	@for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \
 		BUILD_TARGET=$$BUILD/$$TARGET;	\
 		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;

---
base-commit: 9dd1835ecda5b96ac88c166f4a87386f3e727bd9
change-id: 20250910-selftests-makefile-clean-cc2fb70e9e32

Best regards,
-- 
Nai-Chen Cheng <bleach1827@gmail.com>

Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

Posted by Jakub Kicinski 2 weeks, 6 days ago

On Wed, 10 Sep 2025 19:30:32 +0800 Nai-Chen Cheng wrote:
> The selftests 'make clean' does not clean the net/lib because it only
> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
> compiled objects in net/lib after cleaning, requiring manual cleanup.
> 
> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
> dependency is properly cleaned.

Shuah, please LMK if think it makes sense for netdev to take this
(net/lib is the only DEP_TARGET today).

Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

Posted by Shuah Khan 2 weeks, 1 day ago

On 9/11/25 17:41, Jakub Kicinski wrote:
> On Wed, 10 Sep 2025 19:30:32 +0800 Nai-Chen Cheng wrote:
>> The selftests 'make clean' does not clean the net/lib because it only
>> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
>> compiled objects in net/lib after cleaning, requiring manual cleanup.
>>
>> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
>> dependency is properly cleaned.
> 
> Shuah, please LMK if think it makes sense for netdev to take this
> (net/lib is the only DEP_TARGET today).

No problems - take this through netdev

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

Re: [PATCH] selftests/Makefile: include $(INSTALL_DEP_TARGETS) in clean target to clean net/lib dependency

Posted by Simon Horman 3 weeks ago

On Wed, Sep 10, 2025 at 07:30:32PM +0800, Nai-Chen Cheng wrote:
> The selftests 'make clean' does not clean the net/lib because it only
> processes $(TARGETS) and ignores $(INSTALL_DEP_TARGETS). This leaves
> compiled objects in net/lib after cleaning, requiring manual cleanup.
> 
> Include $(INSTALL_DEP_TARGETS) in clean target to ensure net/lib
> dependency is properly cleaned.
> 
> Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested