[PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property ti,gpio-data

Guoniu Zhou posted 4 patches 3 weeks, 1 day ago
There is a newer version of this series
[PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property ti,gpio-data
Posted by Guoniu Zhou 3 weeks, 1 day ago
Add new property ti,gpio-data to let user select ds90ub953 gpio output
remote data coming from the compatible deserializer.

Signed-off-by: Guoniu Zhou <guoniu.zhou@nxp.com>
---
 Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..7c3144677f11004468ed3a3fba74e6eee2d259d2 100644
--- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
@@ -26,6 +26,16 @@ properties:
 
   gpio-controller: true
 
+  ti,gpio-data:
+    $ref: /schemas/types.yaml#/definitions/uint8
+    default: 0
+    minimum: 0
+    maximum: 15
+    description: |
+      Program each gpio pin to output remote data coming from compatible
+      deserializer using the LOCAL_GPIO_DATA[7:4] register. This property
+      has to be a '/bits/ 8' value.
+
   clocks:
     maxItems: 1
     description:

-- 
2.34.1
Re: [PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property ti,gpio-data
Posted by Vladimir Zapolskiy 3 weeks, 1 day ago
On 9/10/25 12:44, Guoniu Zhou wrote:
> Add new property ti,gpio-data to let user select ds90ub953 gpio output
> remote data coming from the compatible deserializer.
> 
> Signed-off-by: Guoniu Zhou <guoniu.zhou@nxp.com>
> ---
>   Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..7c3144677f11004468ed3a3fba74e6eee2d259d2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> @@ -26,6 +26,16 @@ properties:
>   
>     gpio-controller: true
>   
> +  ti,gpio-data:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    default: 0
> +    minimum: 0
> +    maximum: 15
> +    description: |
> +      Program each gpio pin to output remote data coming from compatible
> +      deserializer using the LOCAL_GPIO_DATA[7:4] register. This property
> +      has to be a '/bits/ 8' value.
> +

No, this shall be done as a GPIO controller function of the IC, and not
as a hardcoded (!) custom property.

>     clocks:
>       maxItems: 1
>       description:
> 

NAK, the approach is wrong.

-- 
Best wishes,
Vladimir