Enable IMX577 via CCI1 on LeMans EVK Core Kit.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Wenmeng Liu <quic_wenmliu@qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 4 +
arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso | 101 ++++++++++++++++++++++++
2 files changed, 105 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 0a7c308dec365263bbb7aa5f5cd306dbeacfd3f1..b27f60fbd527146027eebd4bb7b1f8a0a82b3af2 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -30,6 +30,10 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp449.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb
dtb-$(CONFIG_ARCH_QCOM) += lemans-evk.dtb
+
+lemans-evk-camera-dtbs := lemans-evk.dtb lemans-evk-camera.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-camera.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
new file mode 100644
index 0000000000000000000000000000000000000000..629992ced9b13b23505fc20562929a0ed17a9566
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
@@ -0,0 +1,101 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/*
+ * Camera Sensor overlay on top of LeMans EVK Core Kit.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/clock/qcom,sa8775p-camcc.h>
+#include <dt-bindings/gpio/gpio.h>
+
+&{/} {
+ vreg_cam1_1p8: vreg_cam1_1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_cam1_1p8";
+ startup-delay-us = <10000>;
+ enable-active-high;
+ gpio = <&pmm8654au_0_gpios 8 GPIO_ACTIVE_HIGH>;
+ };
+};
+
+&camss {
+ vdda-pll-supply = <&vreg_l1c>;
+ vdda-phy-supply = <&vreg_l4a>;
+
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ reg = <1>;
+
+ csiphy1_ep: endpoint {
+ clock-lanes = <7>;
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&imx577_ep1>;
+ };
+ };
+ };
+};
+
+&cci1 {
+ pinctrl-0 = <&cci1_0_default>;
+ pinctrl-1 = <&cci1_0_sleep>;
+
+ status = "okay";
+};
+
+&cci1_i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@1a {
+ compatible = "sony,imx577";
+ reg = <0x1a>;
+
+ reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+ pinctrl-0 = <&cam1_default>;
+ pinctrl-names = "default";
+
+ clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clock-rates = <24000000>;
+
+ dovdd-supply = <&vreg_s4a>;
+ avdd-supply = <&vreg_cam1_1p8>;
+
+ port {
+ imx577_ep1: endpoint {
+ clock-lanes = <7>;
+ link-frequencies = /bits/ 64 <600000000>;
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&csiphy1_ep>;
+ };
+ };
+ };
+};
+
+&tlmm {
+ cam1_default: cam1-default-state {
+ mclk-pins {
+ pins = "gpio73";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ rst-pins {
+ pins = "gpio133";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+};
--
2.34.1On Wed, Sep 10, 2025 at 07:06:23PM +0800, Wenmeng Liu wrote: > Enable IMX577 via CCI1 on LeMans EVK Core Kit. Is it a part of the Core Kit? Is it a part of some kind of mezzanine board? Why is it being enabled as an overlay instead of being a part of lemans-evk.dts? > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Wenmeng Liu <quic_wenmliu@qualcomm.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 4 + > arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso | 101 ++++++++++++++++++++++++ > 2 files changed, 105 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 0a7c308dec365263bbb7aa5f5cd306dbeacfd3f1..b27f60fbd527146027eebd4bb7b1f8a0a82b3af2 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -30,6 +30,10 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp449.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb > dtb-$(CONFIG_ARCH_QCOM) += lemans-evk.dtb > + > +lemans-evk-camera-dtbs := lemans-evk.dtb lemans-evk-camera.dtbo > + > +dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-camera.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb > diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso > new file mode 100644 > index 0000000000000000000000000000000000000000..629992ced9b13b23505fc20562929a0ed17a9566 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso > @@ -0,0 +1,101 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/* > + * Camera Sensor overlay on top of LeMans EVK Core Kit. This is pretty obvious from the file itself. > + */ > + > +/dts-v1/; > +/plugin/; > + -- With best wishes Dmitry
On 9/10/2025 11:23 PM, Dmitry Baryshkov wrote: > On Wed, Sep 10, 2025 at 07:06:23PM +0800, Wenmeng Liu wrote: >> Enable IMX577 via CCI1 on LeMans EVK Core Kit. > > Is it a part of the Core Kit? Is it a part of some kind of mezzanine > board? Why is it being enabled as an overlay instead of being a part of > lemans-evk.dts? > Since the sensor is not part of the default hardware configuration on the core kit, we adopt a device tree overlay solution to enable its integration dynamically. Thanks, Wenmeng
On Thu, Sep 11, 2025 at 01:45:59PM +0800, Wenmeng Liu wrote: > > > On 9/10/2025 11:23 PM, Dmitry Baryshkov wrote: > > On Wed, Sep 10, 2025 at 07:06:23PM +0800, Wenmeng Liu wrote: > > > Enable IMX577 via CCI1 on LeMans EVK Core Kit. > > > > Is it a part of the Core Kit? Is it a part of some kind of mezzanine > > board? Why is it being enabled as an overlay instead of being a part of > > lemans-evk.dts? > > > Since the sensor is not part of the default hardware configuration on the > core kit, we adopt a device tree overlay solution to enable its integration > dynamically. This is less helpful than a similar response to the similar monaco-evk question. Is it the only configuration that we are going to support? If not, then the overlay should be named accordingly. These details should be described in the commit message. -- With best wishes Dmitry
On 9/11/2025 6:15 PM, Dmitry Baryshkov wrote: > On Thu, Sep 11, 2025 at 01:45:59PM +0800, Wenmeng Liu wrote: >> >> >> On 9/10/2025 11:23 PM, Dmitry Baryshkov wrote: >>> On Wed, Sep 10, 2025 at 07:06:23PM +0800, Wenmeng Liu wrote: >>>> Enable IMX577 via CCI1 on LeMans EVK Core Kit. >>> >>> Is it a part of the Core Kit? Is it a part of some kind of mezzanine >>> board? Why is it being enabled as an overlay instead of being a part of >>> lemans-evk.dts? >>> >> Since the sensor is not part of the default hardware configuration on the >> core kit, we adopt a device tree overlay solution to enable its integration >> dynamically. > > This is less helpful than a similar response to the similar monaco-evk > question. > > Is it the only configuration that we are going to support? If not, then > the overlay should be named accordingly. > > These details should be described in the commit message. > Sure, I will update the commit message with an explanation in the next version. Thanks, Wenmeng
© 2016 - 2025 Red Hat, Inc.