When bulk-freeing an array of pages use release_pages() instead of freeing
them page-by-page:

Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 lib/alloc_tag.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
index e9b33848700a..95688c4cba7a 100644
--- a/lib/alloc_tag.c
+++ b/lib/alloc_tag.c
@@ -438,9 +438,10 @@ static int vm_module_tags_populate(void)
 		if (nr < more_pages ||
 		    vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,
 				     next_page, PAGE_SHIFT) < 0) {
+			release_pages_arg arg = { .pages = next_page };
+
 			/* Clean up and error out */
-			for (int i = 0; i < nr; i++)
-				__free_page(next_page[i]);
+			release_pages(arg, nr);
 			return -ENOMEM;
 		}
 
-- 
2.51.0.384.g4c02a37b29-goog

On 10/09/2025 00:34, Suren Baghdasaryan wrote:
> When bulk-freeing an array of pages use release_pages() instead of freeing
> them page-by-page:
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
>  lib/alloc_tag.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Usama Arif <usamaarif642@gmail.com>

> diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> index e9b33848700a..95688c4cba7a 100644
> --- a/lib/alloc_tag.c
> +++ b/lib/alloc_tag.c
> @@ -438,9 +438,10 @@ static int vm_module_tags_populate(void)
>  		if (nr < more_pages ||
>  		    vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,
>  				     next_page, PAGE_SHIFT) < 0) {
> +			release_pages_arg arg = { .pages = next_page };
> +
>  			/* Clean up and error out */
> -			for (int i = 0; i < nr; i++)
> -				__free_page(next_page[i]);
> +			release_pages(arg, nr);
>  			return -ENOMEM;
>  		}
>  

Maybe this can be done in free_mod_tags_mem as well?

On Wed, Sep 10, 2025 at 1:49 PM Usama Arif <usamaarif642@gmail.com> wrote:
>
>
>
> On 10/09/2025 00:34, Suren Baghdasaryan wrote:
> > When bulk-freeing an array of pages use release_pages() instead of freeing
> > them page-by-page:
> >
> > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> > ---
> >  lib/alloc_tag.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Usama Arif <usamaarif642@gmail.com>
>
> > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
> > index e9b33848700a..95688c4cba7a 100644
> > --- a/lib/alloc_tag.c
> > +++ b/lib/alloc_tag.c
> > @@ -438,9 +438,10 @@ static int vm_module_tags_populate(void)
> >               if (nr < more_pages ||
> >                   vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,
> >                                    next_page, PAGE_SHIFT) < 0) {
> > +                     release_pages_arg arg = { .pages = next_page };
> > +
> >                       /* Clean up and error out */
> > -                     for (int i = 0; i < nr; i++)
> > -                             __free_page(next_page[i]);
> > +                     release_pages(arg, nr);
> >                       return -ENOMEM;
> >               }
> >
>
> Maybe this can be done in free_mod_tags_mem as well?

Good point. I think I will respin this patchset with your suggestions
and will include one more fix for an issue that Shakeel just reported
(see https://lore.kernel.org/all/CAJuCfpGUjaZcs1r9ADKck_Ni7f41kHaiejR01Z0bE8pG0K1uXA@mail.gmail.com/).
Thanks!
Suren.

On Tue, Sep 09, 2025 at 04:34:07PM -0700, Suren Baghdasaryan wrote:
> When bulk-freeing an array of pages use release_pages() instead of freeing
> them page-by-page:
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>

Acked-by: Shakeel Butt <shakeel.butt@linux.dev>