mm: vm_event_item: Explicit #include for THREAD_SIZE

[PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE

Posted by Brian Norris 3 weeks, 2 days ago

This header uses THREAD_SIZE, which is provided by the thread_info.h
header but is not included in this header. Depending on the #include
ordering in other files, this can produce preprocessor errors.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 include/linux/vm_event_item.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 9e15a088ba38..92f80b4d69a6 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -2,6 +2,8 @@
 #ifndef VM_EVENT_ITEM_H_INCLUDED
 #define VM_EVENT_ITEM_H_INCLUDED
 
+#include <linux/thread_info.h>
+
 #ifdef CONFIG_ZONE_DMA
 #define DMA_ZONE(xx) xx##_DMA,
 #else
-- 
2.51.0.384.g4c02a37b29-goog

Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE

Posted by Lorenzo Stoakes 3 weeks ago

On Tue, Sep 09, 2025 at 01:13:57PM -0700, Brian Norris wrote:
> This header uses THREAD_SIZE, which is provided by the thread_info.h
> header but is not included in this header. Depending on the #include
> ordering in other files, this can produce preprocessor errors.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

This LGTM, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>
>  include/linux/vm_event_item.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
> index 9e15a088ba38..92f80b4d69a6 100644
> --- a/include/linux/vm_event_item.h
> +++ b/include/linux/vm_event_item.h
> @@ -2,6 +2,8 @@
>  #ifndef VM_EVENT_ITEM_H_INCLUDED
>  #define VM_EVENT_ITEM_H_INCLUDED
>
> +#include <linux/thread_info.h>
> +
>  #ifdef CONFIG_ZONE_DMA
>  #define DMA_ZONE(xx) xx##_DMA,
>  #else
> --
> 2.51.0.384.g4c02a37b29-goog
>

Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE

Posted by Andrew Morton 3 weeks, 1 day ago

On Tue,  9 Sep 2025 13:13:57 -0700 Brian Norris <briannorris@chromium.org> wrote:

> This header uses THREAD_SIZE, which is provided by the thread_info.h
> header but is not included in this header. Depending on the #include
> ordering in other files, this can produce preprocessor errors.
> 
> ...
>
> --- a/include/linux/vm_event_item.h
> +++ b/include/linux/vm_event_item.h
> @@ -2,6 +2,8 @@
>  #ifndef VM_EVENT_ITEM_H_INCLUDED
>  #define VM_EVENT_ITEM_H_INCLUDED
>  
> +#include <linux/thread_info.h>
> +
>  #ifdef CONFIG_ZONE_DMA
>  #define DMA_ZONE(xx) xx##_DMA,
>  #else

Is there a known configuraion which triggers this, or was this from
inspection?

Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE

Posted by Brian Norris 3 weeks, 1 day ago

On Tue, Sep 09, 2025 at 04:53:36PM -0700, Andrew Morton wrote:
> On Tue,  9 Sep 2025 13:13:57 -0700 Brian Norris <briannorris@chromium.org> wrote:
> 
> > This header uses THREAD_SIZE, which is provided by the thread_info.h
> > header but is not included in this header. Depending on the #include
> > ordering in other files, this can produce preprocessor errors.
> > 
> > ...
> >
> > --- a/include/linux/vm_event_item.h
> > +++ b/include/linux/vm_event_item.h
> > @@ -2,6 +2,8 @@
> >  #ifndef VM_EVENT_ITEM_H_INCLUDED
> >  #define VM_EVENT_ITEM_H_INCLUDED
> >  
> > +#include <linux/thread_info.h>
> > +
> >  #ifdef CONFIG_ZONE_DMA
> >  #define DMA_ZONE(xx) xx##_DMA,
> >  #else
> 
> Is there a known configuraion which triggers this, or was this from
> inspection?

The original trigger was a non-upstream driver that includes this
header. Since the root cause lay here, I figured I might as well patch
it at the origin.

Brian