Switch to GPL version of EXPORT_SYMBOL for vpdma_update_dma_addr() and Fix
a small alignment issue while at it.

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 drivers/media/platform/ti/vpe/vpdma.c | 7 ++++---
 drivers/media/platform/ti/vpe/vpdma.h | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/ti/vpe/vpdma.c b/drivers/media/platform/ti/vpe/vpdma.c
index b79b7e8479f9..29ee1918bc1c 100644
--- a/drivers/media/platform/ti/vpe/vpdma.c
+++ b/drivers/media/platform/ti/vpe/vpdma.c
@@ -568,8 +568,9 @@ static void dump_dtd(struct vpdma_dtd *dtd);
  * unmapped before the update and remapped after.
  */
 void vpdma_update_dma_addr(struct vpdma_data *vpdma,
-	struct vpdma_desc_list *list, dma_addr_t dma_addr,
-	void *write_dtd, int drop, int idx)
+			   struct vpdma_desc_list *list,
+			   dma_addr_t dma_addr,
+			   void *write_dtd, int drop, int idx)
 {
 	struct vpdma_dtd *dtd = list->buf.addr;
 	dma_addr_t write_desc_addr;
@@ -597,7 +598,7 @@ void vpdma_update_dma_addr(struct vpdma_data *vpdma,
 
 	dump_dtd(dtd);
 }
-EXPORT_SYMBOL(vpdma_update_dma_addr);
+EXPORT_SYMBOL_GPL(vpdma_update_dma_addr);
 
 void vpdma_set_max_size(struct vpdma_data *vpdma, int reg_addr,
 			u32 width, u32 height)
diff --git a/drivers/media/platform/ti/vpe/vpdma.h b/drivers/media/platform/ti/vpe/vpdma.h
index 393fcbb3cb40..5b3a0cd49a3c 100644
--- a/drivers/media/platform/ti/vpe/vpdma.h
+++ b/drivers/media/platform/ti/vpe/vpdma.h
@@ -223,8 +223,8 @@ int vpdma_submit_descs(struct vpdma_data *vpdma, struct vpdma_desc_list *list,
 		       int list_num);
 bool vpdma_list_busy(struct vpdma_data *vpdma, int list_num);
 void vpdma_update_dma_addr(struct vpdma_data *vpdma,
-	struct vpdma_desc_list *list, dma_addr_t dma_addr,
-	void *write_dtd, int drop, int idx);
+			   struct vpdma_desc_list *list, dma_addr_t dma_addr,
+			   void *write_dtd, int drop, int idx);
 
 /* VPDMA hardware list funcs */
 int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv);
-- 
2.34.1

On 09/09/2025 10:07, Yemike Abhilash Chandra wrote:
>  	struct vpdma_dtd *dtd = list->buf.addr;
>  	dma_addr_t write_desc_addr;
> @@ -597,7 +598,7 @@ void vpdma_update_dma_addr(struct vpdma_data *vpdma,
>  
>  	dump_dtd(dtd);
>  }
> -EXPORT_SYMBOL(vpdma_update_dma_addr);
> +EXPORT_SYMBOL_GPL(vpdma_update_dma_addr);

Don't add incorrect code to fix it immediately. Claiming that "you just
revert" is irrelevant here - we are not interested in the revert. Revert
or not, you add new code to the kernel, so that code must be correct.

if you reverted a commit, which was introducing a security bug, your
revert would bring that security bug and you find it okay?

No, NAK.

Best regards,
Krzysztof