[PATCH V3 2/5] media: platform: ti: Add kerneldoc for vpdma_update_dma_addr()

Yemike Abhilash Chandra posted 5 patches 3 weeks, 2 days ago
[PATCH V3 2/5] media: platform: ti: Add kerneldoc for vpdma_update_dma_addr()
Posted by Yemike Abhilash Chandra 3 weeks, 2 days ago
Add kerneldoc for vpdma_update_dma_addr() function.

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 drivers/media/platform/ti/vpe/vpdma.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/media/platform/ti/vpe/vpdma.c b/drivers/media/platform/ti/vpe/vpdma.c
index da90d7f03f82..b79b7e8479f9 100644
--- a/drivers/media/platform/ti/vpe/vpdma.c
+++ b/drivers/media/platform/ti/vpe/vpdma.c
@@ -552,6 +552,21 @@ EXPORT_SYMBOL(vpdma_submit_descs);
 
 static void dump_dtd(struct vpdma_dtd *dtd);
 
+/**
+ * vpdma_update_dma_addr() - update DMA address in a descriptor
+ * @vpdma: VPDMA device context
+ * @list: vpdma desc list to which we add this descriptor
+ * @dma_addr: new DMA address to program into the descriptor
+ * @write_dtd: descriptor pointer used to compute write-back address
+ * @drop: if true, set the drop bit in the write descriptor
+ * @idx: index of the descriptor in the list to update
+ *
+ * Updates dma addresses of the descriptor at @idx in @list.
+ * This allows reusing an existing descriptor list with a new buffer
+ * address, instead of rebuilding the list, which is needed when
+ * multiple clients share the same VPDMA engine. The list buffer is
+ * unmapped before the update and remapped after.
+ */
 void vpdma_update_dma_addr(struct vpdma_data *vpdma,
 	struct vpdma_desc_list *list, dma_addr_t dma_addr,
 	void *write_dtd, int drop, int idx)
-- 
2.34.1
Re: [PATCH V3 2/5] media: platform: ti: Add kerneldoc for vpdma_update_dma_addr()
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On 09/09/2025 10:07, Yemike Abhilash Chandra wrote:
> Add kerneldoc for vpdma_update_dma_addr() function.
> 
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
>  drivers/media/platform/ti/vpe/vpdma.c | 15 +++++++++++++++

Squash it with previous patch. You add there new function, so that
commit must be complete.

Don't add known incorrect code which you are fixing in the same patchset!

Best regards,
Krzysztof