1. Patchew
  2. linux
  3. View series

[PATCH] xfs: extend removed sysctls table

Bagas Sanjaya posted 1 patch 5 months ago 
Documentation/admin-guide/xfs.rst | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
[PATCH] xfs: extend removed sysctls table
Posted by Bagas Sanjaya 5 months ago 
Commit 21d59d00221e4e ("xfs: remove deprecated sysctl knobs") moves
recently-removed sysctls to the removed sysctls table but fails to
extend the table, hence triggering Sphinx warning:

Documentation/admin-guide/xfs.rst:365: ERROR: Malformed table.
Text in column margin in table line 8.

=============================   =======
  Name                          Removed
=============================   =======
  fs.xfs.xfsbufd_centisec       v4.0
  fs.xfs.age_buffer_centisecs   v4.0
  fs.xfs.irix_symlink_mode      v6.18
  fs.xfs.irix_sgid_inherit      v6.18
  fs.xfs.speculative_cow_prealloc_lifetime      v6.18
=============================   ======= [docutils]

Extend "Name" column of the table to fit the now-longest sysctl, which
is fs.xfs.speculative_cow_prealloc_lifetime.

Fixes: 21d59d00221e ("xfs: remove deprecated sysctl knobs")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20250908180406.32124fb7@canb.auug.org.au/
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 Documentation/admin-guide/xfs.rst | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
index d6f531f2c0e694..c85cd327af284d 100644
--- a/Documentation/admin-guide/xfs.rst
+++ b/Documentation/admin-guide/xfs.rst
@@ -355,15 +355,15 @@ None currently.
 Removed Sysctls
 ===============
 
-=============================	=======
-  Name				Removed
-=============================	=======
-  fs.xfs.xfsbufd_centisec	v4.0
-  fs.xfs.age_buffer_centisecs	v4.0
-  fs.xfs.irix_symlink_mode      v6.18
-  fs.xfs.irix_sgid_inherit      v6.18
-  fs.xfs.speculative_cow_prealloc_lifetime      v6.18
-=============================	=======
+==========================================   =======
+  Name                                       Removed
+==========================================   =======
+  fs.xfs.xfsbufd_centisec                    v4.0
+  fs.xfs.age_buffer_centisecs                v4.0
+  fs.xfs.irix_symlink_mode                   v6.18
+  fs.xfs.irix_sgid_inherit                   v6.18
+  fs.xfs.speculative_cow_prealloc_lifetime   v6.18
+==========================================   =======
 
 Error handling
 ==============

base-commit: e90dcba0a350836a5e1a1ac0f65f9e74644d7d3b
-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH] xfs: extend removed sysctls table
Posted by Carlos Maiolino 4 months, 3 weeks ago 
On Tue, 09 Sep 2025 07:04:31 +0700, Bagas Sanjaya wrote:
> Commit 21d59d00221e4e ("xfs: remove deprecated sysctl knobs") moves
> recently-removed sysctls to the removed sysctls table but fails to
> extend the table, hence triggering Sphinx warning:
> 
> Documentation/admin-guide/xfs.rst:365: ERROR: Malformed table.
> Text in column margin in table line 8.
> 
> [...]

Applied to for-next, thanks!

[1/1] xfs: extend removed sysctls table
      commit: e3df98d30369d7859a855bd3e500ea46205640ca

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>
Re: [PATCH] xfs: extend removed sysctls table
Posted by Darrick J. Wong 4 months, 3 weeks ago 
On Tue, Sep 09, 2025 at 07:04:31AM +0700, Bagas Sanjaya wrote:
> Commit 21d59d00221e4e ("xfs: remove deprecated sysctl knobs") moves
> recently-removed sysctls to the removed sysctls table but fails to
> extend the table, hence triggering Sphinx warning:
> 
> Documentation/admin-guide/xfs.rst:365: ERROR: Malformed table.
> Text in column margin in table line 8.
> 
> =============================   =======
>   Name                          Removed
> =============================   =======
>   fs.xfs.xfsbufd_centisec       v4.0
>   fs.xfs.age_buffer_centisecs   v4.0
>   fs.xfs.irix_symlink_mode      v6.18
>   fs.xfs.irix_sgid_inherit      v6.18
>   fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> =============================   ======= [docutils]
> 
> Extend "Name" column of the table to fit the now-longest sysctl, which
> is fs.xfs.speculative_cow_prealloc_lifetime.
> 
> Fixes: 21d59d00221e ("xfs: remove deprecated sysctl knobs")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20250908180406.32124fb7@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>

Oof, thanks for fixing that for me.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  Documentation/admin-guide/xfs.rst | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
> index d6f531f2c0e694..c85cd327af284d 100644
> --- a/Documentation/admin-guide/xfs.rst
> +++ b/Documentation/admin-guide/xfs.rst
> @@ -355,15 +355,15 @@ None currently.
>  Removed Sysctls
>  ===============
>  
> -=============================	=======
> -  Name				Removed
> -=============================	=======
> -  fs.xfs.xfsbufd_centisec	v4.0
> -  fs.xfs.age_buffer_centisecs	v4.0
> -  fs.xfs.irix_symlink_mode      v6.18
> -  fs.xfs.irix_sgid_inherit      v6.18
> -  fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> -=============================	=======
> +==========================================   =======
> +  Name                                       Removed
> +==========================================   =======
> +  fs.xfs.xfsbufd_centisec                    v4.0
> +  fs.xfs.age_buffer_centisecs                v4.0
> +  fs.xfs.irix_symlink_mode                   v6.18
> +  fs.xfs.irix_sgid_inherit                   v6.18
> +  fs.xfs.speculative_cow_prealloc_lifetime   v6.18
> +==========================================   =======
>  
>  Error handling
>  ==============
> 
> base-commit: e90dcba0a350836a5e1a1ac0f65f9e74644d7d3b
> -- 
> An old man doll... just what I always wanted! - Clara
>
Re: [PATCH] xfs: extend removed sysctls table
Posted by Randy Dunlap 5 months ago 

On 9/8/25 5:04 PM, Bagas Sanjaya wrote:
> Commit 21d59d00221e4e ("xfs: remove deprecated sysctl knobs") moves
> recently-removed sysctls to the removed sysctls table but fails to
> extend the table, hence triggering Sphinx warning:
> 
> Documentation/admin-guide/xfs.rst:365: ERROR: Malformed table.
> Text in column margin in table line 8.
> 
> =============================   =======
>   Name                          Removed
> =============================   =======
>   fs.xfs.xfsbufd_centisec       v4.0
>   fs.xfs.age_buffer_centisecs   v4.0
>   fs.xfs.irix_symlink_mode      v6.18
>   fs.xfs.irix_sgid_inherit      v6.18
>   fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> =============================   ======= [docutils]
> 
> Extend "Name" column of the table to fit the now-longest sysctl, which
> is fs.xfs.speculative_cow_prealloc_lifetime.
> 
> Fixes: 21d59d00221e ("xfs: remove deprecated sysctl knobs")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20250908180406.32124fb7@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  Documentation/admin-guide/xfs.rst | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
> index d6f531f2c0e694..c85cd327af284d 100644
> --- a/Documentation/admin-guide/xfs.rst
> +++ b/Documentation/admin-guide/xfs.rst
> @@ -355,15 +355,15 @@ None currently.
>  Removed Sysctls
>  ===============
>  
> -=============================	=======
> -  Name				Removed
> -=============================	=======
> -  fs.xfs.xfsbufd_centisec	v4.0
> -  fs.xfs.age_buffer_centisecs	v4.0
> -  fs.xfs.irix_symlink_mode      v6.18
> -  fs.xfs.irix_sgid_inherit      v6.18
> -  fs.xfs.speculative_cow_prealloc_lifetime      v6.18
> -=============================	=======
> +==========================================   =======
> +  Name                                       Removed
> +==========================================   =======
> +  fs.xfs.xfsbufd_centisec                    v4.0
> +  fs.xfs.age_buffer_centisecs                v4.0
> +  fs.xfs.irix_symlink_mode                   v6.18
> +  fs.xfs.irix_sgid_inherit                   v6.18
> +  fs.xfs.speculative_cow_prealloc_lifetime   v6.18
> +==========================================   =======
>  
>  Error handling
>  ==============
> 
> base-commit: e90dcba0a350836a5e1a1ac0f65f9e74644d7d3b

-- 
~Randy

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.