The 'resin' keys (usually connected to a volume-down button) are
generally not supposed to wake up the device from suspend, so explicitly
document a wakeup-source property to enable this wakeup behavior.

For 'pwrkey' the default stays that pressing the button does wake up the
device from suspend.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 .../bindings/input/qcom,pm8941-pwrkey.yaml          | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
index 62314a5fdce59bb00d1e8b86d6a29a091128aa50..62a08e675ef9511e0ae9ed9fbab5694ab7242c35 100644
--- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
+++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
@@ -10,9 +10,6 @@ maintainers:
   - Courtney Cavin <courtney.cavin@sonymobile.com>
   - Vinod Koul <vkoul@kernel.org>
 
-allOf:
-  - $ref: input.yaml#
-
 properties:
   compatible:
     enum:
@@ -36,6 +33,11 @@ properties:
            pin should be configured for pull up.
     $ref: /schemas/types.yaml#/definitions/flag
 
+  wakeup-source:
+    description: |
+           Button can wake-up the system. Only applicable for 'resin',
+           'pwrkey' always wakes the system by default.
+
   linux,code:
     description: |
            The input key-code associated with the power key.
@@ -43,6 +45,19 @@ properties:
            include/dt-bindings/input/linux-event-codes.h
            When property is omitted KEY_POWER is assumed.
 
+allOf:
+  - $ref: input.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,pm8941-pwrkey
+              - qcom,pmk8350-pwrkey
+    then:
+      properties:
+        wakeup-source: false
+
 required:
   - compatible
   - interrupts

-- 
2.51.0

On 09/09/2025 15:23, Luca Weiss wrote:
> The 'resin' keys (usually connected to a volume-down button) are
> generally not supposed to wake up the device from suspend, so explicitly
> document a wakeup-source property to enable this wakeup behavior.
> 
> For 'pwrkey' the default stays that pressing the button does wake up the
> device from suspend.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  .../bindings/input/qcom,pm8941-pwrkey.yaml          | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> index 62314a5fdce59bb00d1e8b86d6a29a091128aa50..62a08e675ef9511e0ae9ed9fbab5694ab7242c35 100644
> --- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> @@ -10,9 +10,6 @@ maintainers:
>    - Courtney Cavin <courtney.cavin@sonymobile.com>
>    - Vinod Koul <vkoul@kernel.org>
>  
> -allOf:
> -  - $ref: input.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -36,6 +33,11 @@ properties:
>             pin should be configured for pull up.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  wakeup-source:
> +    description: |
> +           Button can wake-up the system. Only applicable for 'resin',
> +           'pwrkey' always wakes the system by default.


I'll fix existing code, so don't repeat that style.


Best regards,
Krzysztof

On Tue, Sep 09, 2025 at 04:02:47PM +0200, Krzysztof Kozlowski wrote:
> On 09/09/2025 15:23, Luca Weiss wrote:
> > The 'resin' keys (usually connected to a volume-down button) are
> > generally not supposed to wake up the device from suspend, so explicitly
> > document a wakeup-source property to enable this wakeup behavior.
> > 
> > For 'pwrkey' the default stays that pressing the button does wake up the
> > device from suspend.
> > 
> > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > ---
> >  .../bindings/input/qcom,pm8941-pwrkey.yaml          | 21 ++++++++++++++++++---
> >  1 file changed, 18 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> > index 62314a5fdce59bb00d1e8b86d6a29a091128aa50..62a08e675ef9511e0ae9ed9fbab5694ab7242c35 100644
> > --- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> > +++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> > @@ -10,9 +10,6 @@ maintainers:
> >    - Courtney Cavin <courtney.cavin@sonymobile.com>
> >    - Vinod Koul <vkoul@kernel.org>
> >  
> > -allOf:
> > -  - $ref: input.yaml#
> > -
> >  properties:
> >    compatible:
> >      enum:
> > @@ -36,6 +33,11 @@ properties:
> >             pin should be configured for pull up.
> >      $ref: /schemas/types.yaml#/definitions/flag
> >  
> > +  wakeup-source:
> > +    description: |
> > +           Button can wake-up the system. Only applicable for 'resin',
> > +           'pwrkey' always wakes the system by default.
> 
> 
> I'll fix existing code, so don't repeat that style.

If you ack I can reformat on my side to match the patch you just sent.

Thanks.

-- 
Dmitry

On 09/09/2025 16:08, Dmitry Torokhov wrote:
>>>    compatible:
>>>      enum:
>>> @@ -36,6 +33,11 @@ properties:
>>>             pin should be configured for pull up.
>>>      $ref: /schemas/types.yaml#/definitions/flag
>>>  
>>> +  wakeup-source:
>>> +    description: |
>>> +           Button can wake-up the system. Only applicable for 'resin',
>>> +           'pwrkey' always wakes the system by default.
>>
>>
>> I'll fix existing code, so don't repeat that style.
> 
> If you ack I can reformat on my side to match the patch you just sent.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On 2025-09-09 16:33, Krzysztof Kozlowski wrote:
> On 09/09/2025 16:08, Dmitry Torokhov wrote:
>>>>    compatible:
>>>>      enum:
>>>> @@ -36,6 +33,11 @@ properties:
>>>>             pin should be configured for pull up.
>>>>      $ref: /schemas/types.yaml#/definitions/flag
>>>> 
>>>> +  wakeup-source:
>>>> +    description: |
>>>> +           Button can wake-up the system. Only applicable for 
>>>> 'resin',
>>>> +           'pwrkey' always wakes the system by default.
>>> 
>>> 
>>> I'll fix existing code, so don't repeat that style.
>> 
>> If you ack I can reformat on my side to match the patch you just sent.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for fixing that up Krzysztof! I noticed but didn't want to 
deviate
from the style just for this description. Of course better to fix the
formatting in the first place.

@Dmitry: Maybe give this patch some time (1-2 weeks?) to gather more 
feedback,
given the reasons outlined in the cover letter. Also on the driver 
patch.

Regards
Luca

> 
> Best regards,
> Krzysztof

On Tue, Sep 09, 2025 at 04:41:26PM +0200, Luca Weiss wrote:
> On 2025-09-09 16:33, Krzysztof Kozlowski wrote:
> > On 09/09/2025 16:08, Dmitry Torokhov wrote:
> > > > >    compatible:
> > > > >      enum:
> > > > > @@ -36,6 +33,11 @@ properties:
> > > > >             pin should be configured for pull up.
> > > > >      $ref: /schemas/types.yaml#/definitions/flag
> > > > > 
> > > > > +  wakeup-source:
> > > > > +    description: |
> > > > > +           Button can wake-up the system. Only applicable
> > > > > for 'resin',
> > > > > +           'pwrkey' always wakes the system by default.
> > > > 
> > > > 
> > > > I'll fix existing code, so don't repeat that style.
> > > 
> > > If you ack I can reformat on my side to match the patch you just sent.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Thanks for fixing that up Krzysztof! I noticed but didn't want to deviate
> from the style just for this description. Of course better to fix the
> formatting in the first place.
> 
> @Dmitry: Maybe give this patch some time (1-2 weeks?) to gather more
> feedback,
> given the reasons outlined in the cover letter. Also on the driver patch.

OK, I'll hold on to this for a couple of weeks.

Thanks.

-- 
Dmitry