drivers/clk/qcom/dispcc-glymur.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
'struct qcom_cc_desc' is passed to qcom_cc_map() and
qcom_cc_really_probe() only as pointer to const, so make the memory
const for safety.
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
---
This commit is similar to [1].
[1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org
---
drivers/clk/qcom/dispcc-glymur.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/dispcc-glymur.c b/drivers/clk/qcom/dispcc-glymur.c
index d755b41cf458a7cb9c22f510a16a414562432dab..5203fa6383f6ac7fb49e888887ee9105101a9b56 100644
--- a/drivers/clk/qcom/dispcc-glymur.c
+++ b/drivers/clk/qcom/dispcc-glymur.c
@@ -1945,7 +1945,7 @@ static struct qcom_cc_driver_data disp_cc_glymur_driver_data = {
.num_clk_cbcrs = ARRAY_SIZE(disp_cc_glymur_critical_cbcrs),
};
-static struct qcom_cc_desc disp_cc_glymur_desc = {
+static const struct qcom_cc_desc disp_cc_glymur_desc = {
.config = &disp_cc_glymur_regmap_config,
.clks = disp_cc_glymur_clocks,
.num_clks = ARRAY_SIZE(disp_cc_glymur_clocks),
---
base-commit: 65dd046ef55861190ecde44c6d9fcde54b9fb77d
change-id: 20250909-constify-dispcc-glymur-desc-fix-a3b615c8e146
Best regards,
--
Imran Shaik <imran.shaik@oss.qualcomm.com>
On Tue, 09 Sep 2025 15:17:59 +0530, Imran Shaik wrote: > 'struct qcom_cc_desc' is passed to qcom_cc_map() and > qcom_cc_really_probe() only as pointer to const, so make the memory > const for safety. > > Applied, thanks! [1/1] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc' commit: 9ff39b0468c3e04fee05d4e005d2fc03d28b1538 Best regards, -- Bjorn Andersson <andersson@kernel.org>
On 09/09/2025 11:47, Imran Shaik wrote: > 'struct qcom_cc_desc' is passed to qcom_cc_map() and > qcom_cc_really_probe() only as pointer to const, so make the memory > const for safety. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com> > --- > This commit is similar to [1]. > > [1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org > --- > drivers/clk/qcom/dispcc-glymur.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Uh, people need to stop copying downstream drivers. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Sep 09, 2025 at 03:17:59PM +0530, Imran Shaik wrote: > 'struct qcom_cc_desc' is passed to qcom_cc_map() and > qcom_cc_really_probe() only as pointer to const, so make the memory > const for safety. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com> > --- > This commit is similar to [1]. > > [1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org > --- > drivers/clk/qcom/dispcc-glymur.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry
© 2016 - 2025 Red Hat, Inc.