[v4] clk: amlogic: add video-related clocks for S4 SoC

[PATCH v4 1/2] dt-bindings: clock: add video clock indices for Amlogic S4 SoC

Posted by Chuan Liu via B4 Relay 18 hours ago

From: Chuan Liu <chuan.liu@amlogic.com>

Add indices for video encoder, demodulator and CVBS clocks.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
 include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h b/include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h
index 861a331963ac..b0fc549f53e3 100644
--- a/include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h
+++ b/include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h
@@ -232,5 +232,16 @@
 #define CLKID_HDCP22_SKPCLK_SEL		222
 #define CLKID_HDCP22_SKPCLK_DIV		223
 #define CLKID_HDCP22_SKPCLK		224
+#define CLKID_CTS_ENCL_SEL		225
+#define CLKID_CTS_ENCL			226
+#define CLKID_CDAC_SEL			227
+#define CLKID_CDAC_DIV			228
+#define CLKID_CDAC			229
+#define CLKID_DEMOD_CORE_SEL		230
+#define CLKID_DEMOD_CORE_DIV		231
+#define CLKID_DEMOD_CORE		232
+#define CLKID_ADC_EXTCLK_IN_SEL		233
+#define CLKID_ADC_EXTCLK_IN_DIV		234
+#define CLKID_ADC_EXTCLK_IN		235
 
 #endif /* _DT_BINDINGS_CLOCK_AMLOGIC_S4_PERIPHERALS_CLKC_H */

-- 
2.42.0

Re: [PATCH v4 1/2] dt-bindings: clock: add video clock indices for Amlogic S4 SoC

Posted by Krzysztof Kozlowski 18 hours ago

On 09/09/2025 09:29, Chuan Liu via B4 Relay wrote:
> From: Chuan Liu <chuan.liu@amlogic.com>
> 
> Add indices for video encoder, demodulator and CVBS clocks.
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

What?

You received one tag at v1, you ignored it.
Then you received another at v2, you ignored it.

You added these now... but:
Then third maintainer acked it THIRD DAMN TIME and you ignored it.

Three maintainers had to look at this little patch and yet you still
cannot collect the tags. You waste our time.

Best regards,
Krzysztof

Re: [PATCH v4 1/2] dt-bindings: clock: add video clock indices for Amlogic S4 SoC

Posted by Chuan Liu 16 hours ago

Hi Krzysztof & Conor:

On 9/9/2025 3:40 PM, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 09/09/2025 09:29, Chuan Liu via B4 Relay wrote:
>> From: Chuan Liu <chuan.liu@amlogic.com>
>>
>> Add indices for video encoder, demodulator and CVBS clocks.
>>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> What?
>
> You received one tag at v1, you ignored it.
> Then you received another at v2, you ignored it.
>
> You added these now... but:
> Then third maintainer acked it THIRD DAMN TIME and you ignored it.
>
> Three maintainers had to look at this little patch and yet you still
> cannot collect the tags. You waste our time.

My apologies for the unnecessary trouble this has caused. This was
indeed a rather basic oversight...

A few days ago, I used the command 'b4 trailers -u' which automatically
added your and Rob's tags. I then failed to notice that Conor had also
provided an 'Acked-by'.

Hi Conor:
         My apologies for missing your 'Acked-by' tag again. Do you think
it's necessary for me to send another revision to add it?  I'm concerned
about taking up more of yours time for what seems like a minor issue,
especially since the previous versions have already taken up yours time.

I'm truly sorry for this mistake.

>
> Best regards,
> Krzysztof