[PATCH v3] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for DSC

Harikrishna Shenoy posted 1 patch 3 weeks, 3 days ago
There is a newer version of this series
.../display/bridge/cdns,mhdp8546.yaml         | 20 +++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
[PATCH v3] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for DSC
Posted by Harikrishna Shenoy 3 weeks, 3 days ago
From: Swapnil Jakhade <sjakhade@cadence.com>

Add binding changes for DSC(Display Stream Compression) in the MHDP8546
DPI/DP bridge.

Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
---
Changelog v2 --> v3:
-Update the name of dsc register block.
-Add the reg-name list in conditional based on compatible.
Link to v2- https://lore.kernel.org/all/20250903111357.2605199-1-h-shenoy@ti.com/

 .../display/bridge/cdns,mhdp8546.yaml         | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
index c2b369456e4e..eb51f9595da8 100644
--- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
@@ -27,6 +27,8 @@ properties:
           Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
       - description:
           Register block of mhdptx sapb registers.
+      - description:
+          Register block for mhdptx DSC encoder registers.
 
   reg-names:
     minItems: 1
@@ -34,6 +36,7 @@ properties:
       - const: mhdptx
       - const: j721e-intg
       - const: mhdptx-sapb
+      - const: dsc
 
   clocks:
     maxItems: 1
@@ -100,18 +103,27 @@ allOf:
       properties:
         reg:
           minItems: 2
-          maxItems: 3
+          maxItems: 4
         reg-names:
           minItems: 2
-          maxItems: 3
+          maxItems: 4
+          items:
+            - const: mhdptx
+            - const: j721e-intg
+            - const: mhdptx-sapb
+            - const: dsc
     else:
       properties:
         reg:
           minItems: 1
-          maxItems: 2
+          maxItems: 3
         reg-names:
           minItems: 1
-          maxItems: 2
+          maxItems: 3
+          items:
+            - const: mhdptx
+            - const: mhdptx-sapb
+            - const: dsc
 
 required:
   - compatible
-- 
2.34.1
Re: [PATCH v3] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for DSC
Posted by Rob Herring (Arm) 3 weeks, 3 days ago
On Mon, 08 Sep 2025 11:16:09 +0530, Harikrishna Shenoy wrote:
> From: Swapnil Jakhade <sjakhade@cadence.com>
> 
> Add binding changes for DSC(Display Stream Compression) in the MHDP8546
> DPI/DP bridge.
> 
> Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---
> Changelog v2 --> v3:
> -Update the name of dsc register block.
> -Add the reg-name list in conditional based on compatible.
> Link to v2- https://lore.kernel.org/all/20250903111357.2605199-1-h-shenoy@ti.com/
> 
>  .../display/bridge/cdns,mhdp8546.yaml         | 20 +++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: allOf:0:else:properties:reg-names: {'minItems': 1, 'maxItems': 3, 'items': [{'const': 'mhdptx'}, {'const': 'mhdptx-sapb'}, {'const': 'dsc'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: allOf:0:then:properties:reg-names: {'minItems': 2, 'maxItems': 4, 'items': [{'const': 'mhdptx'}, {'const': 'j721e-intg'}, {'const': 'mhdptx-sapb'}, {'const': 'dsc'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250908054609.1113360-1-h-shenoy@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.