(This series resumes [1].)

This series adds CAMSS support for MSM8939.  It's mostly identical to
MSM8916, except for some clocks and an additional CSI.

To fix black stripes across sensor output, and garbage in CSID TPG
output, 2 VFE VBIF register settings are needed.  So the 2nd patch adds
helper functions to do just that.

Patch 1: documents qcom,msm8939-camss DT bindings
Patch 2: adds helper for VFE VBIF settings
Patch 3: adds CAMSS_8x39 version in CAMSS driver
Patch 4: adds camss and cci in msm8939.dtsi

Changes compared to [1]:
- Move bindings patch to the beginning
- Make the order of {reg, clock, interrupt} items the same as in 8916 +
  append additional items
- Drop R-b tags from bindings and dts patches as order of items was
  changed

[1] https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/

Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
[André: Apply reviewer comments]
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
Vincent Knecht (4):
      media: dt-bindings: Add qcom,msm8939-camss
      media: qcom: camss: vfe: Add VBIF setting support
      media: qcom: camss: Add support for MSM8939
      arm64: dts: qcom: msm8939: Add camss and cci

 .../bindings/media/qcom,msm8939-camss.yaml         | 254 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       |   4 +
 arch/arm64/boot/dts/qcom/msm8939.dtsi              | 146 ++++++++++++
 drivers/media/platform/qcom/camss/Makefile         |   1 +
 drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
 drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +-
 drivers/media/platform/qcom/camss/camss-vfe-4-1.c  |  12 +
 drivers/media/platform/qcom/camss/camss-vfe-vbif.c |  31 +++
 drivers/media/platform/qcom/camss/camss-vfe-vbif.h |  19 ++
 drivers/media/platform/qcom/camss/camss-vfe.c      |  10 +
 drivers/media/platform/qcom/camss/camss-vfe.h      |   3 +
 drivers/media/platform/qcom/camss/camss.c          | 157 +++++++++++++
 drivers/media/platform/qcom/camss/camss.h          |   1 +
 13 files changed, 645 insertions(+), 2 deletions(-)
---
base-commit: be5d4872e528796df9d7425f2bd9b3893eb3a42c
change-id: 20250517-camss-8x39-vbif-975ff5819198

Best regards,
-- 
André Apitzsch <git@apitzsch.eu>

On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> (This series resumes [1].)
> 
> This series adds CAMSS support for MSM8939.  It's mostly identical to
> MSM8916, except for some clocks and an additional CSI.
> 
> To fix black stripes across sensor output, and garbage in CSID TPG
> output, 2 VFE VBIF register settings are needed.  So the 2nd patch adds
> helper functions to do just that.
> 
> Patch 1: documents qcom,msm8939-camss DT bindings
> Patch 2: adds helper for VFE VBIF settings
> Patch 3: adds CAMSS_8x39 version in CAMSS driver
> Patch 4: adds camss and cci in msm8939.dtsi
> 
> Changes compared to [1]:
> - Move bindings patch to the beginning
> - Make the order of {reg, clock, interrupt} items the same as in 8916 +
>    append additional items
> - Drop R-b tags from bindings and dts patches as order of items was
>    changed
> 
> [1] https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
> 
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> [André: Apply reviewer comments]
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> Vincent Knecht (4):
>        media: dt-bindings: Add qcom,msm8939-camss
>        media: qcom: camss: vfe: Add VBIF setting support
>        media: qcom: camss: Add support for MSM8939
>        arm64: dts: qcom: msm8939: Add camss and cci
> 
>   .../bindings/media/qcom,msm8939-camss.yaml         | 254 +++++++++++++++++++++
>   arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       |   4 +
>   arch/arm64/boot/dts/qcom/msm8939.dtsi              | 146 ++++++++++++
>   drivers/media/platform/qcom/camss/Makefile         |   1 +
>   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
>   drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +-
>   drivers/media/platform/qcom/camss/camss-vfe-4-1.c  |  12 +
>   drivers/media/platform/qcom/camss/camss-vfe-vbif.c |  31 +++
>   drivers/media/platform/qcom/camss/camss-vfe-vbif.h |  19 ++
>   drivers/media/platform/qcom/camss/camss-vfe.c      |  10 +
>   drivers/media/platform/qcom/camss/camss-vfe.h      |   3 +
>   drivers/media/platform/qcom/camss/camss.c          | 157 +++++++++++++
>   drivers/media/platform/qcom/camss/camss.h          |   1 +
>   13 files changed, 645 insertions(+), 2 deletions(-)
> ---
> base-commit: be5d4872e528796df9d7425f2bd9b3893eb3a42c
> change-id: 20250517-camss-8x39-vbif-975ff5819198
> 
> Best regards,

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Hi,

Am Montag, dem 08.09.2025 um 11:56 +0100 schrieb Bryan O'Donoghue:
> On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> > (This series resumes [1].)
> > 
> > This series adds CAMSS support for MSM8939.  It's mostly identical
> > to
> > MSM8916, except for some clocks and an additional CSI.
> > 
> > To fix black stripes across sensor output, and garbage in CSID TPG
> > output, 2 VFE VBIF register settings are needed.  So the 2nd patch
> > adds
> > helper functions to do just that.
> > 
> > Patch 1: documents qcom,msm8939-camss DT bindings
> > Patch 2: adds helper for VFE VBIF settings
> > Patch 3: adds CAMSS_8x39 version in CAMSS driver
> > Patch 4: adds camss and cci in msm8939.dtsi
> > 
> > Changes compared to [1]:
> > - Move bindings patch to the beginning
> > - Make the order of {reg, clock, interrupt} items the same as in
> > 8916 +
> >    append additional items
> > - Drop R-b tags from bindings and dts patches as order of items was
> >    changed
> > 
> > [1]
> > https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
> > 
> > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > [André: Apply reviewer comments]
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> > Vincent Knecht (4):
> >        media: dt-bindings: Add qcom,msm8939-camss
> >        media: qcom: camss: vfe: Add VBIF setting support
> >        media: qcom: camss: Add support for MSM8939
> >        arm64: dts: qcom: msm8939: Add camss and cci
> > 
> >   .../bindings/media/qcom,msm8939-camss.yaml         | 254
> > +++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       |   4 +
> >   arch/arm64/boot/dts/qcom/msm8939.dtsi              | 146
> > ++++++++++++
> >   drivers/media/platform/qcom/camss/Makefile         |   1 +
> >   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
> >   drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +-
> >   drivers/media/platform/qcom/camss/camss-vfe-4-1.c  |  12 +
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.c |  31 +++
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.h |  19 ++
> >   drivers/media/platform/qcom/camss/camss-vfe.c      |  10 +
> >   drivers/media/platform/qcom/camss/camss-vfe.h      |   3 +
> >   drivers/media/platform/qcom/camss/camss.c          | 157
> > +++++++++++++
> >   drivers/media/platform/qcom/camss/camss.h          |   1 +
> >   13 files changed, 645 insertions(+), 2 deletions(-)
> > ---
> > base-commit: be5d4872e528796df9d7425f2bd9b3893eb3a42c
> > change-id: 20250517-camss-8x39-vbif-975ff5819198
> > 
> > Best regards,
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

any chance, this series can be applied for the next merge window?

Best regards,
André

On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> (This series resumes [1].)

Thank you for following up on this.

Could you give a brief synopsis what changed between this series and the 
previous series ?

> [1] https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
Good series submission style would have something in the coverletter like.

"Here is my awesome series of patches which do X

v2:
- Fixed everything wise and benevolent kernel community asked for

v1:
- Enabled cool stuff
"

I recall we were pretty close to picking these patches up previously so 
thank you for re-upping your effort.

A brief bit of guidance on what if anything changed from your last 
submission is appreciated and good practice so that we can review and 
apply quicker.

---
bod

Hi Bryan,

Am Montag, dem 08.09.2025 um 05:51 +0100 schrieb Bryan O'Donoghue:
> On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> > (This series resumes [1].)
> 
> Thank you for following up on this.
> 
> Could you give a brief synopsis what changed between this series and
> the previous series ?

As Vincent seems currently quite busy I took over the series. Because
of that I assumed I had to reset the revision number.

At the end of the cover letter you can find what changed since the
previous submission (v5 by Vincent), but I will add it here again in
more details.

- Patch 1 (bindings) (previously patch 3):
  - Make the order of {reg, clock, interrupt} items the same as in 8916
    + append additional items
  - update isp node unit address
  - Drop R-b tag
- Patch 2 (previously patch 1): no change
- Patch 3 (previously patch 2): no change
- Patch 4 (dts):
  - Make the order of {reg, clock, interrupt} items the same as in 8916
    + append additional items
  - update isp node unit address
  - Drop R-b tag

Best regards,
André

> 
> > [1]
> > https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
> Good series submission style would have something in the coverletter
> like.
> 
> "Here is my awesome series of patches which do X
> 
> v2:
> - Fixed everything wise and benevolent kernel community asked for
> 
> v1:
> - Enabled cool stuff
> "
> 
> I recall we were pretty close to picking these patches up previously
> so thank you for re-upping your effort.
> 
> A brief bit of guidance on what if anything changed from your last 
> submission is appreciated and good practice so that we can review and
> apply quicker.
> 
> ---
> bod