Hi,

The goal of this series is to begin the destaging and upstreaming
process for various Raspberry Pi peripherals that currently interact
with the firmware using the VCHIQ interface present in the staging tree.

While destaging the interface to drivers/platform/raspberrypi, also move
the VCHIQ memory abstraction layer (MMAL) driver. Secondly, drop the
bcm2835-camera driver, as the bcm2835-unicam driver using V4L2 framework
is the recommended way to capture from CSI sensors on this platform.

The bcm2835-audio driver is left as-is in the staging tree, as I am not
an expert on ALSA. Volunteers are welcome :)

In (a) subsequent series, I will upstream the following components that
use VCHIQ interface:
- vc-sm-cma driver
- bcm2835-isp driver

Thanks,
	Jai

Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v2:
- Destage to drivers/platform/raspberrypi instead
- Move BCM_VIDECORE menuconfig definition to the new directory's Kconfig
  along with BCM2835_VCHIQ and VCHIQ_CDEV
- Link to v1: https://lore.kernel.org/r/20250827-vchiq-destage-v1-0-5052a0d81c42@ideasonboard.com

---
Jai Luthra (4):
      staging: vc04_services: Cleanup VCHIQ TODO entries
      platform/broadcom: Destage VCHIQ interface
      media: staging: Drop bcm2835-camera driver
      platform/broadcom: Destage VCHIQ MMAL driver

Umang Jain (1):
      include: linux: Destage VCHIQ interface headers

 MAINTAINERS                                        |    2 +
 drivers/platform/Kconfig                           |    2 +
 drivers/platform/Makefile                          |    1 +
 drivers/platform/raspberrypi/Kconfig               |   52 +
 drivers/platform/raspberrypi/Makefile              |   15 +
 .../raspberrypi/vchiq-interface}/TESTING           |    0
 drivers/platform/raspberrypi/vchiq-interface/TODO  |    4 +
 .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-
 .../raspberrypi/vchiq-interface}/vchiq_bus.c       |    4 +-
 .../raspberrypi/vchiq-interface}/vchiq_core.c      |    4 +-
 .../raspberrypi/vchiq-interface}/vchiq_debugfs.c   |    6 +-
 .../raspberrypi/vchiq-interface}/vchiq_dev.c       |    7 +-
 .../raspberrypi/vchiq-interface}/vchiq_ioctl.h     |    3 +-
 .../raspberrypi}/vchiq-mmal/Kconfig                |    0
 .../raspberrypi}/vchiq-mmal/Makefile               |    0
 .../raspberrypi}/vchiq-mmal/mmal-common.h          |    0
 .../raspberrypi}/vchiq-mmal/mmal-encodings.h       |    0
 .../raspberrypi}/vchiq-mmal/mmal-msg-common.h      |    0
 .../raspberrypi}/vchiq-mmal/mmal-msg-format.h      |    0
 .../raspberrypi}/vchiq-mmal/mmal-msg-port.h        |    0
 .../raspberrypi}/vchiq-mmal/mmal-msg.h             |    0
 .../raspberrypi}/vchiq-mmal/mmal-parameters.h      |    0
 .../raspberrypi}/vchiq-mmal/mmal-vchiq.c           |    5 +-
 .../raspberrypi}/vchiq-mmal/mmal-vchiq.h           |    0
 drivers/staging/vc04_services/Kconfig              |   49 -
 drivers/staging/vc04_services/Makefile             |   14 -
 .../vc04_services/bcm2835-audio/bcm2835-vchiq.c    |    5 +-
 .../staging/vc04_services/bcm2835-audio/bcm2835.c  |    3 +-
 .../staging/vc04_services/bcm2835-audio/bcm2835.h  |    3 +-
 .../staging/vc04_services/bcm2835-camera/Kconfig   |   13 -
 .../staging/vc04_services/bcm2835-camera/Makefile  |    6 -
 drivers/staging/vc04_services/bcm2835-camera/TODO  |   17 -
 .../vc04_services/bcm2835-camera/bcm2835-camera.c  | 2011 --------------------
 .../vc04_services/bcm2835-camera/bcm2835-camera.h  |  142 --
 .../vc04_services/bcm2835-camera/controls.c        | 1399 --------------
 drivers/staging/vc04_services/interface/TODO       |   28 -
 .../include => include}/linux/raspberrypi/vchiq.h  |    0
 .../linux/raspberrypi}/vchiq_arm.h                 |    0
 .../linux/raspberrypi}/vchiq_bus.h                 |    0
 .../linux/raspberrypi}/vchiq_cfg.h                 |    0
 .../linux/raspberrypi}/vchiq_core.h                |    2 +-
 .../linux/raspberrypi}/vchiq_debugfs.h             |    0
 42 files changed, 103 insertions(+), 3703 deletions(-)
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250827-vchiq-destage-39de1e67557d

Best regards,
-- 
Jai Luthra <jai.luthra@ideasonboard.com>

It's really hard to review the code when it's just sigle line like
this:

>  .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-

It's also a head ache to do a cat -n filename and then copy and paste
it into an email message...  I thought there was a trick to make the
diff show up in the email?

regards,
dan carpenter

Hi Dan,

Quoting Dan Carpenter (2025-09-08 11:18:25)
> It's really hard to review the code when it's just sigle line like
> this:
> 
> >  .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-
> 
> It's also a head ache to do a cat -n filename and then copy and paste
> it into an email message...  I thought there was a trick to make the
> diff show up in the email?
> 

I am not sure how to configure b4 to give the full file path instead of
shortening it after the first file in a list.

Does git-format-patch already have some option? I can use that to ease
reviews till b4 adds support for this feature.

Or did I misunderstand your problem?

> regards,
> dan carpenter
>

Thanks,
    Jai

On Mon, Sep 08, 2025 at 04:45:46PM +0530, Jai Luthra wrote:
> Quoting Dan Carpenter (2025-09-08 11:18:25)
> > It's really hard to review the code when it's just sigle line like
> > this:
> > 
> > >  .../raspberrypi/vchiq-interface}/vchiq_arm.c       |    9 +-
> > 
> > It's also a head ache to do a cat -n filename and then copy and paste
> > it into an email message...  I thought there was a trick to make the
> > diff show up in the email?
> > 
> 
> I am not sure how to configure b4 to give the full file path instead of
> shortening it after the first file in a list.
> 
> Does git-format-patch already have some option? I can use that to ease
> reviews till b4 adds support for this feature.

--stat=-1 should help. I don't know if -1 happens to work or is the
official way to remove the limit. --stat=65535 should be big enough too
:-)

> Or did I misunderstand your problem?

-- 
Regards,

Laurent Pinchart