[PATCH 2/3] hwmon: (sht21) Add devicetree support

Kurt Borja posted 3 patches 1 day, 18 hours ago
There is a newer version of this series
[PATCH 2/3] hwmon: (sht21) Add devicetree support
Posted by Kurt Borja 1 day, 18 hours ago
Add DT support for sht2x chips.

Cc: stable@vger.kernel.org
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/hwmon/sht21.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/sht21.c b/drivers/hwmon/sht21.c
index a2748659edc262dac9d87771f849a4fc0a29d981..9813e04f60430f8e60f614d9c68785428978c4a4 100644
--- a/drivers/hwmon/sht21.c
+++ b/drivers/hwmon/sht21.c
@@ -283,8 +283,16 @@ static const struct i2c_device_id sht21_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, sht21_id);
 
+static const struct of_device_id sht21_of_match[] = {
+	{ .compatible = "sensirion,sht2x" },
+	{ }
+};
+
 static struct i2c_driver sht21_driver = {
-	.driver.name = "sht21",
+	.driver = {
+		.name = "sht21",
+		.of_match_table = sht21_of_match,
+	},
 	.probe       = sht21_probe,
 	.id_table    = sht21_id,
 };

-- 
2.51.0
Re: [PATCH 2/3] hwmon: (sht21) Add devicetree support
Posted by Guenter Roeck 1 day, 18 hours ago
On 9/7/25 15:06, Kurt Borja wrote:
> Add DT support for sht2x chips.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>   drivers/hwmon/sht21.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/sht21.c b/drivers/hwmon/sht21.c
> index a2748659edc262dac9d87771f849a4fc0a29d981..9813e04f60430f8e60f614d9c68785428978c4a4 100644
> --- a/drivers/hwmon/sht21.c
> +++ b/drivers/hwmon/sht21.c
> @@ -283,8 +283,16 @@ static const struct i2c_device_id sht21_id[] = {
>   };
>   MODULE_DEVICE_TABLE(i2c, sht21_id);
>   
> +static const struct of_device_id sht21_of_match[] = {
> +	{ .compatible = "sensirion,sht2x" },

This should be individual entries, not a placeholder for multiple chips.

> +	{ }
> +};
> +
>   static struct i2c_driver sht21_driver = {
> -	.driver.name = "sht21",
> +	.driver = {
> +		.name = "sht21",
> +		.of_match_table = sht21_of_match,
> +	},
>   	.probe       = sht21_probe,
>   	.id_table    = sht21_id,
>   };
>
Re: [PATCH 2/3] hwmon: (sht21) Add devicetree support
Posted by Kurt Borja 1 day, 17 hours ago
On Sun Sep 7, 2025 at 5:19 PM -05, Guenter Roeck wrote:
> On 9/7/25 15:06, Kurt Borja wrote:
>> Add DT support for sht2x chips.
>> 
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>>   drivers/hwmon/sht21.c | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/hwmon/sht21.c b/drivers/hwmon/sht21.c
>> index a2748659edc262dac9d87771f849a4fc0a29d981..9813e04f60430f8e60f614d9c68785428978c4a4 100644
>> --- a/drivers/hwmon/sht21.c
>> +++ b/drivers/hwmon/sht21.c
>> @@ -283,8 +283,16 @@ static const struct i2c_device_id sht21_id[] = {
>>   };
>>   MODULE_DEVICE_TABLE(i2c, sht21_id);
>>   
>> +static const struct of_device_id sht21_of_match[] = {
>> +	{ .compatible = "sensirion,sht2x" },
>
> This should be individual entries, not a placeholder for multiple chips.

Sure! I'll add an entry for each chip.

FWIW sensirion also uses sht2x as a placeholder in datasheets.

Thanks for your review!

>
>> +	{ }
>> +};
>> +
>>   static struct i2c_driver sht21_driver = {
>> -	.driver.name = "sht21",
>> +	.driver = {
>> +		.name = "sht21",
>> +		.of_match_table = sht21_of_match,
>> +	},
>>   	.probe       = sht21_probe,
>>   	.id_table    = sht21_id,
>>   };
>> 


-- 
 ~ Kurt