[v6] iio: magnetometer: add support for Infineon TLV493D 3D Magnetic Sensor

[PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

Posted by Dixit Parmar 2 days, 21 hours ago

Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
controlled by I2C interface. Main applications includes joysticks, control
elements (white goods, multifunction knops), or electric meters (anti-
tampering).
Drop duplicate entry for infineon,tlv493d from trivial-devices.yaml as
its documented in this separate dt-binding file now.

Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
---
 .../iio/magnetometer/infineon,tlv493d-a1b6.yaml    | 45 ++++++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml       |  2 -
 MAINTAINERS                                        |  7 ++++
 3 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
new file mode 100644
index 000000000000..dd23a9370a71
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d-a1b6.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
+
+maintainers:
+  - Dixit Parmar <dixitparmar19@gmail.com>
+
+properties:
+  $nodename:
+    pattern: '^magnetometer@[0-9a-f]+$'
+
+  compatible:
+    const: infineon,tlv493d-a1b6
+
+  reg:
+    maxItems: 1
+
+  vdd-supply:
+    description: 2.8V to 3.5V VDD supply
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      magnetometer@5e {
+        compatible = "infineon,tlv493d-a1b6";
+        reg = <0x5e>;
+        vdd-supply = <&hall_vcc>;
+      };
+    };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 27930708ccd5..9e0eb5c873d2 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -125,8 +125,6 @@ properties:
           - infineon,ir36021
             # Infineon IRPS5401 Voltage Regulator (PMIC)
           - infineon,irps5401
-            # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
-          - infineon,tlv493d-a1b6
             # Infineon Hot-swap controller xdp710
           - infineon,xdp710
             # Infineon Multi-phase Digital VR Controller xdpe11280
diff --git a/MAINTAINERS b/MAINTAINERS
index fad6cb025a19..35990c2701f6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11843,6 +11843,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/sound/infineon,peb2466.yaml
 F:	sound/soc/codecs/peb2466.c
 
+INFINEON TLV493D Driver
+M:	Dixit Parmar <dixitparmar19@gmail.com>
+L:	linux-iio@vger.kernel.org
+S:	Maintained
+W:	https://www.infineon.com/part/TLV493D-A1B6
+F:	Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
+
 INFINIBAND SUBSYSTEM
 M:	Jason Gunthorpe <jgg@nvidia.com>
 M:	Leon Romanovsky <leonro@nvidia.com>

-- 
2.43.0

Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

Posted by Krzysztof Kozlowski 22 hours ago

On Sat, Sep 06, 2025 at 02:07:56PM +0530, Dixit Parmar wrote:
> Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
> controlled by I2C interface. Main applications includes joysticks, control
> elements (white goods, multifunction knops), or electric meters (anti-
> tampering).
> Drop duplicate entry for infineon,tlv493d from trivial-devices.yaml as
> its documented in this separate dt-binding file now.
> 
> Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

Posted by Jonathan Cameron 1 day, 20 hours ago

On Sat, 06 Sep 2025 14:07:56 +0530
Dixit Parmar <dixitparmar19@gmail.com> wrote:

> Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
> controlled by I2C interface. Main applications includes joysticks, control
> elements (white goods, multifunction knops), or electric meters (anti-
> tampering).
> Drop duplicate entry for infineon,tlv493d from trivial-devices.yaml as
> its documented in this separate dt-binding file now.
> 
> Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>

Krzysztof gave an RB on version 3.  Please make sure to pick up such tags.

This time I'll apply it by hand if nothing else comes up.

Jonathan

> ---
>  .../iio/magnetometer/infineon,tlv493d-a1b6.yaml    | 45 ++++++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml       |  2 -
>  MAINTAINERS                                        |  7 ++++
>  3 files changed, 52 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> new file mode 100644
> index 000000000000..dd23a9370a71
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d-a1b6.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> +
> +maintainers:
> +  - Dixit Parmar <dixitparmar19@gmail.com>
> +
> +properties:
> +  $nodename:
> +    pattern: '^magnetometer@[0-9a-f]+$'
> +
> +  compatible:
> +    const: infineon,tlv493d-a1b6
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: 2.8V to 3.5V VDD supply
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      magnetometer@5e {
> +        compatible = "infineon,tlv493d-a1b6";
> +        reg = <0x5e>;
> +        vdd-supply = <&hall_vcc>;
> +      };
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 27930708ccd5..9e0eb5c873d2 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -125,8 +125,6 @@ properties:
>            - infineon,ir36021
>              # Infineon IRPS5401 Voltage Regulator (PMIC)
>            - infineon,irps5401
> -            # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
> -          - infineon,tlv493d-a1b6
>              # Infineon Hot-swap controller xdp710
>            - infineon,xdp710
>              # Infineon Multi-phase Digital VR Controller xdpe11280
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fad6cb025a19..35990c2701f6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11843,6 +11843,13 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/sound/infineon,peb2466.yaml
>  F:	sound/soc/codecs/peb2466.c
>  
> +INFINEON TLV493D Driver
> +M:	Dixit Parmar <dixitparmar19@gmail.com>
> +L:	linux-iio@vger.kernel.org
> +S:	Maintained
> +W:	https://www.infineon.com/part/TLV493D-A1B6
> +F:	Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> +
>  INFINIBAND SUBSYSTEM
>  M:	Jason Gunthorpe <jgg@nvidia.com>
>  M:	Leon Romanovsky <leonro@nvidia.com>
>

Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

Posted by Dixit Parmar 1 day, 18 hours ago

> Krzysztof gave an RB on version 3.  Please make sure to pick up such tags.
>
Indeed, RB was given by Krzystof on the V3 patch but this patch got
modified for MAINTAINERS file changes which were not part of V3.
Considering that I thought it should be removed. I have added this in
the cover letter change logs as well. Is this correct understanding?
> This time I'll apply it by hand if nothing else comes up.
Thanks,
Dixit

Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

Posted by Jonathan Cameron 1 day, 18 hours ago

On Sun, 7 Sep 2025 16:43:34 +0530
Dixit Parmar <dixitparmar19@gmail.com> wrote:

> > Krzysztof gave an RB on version 3.  Please make sure to pick up such tags.
> >  
> Indeed, RB was given by Krzystof on the V3 patch but this patch got
> modified for MAINTAINERS file changes which were not part of V3.
> Considering that I thought it should be removed. I have added this in
> the cover letter change logs as well. Is this correct understanding?

When making small changes like that, it's a judgement call you need to make
on whether they are likely to affect the intent of the tag.

To me that one wasn't something that Krzystof was going care about.

Anyhow it's fine that you looked on it differently.  In cases like
this I'd expect to see a comment under the --- in the patch that a tag
was given but dropped because of xyz reasons.

Keep that in future versions until the tag is given again or other
comment invalidates it.

Jonathan

> > This time I'll apply it by hand if nothing else comes up.  
> Thanks,
> Dixit