crypto: caam - double the entropy delay interval for retry

[PATCH] crypto: caam - double the entropy delay interval for retry

Posted by Gaurav Jain 5 months ago

during entropy evaluation, if the generated samples fail
any statistical test, then, all of the bits will be discarded,
and a second set of samples will be generated and tested.

the entropy delay interval should be doubled before performing the
retry.

also, ctrlpriv->rng4_sh_init and inst_handles both reads RNG DRNG
status register, but only inst_handles is updated before every retry.
so only check inst_handles and removing ctrlpriv->rng4_sh_init

Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
---
 drivers/crypto/caam/ctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index a93be395c878..18a850cf0f97 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -703,12 +703,12 @@ static int caam_ctrl_rng_init(struct device *dev)
 			 */
 			if (needs_entropy_delay_adjustment())
 				ent_delay = 12000;
-			if (!(ctrlpriv->rng4_sh_init || inst_handles)) {
+			if (!inst_handles) {
 				dev_info(dev,
 					 "Entropy delay = %u\n",
 					 ent_delay);
 				kick_trng(dev, ent_delay);
-				ent_delay += 400;
+				ent_delay = ent_delay * 2;
 			}
 			/*
 			 * if instantiate_rng(...) fails, the loop will rerun
-- 
2.25.1

Re: [PATCH] crypto: caam - double the entropy delay interval for retry

Posted by Herbert Xu 4 months, 3 weeks ago

On Fri, Sep 05, 2025 at 03:41:48PM +0530, Gaurav Jain wrote:
> during entropy evaluation, if the generated samples fail
> any statistical test, then, all of the bits will be discarded,
> and a second set of samples will be generated and tested.
> 
> the entropy delay interval should be doubled before performing the
> retry.
> 
> also, ctrlpriv->rng4_sh_init and inst_handles both reads RNG DRNG
> status register, but only inst_handles is updated before every retry.
> so only check inst_handles and removing ctrlpriv->rng4_sh_init
> 
> Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> ---
>  drivers/crypto/caam/ctrl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt