From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi All,

This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
these SoCs.

v1->v2:
- Dropped regx in title and description in patch 1/9.
- As done for other IPs used T2H compatible as a fallback for N2H.
- Renamed pcs-rzt2h-miic.h -> renesas,r9a09g077-pcs-miic.h
- Added matrix table in the new header file.
- Corrected the resets check for RZ/N1.
- Updated the commit message in patch 1/9.
- Dropped regx in config description in patch 9/9.
- Dropped patch "net: pcs: rzn1-miic: Add PCS validate callback
  for RZ/T2H MIIC" is this already taken care in commit 508df2de7b3e
  as pointed by Russell King.

Cheers,
Prabhakar

Lad Prabhakar (9):
  dt-bindings: net: pcs: renesas,rzn1-miic: Add RZ/T2H and RZ/N2H
    support
  net: pcs: rzn1-miic: Drop trailing comma from of_device_id table
  net: pcs: rzn1-miic: Add missing include files
  net: pcs: rzn1-miic: Move configuration data to SoC-specific struct
  net: pcs: rzn1-miic: move port range handling into SoC data
  net: pcs: rzn1-miic: Make switch mode mask SoC-specific
  net: pcs: rzn1-miic: Add support to handle resets
  net: pcs: rzn1-miic: Add per-SoC control for MIIC register unlock/lock
  net: pcs: rzn1-miic: Add RZ/T2H MIIC support

 .../bindings/net/pcs/renesas,rzn1-miic.yaml   | 177 ++++++++---
 drivers/net/pcs/Kconfig                       |  11 +-
 drivers/net/pcs/pcs-rzn1-miic.c               | 296 +++++++++++++++---
 .../net/renesas,r9a09g077-pcs-miic.h          |  36 +++
 4 files changed, 419 insertions(+), 101 deletions(-)
 create mode 100644 include/dt-bindings/net/renesas,r9a09g077-pcs-miic.h

-- 
2.51.0

> This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
> These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
> or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
> MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
> these SoCs.
> 
> v1->v2:
> - Dropped regx in title and description in patch 1/9.
> - As done for other IPs used T2H compatible as a fallback for N2H.
> - Renamed pcs-rzt2h-miic.h -> renesas,r9a09g077-pcs-miic.h
> - Added matrix table in the new header file.
> - Corrected the resets check for RZ/N1.
> - Updated the commit message in patch 1/9.
> - Dropped regx in config description in patch 9/9.
> - Dropped patch "net: pcs: rzn1-miic: Add PCS validate callback
>   for RZ/T2H MIIC" is this already taken care in commit 508df2de7b3e
>   as pointed by Russell King.

I plan to test this series on RZ/N1D next week, hopefully on Monday.

On Sat, Sep 06, 2025 at 02:19:37PM +0200, Wolfram Sang wrote:
> 
> > This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
> > These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
> > or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
> > MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
> > these SoCs.
> > 
> > v1->v2:
> > - Dropped regx in title and description in patch 1/9.
> > - As done for other IPs used T2H compatible as a fallback for N2H.
> > - Renamed pcs-rzt2h-miic.h -> renesas,r9a09g077-pcs-miic.h
> > - Added matrix table in the new header file.
> > - Corrected the resets check for RZ/N1.
> > - Updated the commit message in patch 1/9.
> > - Dropped regx in config description in patch 9/9.
> > - Dropped patch "net: pcs: rzn1-miic: Add PCS validate callback
> >   for RZ/T2H MIIC" is this already taken care in commit 508df2de7b3e
> >   as pointed by Russell King.
> 
> I plan to test this series on RZ/N1D next week, hopefully on Monday.

No regressions found when using the 5 ethernet ports on the RZ/N1D
board. For this series:

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Wed, Sep 10, 2025 at 11:18 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> On Sat, Sep 06, 2025 at 02:19:37PM +0200, Wolfram Sang wrote:
> >
> > > This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
> > > These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
> > > or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
> > > MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
> > > these SoCs.
> > >
> > > v1->v2:
> > > - Dropped regx in title and description in patch 1/9.
> > > - As done for other IPs used T2H compatible as a fallback for N2H.
> > > - Renamed pcs-rzt2h-miic.h -> renesas,r9a09g077-pcs-miic.h
> > > - Added matrix table in the new header file.
> > > - Corrected the resets check for RZ/N1.
> > > - Updated the commit message in patch 1/9.
> > > - Dropped regx in config description in patch 9/9.
> > > - Dropped patch "net: pcs: rzn1-miic: Add PCS validate callback
> > >   for RZ/T2H MIIC" is this already taken care in commit 508df2de7b3e
> > >   as pointed by Russell King.
> >
> > I plan to test this series on RZ/N1D next week, hopefully on Monday.
>
> No regressions found when using the 5 ethernet ports on the RZ/N1D
> board. For this series:
>
Thank you for testing this on RZ/N1, I'll send a v3 with some minor
comments fixed.

> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>

Cheers,
Prabhakar

On Thu, Sep 04, 2025 at 12:41:54PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Hi All,
> 
> This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
> These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
> or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
> MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
> these SoCs.

Hi Lad,

This patch-set depends with the following commit, which is present in
net but not yet in net-next.

commit a7195a3d67da ("net: pcs: rzn1-miic: Correct MODCTRL register offset")

Please repost (and if necessary, rebase) once it is present in net-next so
that the CI runs.

And please ensure that 24h elapses between postings to allow for review.

Thanks!

-- 
pw-bot: changes-requested

Hi Simon,

On Thu, Sep 4, 2025 at 1:41 PM Simon Horman <horms@kernel.org> wrote:
>
> On Thu, Sep 04, 2025 at 12:41:54PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Hi All,
> >
> > This series aims to add PCS support for the Renesas RZ/T2H and RZ/N2H SoCs
> > These SoCs include a MII converter (MIIC) that converts MII to RMII/RGMII
> > or can be set in pass-through mode for MII similar to the RZ/N1 SoC. The
> > MIIC is used in conjunction with the Ethernet switch (ETHSW) available on
> > these SoCs.
>
> Hi Lad,
>
> This patch-set depends with the following commit, which is present in
> net but not yet in net-next.
>
> commit a7195a3d67da ("net: pcs: rzn1-miic: Correct MODCTRL register offset")
>
Sorry, I missed to mention the dependency for net-next.

> Please repost (and if necessary, rebase) once it is present in net-next so
> that the CI runs.
>
Ok, I'll repost once the patch lands in net-next.

> And please ensure that 24h elapses between postings to allow for review.
>
Sure, I'll make a note of it.

Cheers,
Prabhakar