drivers: crypto: caam: Add CRYPTO_ALG_NO_FALLBACK

[PATCH] drivers: crypto: caam: Add CRYPTO_ALG_NO_FALLBACK

Posted by meenakshi.aggarwal@nxp.com 5 months, 1 week ago

From: Meenakshi Aggarwal <nxa07556@lsv05950.swis.nl-cdc01.nxp.com>

Add CRYPTO_ALG_NO_FALLBACK cra_flag for hash algorithms.

Fixes: 4ccd065a69df ("crypto: ahash - Add support for drivers with no fallback")

Signed-off-by: Meenakshi Aggarwal <nxa07556@lsv05950.swis.nl-cdc01.nxp.com>
---
 drivers/crypto/caam/caamhash.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c
index 25c02e267258..90aecefdce01 100644
--- a/drivers/crypto/caam/caamhash.c
+++ b/drivers/crypto/caam/caamhash.c
@@ -1933,7 +1933,8 @@ caam_hash_alloc(struct caam_hash_template *template,
 	alg->cra_priority = CAAM_CRA_PRIORITY;
 	alg->cra_blocksize = template->blocksize;
 	alg->cra_alignmask = 0;
-	alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY;
+	alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY |
+			 CRYPTO_ALG_NO_FALLBACK;
 
 	t_alg->alg_type = template->alg_type;
 	t_alg->ahash_alg.op.do_one_request = ahash_do_one_req;
-- 
2.34.1

Re: [PATCH] drivers: crypto: caam: Add CRYPTO_ALG_NO_FALLBACK

Posted by Herbert Xu 4 months, 4 weeks ago

On Thu, Sep 04, 2025 at 01:26:15PM +0200, meenakshi.aggarwal@nxp.com wrote:
> From: Meenakshi Aggarwal <nxa07556@lsv05950.swis.nl-cdc01.nxp.com>
> 
> Add CRYPTO_ALG_NO_FALLBACK cra_flag for hash algorithms.
> 
> Fixes: 4ccd065a69df ("crypto: ahash - Add support for drivers with no fallback")
> 
> Signed-off-by: Meenakshi Aggarwal <nxa07556@lsv05950.swis.nl-cdc01.nxp.com>
> ---
>  drivers/crypto/caam/caamhash.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c
> index 25c02e267258..90aecefdce01 100644
> --- a/drivers/crypto/caam/caamhash.c
> +++ b/drivers/crypto/caam/caamhash.c
> @@ -1933,7 +1933,8 @@ caam_hash_alloc(struct caam_hash_template *template,
>  	alg->cra_priority = CAAM_CRA_PRIORITY;
>  	alg->cra_blocksize = template->blocksize;
>  	alg->cra_alignmask = 0;
> -	alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY;
> +	alg->cra_flags = CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY |
> +			 CRYPTO_ALG_NO_FALLBACK;

All hardware drivers are meant to have fallbacks.  The only exception
would be phmac where the key is inaccessible to the software fallback.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt