[PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining

Bibo Mao posted 2 patches 4 weeks ago
There is a newer version of this series
[PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining
Posted by Bibo Mao 4 weeks ago
The clockevents core already detached and unregistered it at this stage.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 arch/loongarch/kernel/time.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/loongarch/kernel/time.c b/arch/loongarch/kernel/time.c
index f3092f2de8b5..6fb92cc1a4c9 100644
--- a/arch/loongarch/kernel/time.c
+++ b/arch/loongarch/kernel/time.c
@@ -112,8 +112,6 @@ static int arch_timer_starting(unsigned int cpu)
 
 static int arch_timer_dying(unsigned int cpu)
 {
-	constant_set_state_shutdown(this_cpu_ptr(&constant_clockevent_device));
-
 	/* Clear Timer Interrupt */
 	write_csr_tintclear(CSR_TINTCLR_TI);
 
-- 
2.39.3
Re: [PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining
Posted by Frederic Weisbecker 4 weeks ago
Le Thu, Sep 04, 2025 at 03:17:32PM +0800, Bibo Mao a écrit :
> The clockevents core already detached and unregistered it at this stage.
> 
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

-- 
Frederic Weisbecker
SUSE Labs
Re: [PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining
Posted by Huacai Chen 4 weeks ago
On Thu, Sep 4, 2025 at 10:10 PM Frederic Weisbecker <frederic@kernel.org> wrote:
>
> Le Thu, Sep 04, 2025 at 03:17:32PM +0800, Bibo Mao a écrit :
> > The clockevents core already detached and unregistered it at this stage.
> >
> > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
If I'm right, I should pick this patch after the first one be merged?

Huacai

>
> --
> Frederic Weisbecker
> SUSE Labs
>
Re: [PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining
Posted by Frederic Weisbecker 4 weeks ago
Le Thu, Sep 04, 2025 at 10:28:28PM +0800, Huacai Chen a écrit :
> On Thu, Sep 4, 2025 at 10:10 PM Frederic Weisbecker <frederic@kernel.org> wrote:
> >
> > Le Thu, Sep 04, 2025 at 03:17:32PM +0800, Bibo Mao a écrit :
> > > The clockevents core already detached and unregistered it at this stage.
> > >
> > > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> >
> > Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
> If I'm right, I should pick this patch after the first one be merged?

Exactly!

Thanks.

> Huacai
> 
> >
> > --
> > Frederic Weisbecker
> > SUSE Labs
> >

-- 
Frederic Weisbecker
SUSE Labs