[PATCH v0 1/6] x86/hyperv: Rename guest shutdown functions

Mukesh Rathor posted 6 patches 4 weeks, 1 day ago
There is a newer version of this series
[PATCH v0 1/6] x86/hyperv: Rename guest shutdown functions
Posted by Mukesh Rathor 4 weeks, 1 day ago
This commit renames hv_machine_crash_shutdown to more appropriate
hv_guest_crash_shutdown and makes it applicable to guests only. This
in preparation for the subsequent hypervisor root/dom0 crash support
patches.

Signed-off-by: Mukesh Rathor <mrathor@linux.microsoft.com>
---
 arch/x86/kernel/cpu/mshyperv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index b8caf78c4336..f5d76d854d39 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -237,7 +237,7 @@ static void hv_machine_shutdown(void)
 #endif /* CONFIG_KEXEC_CORE */
 
 #ifdef CONFIG_CRASH_DUMP
-static void hv_machine_crash_shutdown(struct pt_regs *regs)
+static void hv_guest_crash_shutdown(struct pt_regs *regs)
 {
 	if (hv_crash_handler)
 		hv_crash_handler(regs);
@@ -824,7 +824,8 @@ static void __init ms_hyperv_init_platform(void)
 	machine_ops.shutdown = hv_machine_shutdown;
 #endif
 #if defined(CONFIG_CRASH_DUMP)
-	machine_ops.crash_shutdown = hv_machine_crash_shutdown;
+	if (!hv_root_partition)
+		machine_ops.crash_shutdown = hv_guest_crash_shutdown;
 #endif
 #endif
 	/*
-- 
2.36.1.vfs.0.0
Re: [PATCH v0 1/6] x86/hyperv: Rename guest shutdown functions
Posted by Anirudh Rayabharam 4 weeks ago
On Wed, Sep 03, 2025 at 07:10:12PM -0700, Mukesh Rathor wrote:
> This commit renames hv_machine_crash_shutdown to more appropriate

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Please describe your changes in imperative mood. For e.g.:

“make xyzzy do frotz” instead of “[This patch] makes xyzzy do frotz”

Please fix this for all the patches in this series.

Thanks,
Anirudh.

> hv_guest_crash_shutdown and makes it applicable to guests only. This
> in preparation for the subsequent hypervisor root/dom0 crash support
> patches.
> 
> Signed-off-by: Mukesh Rathor <mrathor@linux.microsoft.com>
> ---
>  arch/x86/kernel/cpu/mshyperv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index b8caf78c4336..f5d76d854d39 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -237,7 +237,7 @@ static void hv_machine_shutdown(void)
>  #endif /* CONFIG_KEXEC_CORE */
>  
>  #ifdef CONFIG_CRASH_DUMP
> -static void hv_machine_crash_shutdown(struct pt_regs *regs)
> +static void hv_guest_crash_shutdown(struct pt_regs *regs)
>  {
>  	if (hv_crash_handler)
>  		hv_crash_handler(regs);
> @@ -824,7 +824,8 @@ static void __init ms_hyperv_init_platform(void)
>  	machine_ops.shutdown = hv_machine_shutdown;
>  #endif
>  #if defined(CONFIG_CRASH_DUMP)
> -	machine_ops.crash_shutdown = hv_machine_crash_shutdown;
> +	if (!hv_root_partition)
> +		machine_ops.crash_shutdown = hv_guest_crash_shutdown;
>  #endif
>  #endif
>  	/*
> -- 
> 2.36.1.vfs.0.0
>