[PATCH v2] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided

David Heidelberg via B4 Relay posted 1 patch 4 weeks ago
Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH v2] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided
Posted by David Heidelberg via B4 Relay 4 weeks ago
From: David Heidelberg <david@ixit.cz>

Without providing either ID or VBUS GPIO the driver is not able to operate.
Original text binding says:
  "Either one of id-gpio or vbus-gpio must be present."

Fixes: 79a31ce03f41 ("dt-bindings: extcon: convert extcon-usb-gpio.txt to yaml format")
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
- Rebased and added Conor A-b.
- Link to v1: https://lore.kernel.org/r/20250329-yaml-extcon-usb-gpio-v1-1-190696e53a0b@ixit.cz
---
 Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
index 8856107bdd33b8654812ab9c97e85e23dc2ef75a..8f29d333602b95fe5ccd8464aa64e2d1f0c1c781 100644
--- a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
+++ b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
@@ -25,6 +25,12 @@ properties:
 required:
   - compatible
 
+anyOf:
+  - required:
+      - id-gpios
+  - required:
+      - vbus-gpios
+
 additionalProperties: false
 
 examples:

---
base-commit: 4ac65880ebca1b68495bd8704263b26c050ac010
change-id: 20250329-yaml-extcon-usb-gpio-251b66522287

Best regards,
-- 
David Heidelberg <david@ixit.cz>
Re: [PATCH v2] dt-bindings: extcon: linux,extcon-usb-gpio: GPIO must be provided
Posted by Chanwoo Choi 3 weeks, 5 days ago
25. 9. 5. 05:41에 David Heidelberg via B4 Relay 이(가) 쓴 글:
> From: David Heidelberg <david@ixit.cz>
> 
> Without providing either ID or VBUS GPIO the driver is not able to operate.
> Original text binding says:
>   "Either one of id-gpio or vbus-gpio must be present."
> 
> Fixes: 79a31ce03f41 ("dt-bindings: extcon: convert extcon-usb-gpio.txt to yaml format")
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Changes in v2:
> - Rebased and added Conor A-b.
> - Link to v1: https://lore.kernel.org/r/20250329-yaml-extcon-usb-gpio-v1-1-190696e53a0b@ixit.cz
> ---
>  Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> index 8856107bdd33b8654812ab9c97e85e23dc2ef75a..8f29d333602b95fe5ccd8464aa64e2d1f0c1c781 100644
> --- a/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> +++ b/Documentation/devicetree/bindings/extcon/linux,extcon-usb-gpio.yaml
> @@ -25,6 +25,12 @@ properties:
>  required:
>    - compatible
>  
> +anyOf:
> +  - required:
> +      - id-gpios
> +  - required:
> +      - vbus-gpios
> +
>  additionalProperties: false
>  
>  examples:
> 
> ---
> base-commit: 4ac65880ebca1b68495bd8704263b26c050ac010
> change-id: 20250329-yaml-extcon-usb-gpio-251b66522287
> 
> Best regards,

Hi,

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi