[v1] exynos5250-smdk5250: describe SROM controller and ethernet port

[PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map

Posted by Henrik Grimler 4 weeks, 1 day ago

According to public user manual for Exynos 5250 [1], the SROM
controller has 4 banks, at same addresses as for example Exynos
5410. Describe the bank memory map of the SoC.

[1] https://web.archive.org/web/20130921194458/http://www.samsung.com/global/business/semiconductor/file/product/Exynos_5_Dual_User_Manaul_Public_REV100-0.pdf

Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
 arch/arm/boot/dts/samsung/exynos5250.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
index b9e7c493881804647534b1d7395f6eb62a07fb92..741cc693f5d8f6b33772d7819c965c590571f305 100644
--- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
@@ -1214,6 +1214,15 @@ &serial_3 {
 	dma-names = "rx", "tx";
 };
 
+&sromc {
+	#address-cells = <2>;
+	#size-cells = <1>;
+	ranges = <0 0 0x04000000 0x20000
+		  1 0 0x05000000 0x20000
+		  2 0 0x06000000 0x20000
+		  3 0 0x07000000 0x20000>;
+};
+
 &sss {
 	clocks = <&clock CLK_SSS>;
 	clock-names = "secss";

-- 
2.51.0

Re: [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map

Posted by Krzysztof Kozlowski 3 weeks, 5 days ago

On 04/09/2025 08:10, Henrik Grimler wrote:
> According to public user manual for Exynos 5250 [1], the SROM
> controller has 4 banks, at same addresses as for example Exynos
> 5410. Describe the bank memory map of the SoC.
> 
> [1] https://web.archive.org/web/20130921194458/http://www.samsung.com/global/business/semiconductor/file/product/Exynos_5_Dual_User_Manaul_Public_REV100-0.pdf
> 
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
>  arch/arm/boot/dts/samsung/exynos5250.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> index b9e7c493881804647534b1d7395f6eb62a07fb92..741cc693f5d8f6b33772d7819c965c590571f305 100644
> --- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> @@ -1214,6 +1214,15 @@ &serial_3 {
>  	dma-names = "rx", "tx";
>  };
>  
> +&sromc {
> +	#address-cells = <2>;
> +	#size-cells = <1>;
> +	ranges = <0 0 0x04000000 0x20000


These should be separate tupples, so

<0 0 0x04000000 0x20000>,
<....>,
<....>,



Best regards,
Krzysztof

Re: [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map

Posted by Henrik Grimler 3 weeks, 5 days ago

Hi Krzysztof,

On Sat, Sep 06, 2025 at 02:24:21PM +0200, Krzysztof Kozlowski wrote:
> On 04/09/2025 08:10, Henrik Grimler wrote:
> > According to public user manual for Exynos 5250 [1], the SROM
> > controller has 4 banks, at same addresses as for example Exynos
> > 5410. Describe the bank memory map of the SoC.
> > 
> > [1] https://web.archive.org/web/20130921194458/http://www.samsung.com/global/business/semiconductor/file/product/Exynos_5_Dual_User_Manaul_Public_REV100-0.pdf
> > 
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > ---
> >  arch/arm/boot/dts/samsung/exynos5250.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > index b9e7c493881804647534b1d7395f6eb62a07fb92..741cc693f5d8f6b33772d7819c965c590571f305 100644
> > --- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > @@ -1214,6 +1214,15 @@ &serial_3 {
> >  	dma-names = "rx", "tx";
> >  };
> >  
> > +&sromc {
> > +	#address-cells = <2>;
> > +	#size-cells = <1>;
> > +	ranges = <0 0 0x04000000 0x20000
> 
> 
> These should be separate tupples, so
> 
> <0 0 0x04000000 0x20000>,
> <....>,
> <....>,

Thanks, will send a v2 to fix it, and update exynos5410.dtsi, in a day
or two!

> Best regards,
> Krzysztof

Best regards,
Henrik Grimler