Add compatible string for the DisplayPort controller found on the
Qualcomm QCS8300 SoC.
The Qualcomm QCS8300 platform comes with one DisplayPort controller
that supports 4 MST streams.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
.../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,sc7180-dp
- qcom,sc7280-dp
@@ -195,6 +196,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs8300-dp
- qcom,sa8775p-dp
- qcom,x1e80100-dp
then:
@@ -295,6 +297,26 @@ allOf:
minItems: 6
maxItems: 8
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ # QCS8300 only has one DP controller that supports 4
+ # streams MST.
+ - qcom,qcs8300-dp
+ then:
+ properties:
+ reg:
+ minItems: 9
+ maxItems: 9
+ clocks:
+ minItems: 8
+ maxItems: 8
+ clocks-names:
+ minItems: 8
+ maxItems: 8
+
additionalProperties: false
examples:
--
2.34.1On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm QCS8300 SoC. > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > that supports 4 MST streams. > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > --- > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > oneOf: > - enum: > + - qcom,qcs8300-dp Can we use fallback to qcom,sa8775p-dp instead of declaring a completely new one? > - qcom,sa8775p-dp > - qcom,sc7180-dp > - qcom,sc7280-dp > @@ -195,6 +196,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,qcs8300-dp > - qcom,sa8775p-dp > - qcom,x1e80100-dp > then: > @@ -295,6 +297,26 @@ allOf: > minItems: 6 > maxItems: 8 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + # QCS8300 only has one DP controller that supports 4 > + # streams MST. > + - qcom,qcs8300-dp > + then: > + properties: > + reg: > + minItems: 9 > + maxItems: 9 > + clocks: > + minItems: 8 > + maxItems: 8 > + clocks-names: > + minItems: 8 > + maxItems: 8 > + > additionalProperties: false > > examples: > > -- > 2.34.1 > -- With best wishes Dmitry
On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote: > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote: >> Add compatible string for the DisplayPort controller found on the >> Qualcomm QCS8300 SoC. >> >> The Qualcomm QCS8300 platform comes with one DisplayPort controller >> that supports 4 MST streams. >> >> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> >> --- >> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -18,6 +18,7 @@ properties: >> compatible: >> oneOf: >> - enum: >> + - qcom,qcs8300-dp > > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely > new one? > I think we can not use fallback to sa8775p, since we don't have DP1 controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2 really used). So in the hardware, i think it is different with SA8775P and we need a new one.>> - qcom,sa8775p-dp >> - qcom,sc7180-dp >> - qcom,sc7280-dp >> @@ -195,6 +196,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,qcs8300-dp >> - qcom,sa8775p-dp >> - qcom,x1e80100-dp >> then: >> @@ -295,6 +297,26 @@ allOf: >> minItems: 6 >> maxItems: 8 >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + # QCS8300 only has one DP controller that supports 4 >> + # streams MST. >> + - qcom,qcs8300-dp >> + then: >> + properties: >> + reg: >> + minItems: 9 >> + maxItems: 9 >> + clocks: >> + minItems: 8 >> + maxItems: 8 >> + clocks-names: >> + minItems: 8 >> + maxItems: 8 >> + >> additionalProperties: false >> >> examples: >> >> -- >> 2.34.1 >> >
On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote: > > > On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote: > > > Add compatible string for the DisplayPort controller found on the > > > Qualcomm QCS8300 SoC. > > > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > > > that supports 4 MST streams. > > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > > > --- > > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > @@ -18,6 +18,7 @@ properties: > > > compatible: > > > oneOf: > > > - enum: > > > + - qcom,qcs8300-dp > > > > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely > > new one? > > > I think we can not use fallback to sa8775p, since we don't have DP1 > controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2 > really used). So in the hardware, i think it is different with SA8775P and > we need a new one.>> - qcom,sa8775p-dp The DP controller is the same as the one present on SA8775P. > > > - qcom,sc7180-dp > > > - qcom,sc7280-dp -- With best wishes Dmitry
On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
> On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
>>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>>>> Add compatible string for the DisplayPort controller found on the
>>>> Qualcomm QCS8300 SoC.
>>>>
>>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>>>> that supports 4 MST streams.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>>>> 1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>> @@ -18,6 +18,7 @@ properties:
>>>> compatible:
>>>> oneOf:
>>>> - enum:
>>>> + - qcom,qcs8300-dp
>>>
>>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
>>> new one?
>>>
>> I think we can not use fallback to sa8775p, since we don't have DP1
>> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
>> really used). So in the hardware, i think it is different with SA8775P and
>> we need a new one.>> - qcom,sa8775p-dp
>
> The DP controller is the same as the one present on SA8775P.
>
Yes, it is same.. I just want to confirm again—even if we only need DP0
for QCS8300, we can also use sa8775p as fallback, right?
static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
{ .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0,
.wide_bus_supported = true },
{ .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1,
.wide_bus_supported = true },
{ .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2,
.wide_bus_supported = true },
{ .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3,
.wide_bus_supported = true },
{}
};
.mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
Previously, my understanding here was that we might need a new
compatible for QCS8300.
Thanks~~>>>> - qcom,sc7180-dp
>>>> - qcom,sc7280-dp
>
On Mon, Sep 08, 2025 at 05:46:30PM +0800, Yongxing Mou wrote:
>
>
> On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
> > On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
> > >
> > >
> > > On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
> > > > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
> > > > > Add compatible string for the DisplayPort controller found on the
> > > > > Qualcomm QCS8300 SoC.
> > > > >
> > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller
> > > > > that supports 4 MST streams.
> > > > >
> > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > ---
> > > > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
> > > > > 1 file changed, 22 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
> > > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > > > @@ -18,6 +18,7 @@ properties:
> > > > > compatible:
> > > > > oneOf:
> > > > > - enum:
> > > > > + - qcom,qcs8300-dp
> > > >
> > > > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
> > > > new one?
> > > >
> > > I think we can not use fallback to sa8775p, since we don't have DP1
> > > controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
> > > really used). So in the hardware, i think it is different with SA8775P and
> > > we need a new one.>> - qcom,sa8775p-dp
> >
> > The DP controller is the same as the one present on SA8775P.
> >
> Yes, it is same.. I just want to confirm again—even if we only need DP0 for
> QCS8300, we can also use sa8775p as fallback, right?
What makes you think that we can't? Let me repharse the question: which
part of DP controller (single one) on QCS8300 is incompatible with the
DP controller on SA8775P?
>
> static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
> { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported
> = true },
> { .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported
> = true },
> { .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported
> = true },
> { .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3, .wide_bus_supported
> = true },
> {}
> };
> .mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
>
> Previously, my understanding here was that we might need a new compatible
> for QCS8300.
>
> Thanks~~>>>> - qcom,sc7180-dp
> > > > > - qcom,sc7280-dp
> >
>
--
With best wishes
Dmitry
On 9/8/2025 6:04 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 08, 2025 at 05:46:30PM +0800, Yongxing Mou wrote:
>>
>>
>> On 9/5/2025 9:48 PM, Dmitry Baryshkov wrote:
>>> On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote:
>>>>
>>>>
>>>> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote:
>>>>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote:
>>>>>> Add compatible string for the DisplayPort controller found on the
>>>>>> Qualcomm QCS8300 SoC.
>>>>>>
>>>>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller
>>>>>> that supports 4 MST streams.
>>>>>>
>>>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>>>> ---
>>>>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++
>>>>>> 1 file changed, 22 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644
>>>>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>>>>>> @@ -18,6 +18,7 @@ properties:
>>>>>> compatible:
>>>>>> oneOf:
>>>>>> - enum:
>>>>>> + - qcom,qcs8300-dp
>>>>>
>>>>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely
>>>>> new one?
>>>>>
>>>> I think we can not use fallback to sa8775p, since we don't have DP1
>>>> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2
>>>> really used). So in the hardware, i think it is different with SA8775P and
>>>> we need a new one.>> - qcom,sa8775p-dp
>>>
>>> The DP controller is the same as the one present on SA8775P.
>>>
>> Yes, it is same.. I just want to confirm again—even if we only need DP0 for
>> QCS8300, we can also use sa8775p as fallback, right?
>
> What makes you think that we can't? Let me repharse the question: which
> part of DP controller (single one) on QCS8300 is incompatible with the
> DP controller on SA8775P?
>
Sure.. got this point.. will update next version.. for the single one ,
they are same...
Thanks.>>
>> static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
>> { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported
>> = true },
>> { .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported
>> = true },
>> { .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported
>> = true },
>> { .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_3, .wide_bus_supported
>> = true },
>> {}
>> };
>> .mst_streams = 4 is suitable for both QCS8300 and SA8775P DP 0 here.
>>
>> Previously, my understanding here was that we might need a new compatible
>> for QCS8300.
>>
>> Thanks~~>>>> - qcom,sc7180-dp
>>>>>> - qcom,sc7280-dp
>>>
>>
>
On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote: > > > On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote: > > On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote: > > > Add compatible string for the DisplayPort controller found on the > > > Qualcomm QCS8300 SoC. > > > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > > > that supports 4 MST streams. > > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > > > --- > > > .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > @@ -18,6 +18,7 @@ properties: > > > compatible: > > > oneOf: > > > - enum: > > > + - qcom,qcs8300-dp > > > > Can we use fallback to qcom,sa8775p-dp instead of declaring a completely > > new one? > > > I think we can not use fallback to sa8775p, since we don't have DP1 > controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2 > really used). So in the hardware, i think it is different with SA8775P and > we need a new one.>> - qcom,sa8775p-dp I don't understand how this rationale explains what Dmitry asked. Why number of IP blocks (and this is DPx, right?) matter? Are you sure you understand what compatibility means? Please read the slides from OSSE25 or just read writing bindings. Best regards, Krzysztof
On 9/5/2025 4:25 PM, Krzysztof Kozlowski wrote: > On Fri, Sep 05, 2025 at 10:50:33AM +0800, Yongxing Mou wrote: >> >> >> On 9/4/2025 9:43 PM, Dmitry Baryshkov wrote: >>> On Thu, Sep 04, 2025 at 03:22:37PM +0800, Yongxing Mou wrote: >>>> Add compatible string for the DisplayPort controller found on the >>>> Qualcomm QCS8300 SoC. >>>> >>>> The Qualcomm QCS8300 platform comes with one DisplayPort controller >>>> that supports 4 MST streams. >>>> >>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> >>>> --- >>>> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..ad08fd11588c45698f7e63ecc3218a749fc8ca67 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> @@ -18,6 +18,7 @@ properties: >>>> compatible: >>>> oneOf: >>>> - enum: >>>> + - qcom,qcs8300-dp >>> >>> Can we use fallback to qcom,sa8775p-dp instead of declaring a completely >>> new one? >>> >> I think we can not use fallback to sa8775p, since we don't have DP1 >> controller for QCS8300. SA8775P actually have 4 DP controllers (now only 2 >> really used). So in the hardware, i think it is different with SA8775P and >> we need a new one.>> - qcom,sa8775p-dp > > I don't understand how this rationale explains what Dmitry asked. > > Why number of IP blocks (and this is DPx, right?) matter? Are you sure > you understand what compatibility means? Please read the slides from > OSSE25 or just read writing bindings. > > Best regards, > Krzysztof > Sure.. I’ll discuss this further here to make sure I fully understand these comments.
© 2016 - 2025 Red Hat, Inc.