[v2] thermal: hwmon: replace deprecated strcpy() with strscpy()

[PATCH v2] thermal: hwmon: replace deprecated strcpy() with strscpy()

Posted by Osama Abdelkader 4 weeks, 1 day ago

strcpy() is deprecated, use strscpy() instead for consistency with thermal
subsystem since this is the only strcpy there.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
v2:
Improve the commit msg: add that this is the only strcpy left in thermal subsystem
---
 drivers/thermal/thermal_hwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index 0ecccd4d8556..64cc3ab949fe 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
 
 	mutex_lock(&thermal_hwmon_list_lock);
 	list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
-		strcpy(type, tz->type);
+		strscpy(type, tz->type);
 		strreplace(type, '-', '_');
 		if (!strcmp(hwmon->type, type)) {
 			mutex_unlock(&thermal_hwmon_list_lock);
-- 
2.43.0

Re: [PATCH v2] thermal: hwmon: replace deprecated strcpy() with strscpy()

Posted by Lukasz Luba 4 weeks ago


On 9/3/25 20:20, Osama Abdelkader wrote:
> strcpy() is deprecated, use strscpy() instead for consistency with thermal
> subsystem since this is the only strcpy there.
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> v2:
> Improve the commit msg: add that this is the only strcpy left in thermal subsystem
> ---
>   drivers/thermal/thermal_hwmon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index 0ecccd4d8556..64cc3ab949fe 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
>   
>   	mutex_lock(&thermal_hwmon_list_lock);
>   	list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> -		strcpy(type, tz->type);
> +		strscpy(type, tz->type);
>   		strreplace(type, '-', '_');
>   		if (!strcmp(hwmon->type, type)) {
>   			mutex_unlock(&thermal_hwmon_list_lock);


LGTM, that was indeed the single occurrence in thermal sub-system.
Thanks!

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Re: [PATCH v2] thermal: hwmon: replace deprecated strcpy() with strscpy()

Posted by Rafael J. Wysocki 3 weeks, 6 days ago

On Thu, Sep 4, 2025 at 9:45 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
>
>
> On 9/3/25 20:20, Osama Abdelkader wrote:
> > strcpy() is deprecated, use strscpy() instead for consistency with thermal
> > subsystem since this is the only strcpy there.
> >
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > ---
> > v2:
> > Improve the commit msg: add that this is the only strcpy left in thermal subsystem
> > ---
> >   drivers/thermal/thermal_hwmon.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> > index 0ecccd4d8556..64cc3ab949fe 100644
> > --- a/drivers/thermal/thermal_hwmon.c
> > +++ b/drivers/thermal/thermal_hwmon.c
> > @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
> >
> >       mutex_lock(&thermal_hwmon_list_lock);
> >       list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> > -             strcpy(type, tz->type);
> > +             strscpy(type, tz->type);
> >               strreplace(type, '-', '_');
> >               if (!strcmp(hwmon->type, type)) {
> >                       mutex_unlock(&thermal_hwmon_list_lock);
>
>
> LGTM, that was indeed the single occurrence in thermal sub-system.
> Thanks!
>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Applied as 6.18 material, thanks!