On 9/3/25 08:25, Qianfeng Rong wrote:
> Change the 'ret' variable in __sev_do_cmd_locked() from unsigned int to
> int, as it needs to store negative error codes.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Not sure it needs to be initialized either, but not worth changing that
as part of this patch.
> ---
> drivers/crypto/ccp/sev-dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 4f000dc2e639..6c116f6f9b79 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -848,9 +848,10 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret)
> struct sev_device *sev;
> unsigned int cmdbuff_hi, cmdbuff_lo;
> unsigned int phys_lsb, phys_msb;
> - unsigned int reg, ret = 0;
> + unsigned int reg;
> void *cmd_buf;
> int buf_len;
> + int ret = 0;
>
> if (!psp || !psp->sev_data)
> return -ENODEV;