[PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef

Bartosz Golaszewski posted 1 patch 4 weeks, 1 day ago
drivers/gpio/gpio-nomadik.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef
Posted by Bartosz Golaszewski 4 weeks, 1 day ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The 'desc' local variable in nmk_gpio_dbg_show_one() is now only used
with CONFIG_PINCTRL_NOMADIK enabled so wrap its declaration with an
appropriate ifdef.

Fixes: ddeb66d2cb10 ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509032125.nXBcPuaf-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-nomadik.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index fde4b416faa8..97c5cd33279d 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -400,7 +400,9 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev,
 			   struct gpio_chip *chip, unsigned int offset)
 {
 	struct nmk_gpio_chip *nmk_chip = gpiochip_get_data(chip);
+#ifdef CONFIG_PINCTRL_NOMADIK
 	struct gpio_desc *desc;
+#endif
 	int mode;
 	bool is_out;
 	bool data_out;
-- 
2.48.1
Re: [PATCH] gpio: nomadik: wrap a local variable in a necessary ifdef
Posted by Bartosz Golaszewski 4 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 03 Sep 2025 15:19:03 +0200, Bartosz Golaszewski wrote:
> The 'desc' local variable in nmk_gpio_dbg_show_one() is now only used
> with CONFIG_PINCTRL_NOMADIK enabled so wrap its declaration with an
> appropriate ifdef.
> 
> 

Applied, thanks!

[1/1] gpio: nomadik: wrap a local variable in a necessary ifdef
      (no commit info)

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>