pinctrl: spacemit: fix typo in PRI_TDI pin name

[PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name

Posted by Hendrik Hamerlinck 4 weeks, 1 day ago

The datasheet lists this signal as PRI_TDI, not PRI_DTI.
Fix the pin name to match the documentation and JTAG naming
convention (TDI = Test Data In).

Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
---
 drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
index 9996b1c4a07e..a3f433b611f7 100644
--- a/drivers/pinctrl/spacemit/pinctrl-k1.c
+++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
@@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = {
 	PINCTRL_PIN(67, "GPIO_67"),
 	PINCTRL_PIN(68, "GPIO_68"),
 	PINCTRL_PIN(69, "GPIO_69"),
-	PINCTRL_PIN(70, "GPIO_70/PRI_DTI"),
+	PINCTRL_PIN(70, "GPIO_70/PRI_TDI"),
 	PINCTRL_PIN(71, "GPIO_71/PRI_TMS"),
 	PINCTRL_PIN(72, "GPIO_72/PRI_TCK"),
 	PINCTRL_PIN(73, "GPIO_73/PRI_TDO"),
-- 
2.43.0

Re: [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name

Posted by Linus Walleij 4 weeks ago

On Wed, Sep 3, 2025 at 12:01 PM Hendrik Hamerlinck
<hendrik.hamerlinck@hammernet.be> wrote:

> The datasheet lists this signal as PRI_TDI, not PRI_DTI.
> Fix the pin name to match the documentation and JTAG naming
> convention (TDI = Test Data In).
>
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>

Patch applied!

Yours,
Linus Walleij

Re: [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name

Posted by Yixun Lan 4 weeks, 1 day ago

Hi Hendrik,
On 12:01 Wed 03 Sep     , Hendrik Hamerlinck wrote:
> The datasheet lists this signal as PRI_TDI, not PRI_DTI.
> Fix the pin name to match the documentation and JTAG naming
> convention (TDI = Test Data In).
> 
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>

Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
>  drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 9996b1c4a07e..a3f433b611f7 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
> @@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = {
>  	PINCTRL_PIN(67, "GPIO_67"),
>  	PINCTRL_PIN(68, "GPIO_68"),
>  	PINCTRL_PIN(69, "GPIO_69"),
> -	PINCTRL_PIN(70, "GPIO_70/PRI_DTI"),
> +	PINCTRL_PIN(70, "GPIO_70/PRI_TDI"),
>  	PINCTRL_PIN(71, "GPIO_71/PRI_TMS"),
>  	PINCTRL_PIN(72, "GPIO_72/PRI_TCK"),
>  	PINCTRL_PIN(73, "GPIO_73/PRI_TDO"),
> -- 
> 2.43.0
> 

-- 
Yixun Lan (dlan)