[PATCH] slimbus: messaging: Remove redundant code

liuqiangneo@163.com posted 1 patch 4 weeks, 1 day ago
drivers/slimbus/messaging.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] slimbus: messaging: Remove redundant code
Posted by liuqiangneo@163.com 4 weeks, 1 day ago
From: Qiang Liu <liuqiang@kylinos.cn>

Assigning txn->comp to itself has no effect.

Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
---
 drivers/slimbus/messaging.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index 6f01d944f9c6..27ca16f00e77 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -143,8 +143,6 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn)
 
 		if (!txn->msg->comp)
 			txn->comp = &done;
-		else
-			txn->comp = txn->comp;
 	}
 
 	ret = ctrl->xfer_msg(ctrl, txn);
-- 
2.43.0
Re: [PATCH] slimbus: messaging: Remove redundant code
Posted by Srinivas Kandagatla 4 weeks, 1 day ago
On Wed, 03 Sep 2025 15:51:55 +0800, liuqiangneo@163.com wrote:
> Assigning txn->comp to itself has no effect.
> 
> 

Applied, thanks!

[1/1] slimbus: messaging: Remove redundant code
      commit: 9ad5660840925cd6067b22f8e0bd1db87275cf58

Best regards,
-- 
Srinivas Kandagatla <srini@kernel.org>