Document support for the USB20 phy found on the ExynosAutov920 SoC. The
USB20 phy is functionally identical to that on the Exynos850 SoC, so no
driver changes are needed to support this phy. However, add a dedicated
compatible string for USB20 phy found in this SoC.
Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
.../bindings/phy/samsung,usb3-drd-phy.yaml | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
index e906403208c0..8d8114eb5660 100644
--- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
@@ -34,6 +34,7 @@ properties:
- samsung,exynos7870-usbdrd-phy
- samsung,exynos850-usbdrd-phy
- samsung,exynos990-usbdrd-phy
+ - samsung,exynosautov920-usbdrd-phy
clocks:
minItems: 1
@@ -110,6 +111,15 @@ properties:
vddh-usbdp-supply:
description: VDDh power supply for the USB DP phy.
+ dvdd-supply:
+ description: 0.75V power supply for the USB phy.
+
+ vdd18-supply:
+ description: 1.8V power supply for the USB phy.
+
+ vdd33-supply:
+ description: 3.3V power supply for the USB phy.
+
required:
- compatible
- clocks
@@ -219,6 +229,7 @@ allOf:
- samsung,exynos7870-usbdrd-phy
- samsung,exynos850-usbdrd-phy
- samsung,exynos990-usbdrd-phy
+ - samsung,exynosautov920-usbdrd-phy
then:
properties:
clocks:
@@ -236,6 +247,24 @@ allOf:
reg-names:
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynosautov920-usbdrd-phy
+ then:
+ required:
+ - dvdd-supply
+ - vdd18-supply
+ - vdd33-supply
+
+ else:
+ properties:
+ dvdd-supply: false
+ vdd18-supply: false
+ vdd33-supply: false
+
unevaluatedProperties: false
examples:
--
2.34.1Hi Pritam > -----Original Message----- > From: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Sent: Wednesday, September 3, 2025 1:08 PM > To: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; > pritam.sutar@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; rosa.pila@samsung.com; > dev.tailor@samsung.com; faraz.ata@samsung.com; > muhammed.ali@samsung.com; selvarasu.g@samsung.com > Subject: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > Document support for the USB20 phy found on the ExynosAutov920 SoC. > The > USB20 phy is functionally identical to that on the Exynos850 SoC, so no driver > changes are needed to support this phy. However, add a dedicated > compatible string for USB20 phy found in this SoC. > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> -----Original Message----- > From: Alim Akhtar <alim.akhtar@samsung.com> > Sent: 29 September 2025 12:16 PM > To: 'Pritam Manohar Sutar' <pritam.sutar@samsung.com>; vkoul@kernel.org; > kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; andre.draszik@linaro.org; peter.griffin@linaro.org; > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > igor.belwon@mentallysanemainliners.org; m.szyprowski@samsung.com; > s.nawrocki@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > Hi Pritam > > > -----Original Message----- > > From: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > Sent: Wednesday, September 3, 2025 1:08 PM > > To: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > > andre.draszik@linaro.org; peter.griffin@linaro.org; > > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > > igor.belwon@mentallysanemainliners.org; > > m.szyprowski@samsung.com; s.nawrocki@samsung.com; > > pritam.sutar@samsung.com > > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > samsung-soc@vger.kernel.org; rosa.pila@samsung.com; > > dev.tailor@samsung.com; faraz.ata@samsung.com; > > muhammed.ali@samsung.com; selvarasu.g@samsung.com > > Subject: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > > ExynosAutov920 HS phy compatible > > > > Document support for the USB20 phy found on the ExynosAutov920 SoC. > > The > > USB20 phy is functionally identical to that on the Exynos850 SoC, so > > no driver changes are needed to support this phy. However, add a > > dedicated compatible string for USB20 phy found in this SoC. > > > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > --- > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Hi Alim, Thank you for RB tag. Hi Vinod, Addressed comments on phy drivers those were given in patch-set v5. Can you please check and let me know if any other comments? Hi Krzysztof, Please let me know if you want me send v9 by retaining your RB on patch1 and patch3? Also do let me know if any other concerns need to be addressed? Regards, Pritam
On 03/09/2025 16:38, Pritam Manohar Sutar wrote: > diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > index e906403208c0..8d8114eb5660 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > @@ -34,6 +34,7 @@ properties: > - samsung,exynos7870-usbdrd-phy > - samsung,exynos850-usbdrd-phy > - samsung,exynos990-usbdrd-phy > + - samsung,exynosautov920-usbdrd-phy > > clocks: > minItems: 1 > @@ -110,6 +111,15 @@ properties: > vddh-usbdp-supply: > description: VDDh power supply for the USB DP phy. > > + dvdd-supply: > + description: 0.75V power supply for the USB phy. So this is existing dvdd-usb20-supply. Same for all of the rest. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 18 September 2025 08:15 AM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org; > kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 03/09/2025 16:38, Pritam Manohar Sutar wrote: > > diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd- > phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd- > phy.yaml > > index e906403208c0..8d8114eb5660 100644 > > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > > @@ -34,6 +34,7 @@ properties: > > - samsung,exynos7870-usbdrd-phy > > - samsung,exynos850-usbdrd-phy > > - samsung,exynos990-usbdrd-phy > > + - samsung,exynosautov920-usbdrd-phy > > > > clocks: > > minItems: 1 > > @@ -110,6 +111,15 @@ properties: > > vddh-usbdp-supply: > > description: VDDh power supply for the USB DP phy. > > > > + dvdd-supply: > > + description: 0.75V power supply for the USB phy. > > So this is existing dvdd-usb20-supply. > > Same for all of the rest. > Yes, we have already discussed this and convergence was to use the conventions which are mentioned in the Data-book. So, I updated the supply names accordingly. Please see the below communications for the same. https://lore.kernel.org/linux-phy/83dc9435-5850-425d-b345-52e84ef9262c@kernel.org/ https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef@kernel.org/ > Best regards, > Krzysztof Thank you, Regards, Pritam
On 18/09/2025 20:55, Pritam Manohar Sutar wrote: > > Yes, we have already discussed this and convergence was to use the > conventions which are mentioned in the Data-book. So, I updated the > supply names accordingly. > > Please see the below communications for the same. > > https://lore.kernel.org/linux-phy/83dc9435-5850-425d-b345-52e84ef9262c@kernel.org/ > https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef@kernel.org/ Ah, ok, although next time I might ask the same, since commit msg does not explain that. I still cannot find constraints for the rest of properties, though. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 19 September 2025 05:59 AM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org; > kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 18/09/2025 20:55, Pritam Manohar Sutar wrote: > > > > Yes, we have already discussed this and convergence was to use the > > conventions which are mentioned in the Data-book. So, I updated the > > supply names accordingly. > > > > Please see the below communications for the same. > > > > https://lore.kernel.org/linux-phy/83dc9435-5850-425d-b345-52e84ef9262c > > @kernel.org/ > > https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef > > @kernel.org/ > Ah, ok, although next time I might ask the same, since commit msg does not > explain that. Ok, will update commit message. Please confirm the commit message if I updated it as below. "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible Document support for the USB20 phy found on the ExynosAutov920 SoC. The USB20 phy is functionally identical to that on the Exynos850 SoC, so no driver changes are needed to support this phy. However, add a dedicated compatible string for USB20 phy found in this SoC. This phy needs 0.75v, 0.18v and 3.3v supplies for its internal functionally. Power Supply's names are as per phy's User Data-Book. These names, (dvdd, vdd18 and vdd33), are considered for 0.75v, 1.8v and 3.3v respectively. " > > I still cannot find constraints for the rest of properties, though. Sorry I didn't get it completely. Can you please elaborate on the same? Let me know if you want me to update the commit message and send v9? And retain your RB on patch1 and patch3? > Best regards, > Krzysztof Thank you. Regards, Pritam
On 22/09/2025 14:26, Pritam Manohar Sutar wrote: > This phy needs 0.75v, 0.18v and 3.3v supplies for its internal > functionally. Power Supply's names are as per phy's User Data-Book. > These names, (dvdd, vdd18 and vdd33), are considered for 0.75v, 1.8v > and 3.3v respectively. > " > >> >> I still cannot find constraints for the rest of properties, though. > > Sorry I didn't get it completely. Can you please elaborate on the same? Writing bindings and introductory talks elaborate on that. You add properties without constraints. That's not what we want. We want constraints. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 07 October 2025 11:54 AM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org; > kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 22/09/2025 14:26, Pritam Manohar Sutar wrote: > > This phy needs 0.75v, 0.18v and 3.3v supplies for its internal > > functionally. Power Supply's names are as per phy's User Data-Book. > > These names, (dvdd, vdd18 and vdd33), are considered for 0.75v, 1.8v > > and 3.3v respectively. > > " > > > >> > >> I still cannot find constraints for the rest of properties, though. > > > > Sorry I didn't get it completely. Can you please elaborate on the same? > > > Writing bindings and introductory talks elaborate on that. You add properties > without constraints. That's not what we want. We want constraints. > Have added only supplies in this patch-set. However, was going through schema example and it says nothing is needed to define in terms of supply. ref: 1. Documentation/devicetree/bindings/writing-schema.rst +151 ... A "description" property is always required. 2. Documentation/devicetree/bindings/example-schema.yaml +135 # *-supply is always a single phandle, so nothing more to define. foo-supply: true Please confirm and let me know if your expectations are something else in terms of constraints of the properties. > > Best regards, > Krzysztof Thank you, Regards, Pritam
On 08/10/2025 13:45, Pritam Manohar Sutar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 07 October 2025 11:54 AM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org; >> kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; >> conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; >> peter.griffin@linaro.org; kauschluss@disroot.org; >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; >> m.szyprowski@samsung.com; s.nawrocki@samsung.com >> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 HS phy compatible >> >> On 22/09/2025 14:26, Pritam Manohar Sutar wrote: >>> This phy needs 0.75v, 0.18v and 3.3v supplies for its internal >>> functionally. Power Supply's names are as per phy's User Data-Book. >>> These names, (dvdd, vdd18 and vdd33), are considered for 0.75v, 1.8v >>> and 3.3v respectively. >>> " >>> >>>> >>>> I still cannot find constraints for the rest of properties, though. >>> >>> Sorry I didn't get it completely. Can you please elaborate on the same? >> >> >> Writing bindings and introductory talks elaborate on that. You add properties >> without constraints. That's not what we want. We want constraints. >> > > Have added only supplies in this patch-set. However, was going > through schema example and it says nothing is needed to define > in terms of supply. I don't have original patchset in my inbox anymore, so not sure what was there, but most likely you miss constraining the presence of these properties per each variant. IOW, not each of devices in the bindings have these supplies, so I expect syntax similar as in example-schema. https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212 Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 08 October 2025 01:42 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org; > kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 08/10/2025 13:45, Pritam Manohar Sutar wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: 07 October 2025 11:54 AM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; > >> vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >> krzk+dt@kernel.org; > >> conor+dt@kernel.org; alim.akhtar@samsung.com; > >> conor+andre.draszik@linaro.org; > >> peter.griffin@linaro.org; kauschluss@disroot.org; > >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > >> m.szyprowski@samsung.com; s.nawrocki@samsung.com > >> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > >> dev.tailor@samsung.com; faraz.ata@samsung.com; > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 HS phy compatible > >> > >> On 22/09/2025 14:26, Pritam Manohar Sutar wrote: > >>> This phy needs 0.75v, 0.18v and 3.3v supplies for its internal > >>> functionally. Power Supply's names are as per phy's User Data-Book. > >>> These names, (dvdd, vdd18 and vdd33), are considered for 0.75v, > >>> 1.8v and 3.3v respectively. > >>> " > >>> > >>>> > >>>> I still cannot find constraints for the rest of properties, though. > >>> > >>> Sorry I didn't get it completely. Can you please elaborate on the same? > >> > >> > >> Writing bindings and introductory talks elaborate on that. You add > >> properties without constraints. That's not what we want. We want > constraints. > >> > > > > Have added only supplies in this patch-set. However, was going through > > schema example and it says nothing is needed to define in terms of > > supply. > > > I don't have original patchset in my inbox anymore, so not sure what was there, > but most likely you miss constraining the presence of these properties per each > variant. IOW, not each of devices in the bindings have these supplies, so I expect > syntax similar as in example-schema. > > https://protect2.fireeye.com/v1/url?k=b15f03dc-eee70b7e-b15e8893- > 000babff88b5-a120365cc01c0261&q=1&e=61c09dc1-e3de-4b16-b34f- > edc1fae43bb8&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.19%2Fsour > ce%2FDocumentation%2Fdevicetree%2Fbindings%2Fexample- > schema.yaml%23L212 > Yes, this was already considered based on Rob's comment and snippet is as below. https://lore.kernel.org/linux-phy/20250806234217.GA2030512-robh@kernel.org/ + - if: + properties: + compatible: + contains: + enum: + - samsung,exynosautov920-usbdrd-phy + then: + required: + - dvdd-supply + - vdd18-supply + - vdd33-supply + + else: + properties: + dvdd-supply: false + vdd18-supply: false + vdd33-supply: false I understand that you have lost the context, my bad. Let me share v9 with all RB tags added in v7 and v8 and let us have all consolidated review one more time (sorry for this). > > Best regards, > Krzysztof Thank you, Regards, Pritam
On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: > Document support for the USB20 phy found on the ExynosAutov920 SoC. The > USB20 phy is functionally identical to that on the Exynos850 SoC, so no > driver changes are needed to support this phy. However, add a dedicated > compatible string for USB20 phy found in this SoC. > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> You just dropped all tags without explaining why. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 04 September 2025 12:18 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: > > Document support for the USB20 phy found on the ExynosAutov920 SoC. > > The > > USB20 phy is functionally identical to that on the Exynos850 SoC, so > > no driver changes are needed to support this phy. However, add a > > dedicated compatible string for USB20 phy found in this SoC. > > > > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > You just dropped all tags without explaining why. Regretted inconvenience. There were significant changes in supplies' names in driver and schemas (patch-set v8). This led to make changes in patch no 5. And review for these changes is needed. Hence, removed RB tag in this patch-set. There was a ask for the same https://lore.kernel.org/linux-phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%20know%2C%20because%20of%20above%20changes%2C%20should%20be%20removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%201%20and%203. This had to be captured in changelog along with other details. Will remember to add details in future, if any tags are removed. However, do I need to send v9 with the details? > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of > patchset, under or above your Signed-off-by tag, unless patch changed > significantly (e.g. new properties added to the DT bindings). Tag is "received", > when provided in a message replied to you on the mailing list. Tools like b4 can > help here. However, there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for tags received on the version they apply. > > Please read: > https://protect2.fireeye.com/v1/url?k=6abe7ac7-0bc392bf-6abff188- > 74fe485fffb1-49c70cea06738e63&q=1&e=fc43c80a-8c7b-41b0-aa24- > 8cb76d954fe5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12- > rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting- > patches.rst%23L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof Thank you. Regards, Pritam
On 04/09/2025 09:51, Pritam Manohar Sutar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 04 September 2025 12:18 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 HS phy compatible >> >> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: >>> Document support for the USB20 phy found on the ExynosAutov920 SoC. >>> The >>> USB20 phy is functionally identical to that on the Exynos850 SoC, so >>> no driver changes are needed to support this phy. However, add a >>> dedicated compatible string for USB20 phy found in this SoC. >>> >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> >> You just dropped all tags without explaining why. > > Regretted inconvenience. > > There were significant changes in supplies' names in driver and schemas > (patch-set v8). This led to make changes in patch no 5. And review for > these changes is needed. Hence, removed RB tag in this patch-set. > > There was a ask for the same https://lore.kernel.org/linux-phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%20know%2C%20because%20of%20above%20changes%2C%20should%20be%20removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%201%20and%203. > Where in the changelog you explained why you dropped the tags? Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Sent: 04 September 2025 03:52 PM > To: 'Krzysztof Kozlowski' <krzk@kernel.org> > Cc: 'vkoul@kernel.org' <vkoul@kernel.org>; 'kishon@kernel.org' > <kishon@kernel.org>; 'robh@kernel.org' <robh@kernel.org>; > 'krzk+dt@kernel.org' <krzk+dt@kernel.org>; 'conor+dt@kernel.org' > <conor+dt@kernel.org>; 'alim.akhtar@samsung.com' > <alim.akhtar@samsung.com>; 'andre.draszik@linaro.org' > <andre.draszik@linaro.org>; 'peter.griffin@linaro.org' > <peter.griffin@linaro.org>; 'kauschluss@disroot.org' <kauschluss@disroot.org>; > 'ivo.ivanov.ivanov1@gmail.com' <ivo.ivanov.ivanov1@gmail.com>; > 'igor.belwon@mentallysanemainliners.org' > <igor.belwon@mentallysanemainliners.org>; 'm.szyprowski@samsung.com' > <m.szyprowski@samsung.com>; 's.nawrocki@samsung.com' > <s.nawrocki@samsung.com>; 'linux-phy@lists.infradead.org' <linux- > phy@lists.infradead.org>; 'devicetree@vger.kernel.org' > <devicetree@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux- > kernel@vger.kernel.org>; 'linux-arm-kernel@lists.infradead.org' <linux-arm- > kernel@lists.infradead.org>; 'linux-samsung-soc@vger.kernel.org' <linux- > samsung-soc@vger.kernel.org>; 'rosa.pila@samsung.com' > <rosa.pila@samsung.com>; 'dev.tailor@samsung.com' > <dev.tailor@samsung.com>; 'faraz.ata@samsung.com' > <faraz.ata@samsung.com>; 'muhammed.ali@samsung.com' > <muhammed.ali@samsung.com>; 'selvarasu.g@samsung.com' > <selvarasu.g@samsung.com> > Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > Hi Krzysztof, > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: 04 September 2025 03:12 PM > > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > > andre.draszik@linaro.org; peter.griffin@linaro.org; > > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > > igor.belwon@mentallysanemainliners.org; > > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > > dev.tailor@samsung.com; faraz.ata@samsung.com; > > muhammed.ali@samsung.com; selvarasu.g@samsung.com > > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > > add > > ExynosAutov920 HS phy compatible > > > > On 04/09/2025 09:51, Pritam Manohar Sutar wrote: > > > Hi Krzysztof, > > > > > >> -----Original Message----- > > >> From: Krzysztof Kozlowski <krzk@kernel.org> > > >> Sent: 04 September 2025 12:18 PM > > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > > >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > > >> igor.belwon@mentallysanemainliners.org; > > >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > > >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > > >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > >> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > > >> dev.tailor@samsung.com; faraz.ata@samsung.com; > > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > > >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > > >> add > > >> ExynosAutov920 HS phy compatible > > >> > > >> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: > > >>> Document support for the USB20 phy found on the ExynosAutov920 SoC. > > >>> The > > >>> USB20 phy is functionally identical to that on the Exynos850 SoC, > > >>> so no driver changes are needed to support this phy. However, add > > >>> a dedicated compatible string for USB20 phy found in this SoC. > > >>> > > >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > > >> > > >> You just dropped all tags without explaining why. > > > > > > Regretted inconvenience. > > > > > > There were significant changes in supplies' names in driver and > > > schemas (patch-set v8). This led to make changes in patch no 5. And > > > review for these changes is needed. Hence, removed RB tag in this patch- > set. > > > > > > There was a ask for the same https://lore.kernel.org/linux- > > > phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me% > > > 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20 > > > removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch% > > 201%20and%203. > > > > > > > > > Where in the changelog you explained why you dropped the tags? > > Along with supplies' names, there were similar commit messages for patch no 1, > 3 as patch no 5 (v7). (though, they were explaining schema more than h/w). > Changed commit messages of the patch no 1, 3, 5 (v7) as per reference commits > and would like to get them reviewed again, so did not add RB for patch 1 and 3, > which you had given RB (in v7). > > Forgot to add these details for dropping the RB tags in changelog. > Do I need to send v9 by retaining RB for patch 1 and 3? > Gentle Reminder. > > > > Best regards, > > Krzysztof > > > Thank you. > > Regards, > Pritam Thank you, Regards, Pritam
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 04 September 2025 03:12 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 04/09/2025 09:51, Pritam Manohar Sutar wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: 04 September 2025 12:18 PM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > >> igor.belwon@mentallysanemainliners.org; > >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > >> dev.tailor@samsung.com; faraz.ata@samsung.com; > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 HS phy compatible > >> > >> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: > >>> Document support for the USB20 phy found on the ExynosAutov920 SoC. > >>> The > >>> USB20 phy is functionally identical to that on the Exynos850 SoC, so > >>> no driver changes are needed to support this phy. However, add a > >>> dedicated compatible string for USB20 phy found in this SoC. > >>> > >>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> > >> You just dropped all tags without explaining why. > > > > Regretted inconvenience. > > > > There were significant changes in supplies' names in driver and > > schemas (patch-set v8). This led to make changes in patch no 5. And > > review for these changes is needed. Hence, removed RB tag in this patch-set. > > > > There was a ask for the same https://lore.kernel.org/linux- > phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me% > 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20 > removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch% > 201%20and%203. > > > > > Where in the changelog you explained why you dropped the tags? Along with supplies' names, there were similar commit messages for patch no 1, 3 as patch no 5 (v7). (though, they were explaining schema more than h/w). Changed commit messages of the patch no 1, 3, 5 (v7) as per reference commits and would like to get them reviewed again, so did not add RB for patch 1 and 3, which you had given RB (in v7). Forgot to add these details for dropping the RB tags in changelog. Do I need to send v9 by retaining RB for patch 1 and 3? > > Best regards, > Krzysztof Thank you. Regards, Pritam
On 04/09/2025 19:21, Pritam Manohar Sutar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 04 September 2025 03:12 PM >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; >> faraz.ata@samsung.com; muhammed.ali@samsung.com; >> selvarasu.g@samsung.com >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add >> ExynosAutov920 HS phy compatible >> >> On 04/09/2025 09:51, Pritam Manohar Sutar wrote: >>> Hi Krzysztof, >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzk@kernel.org> >>>> Sent: 04 September 2025 12:18 PM >>>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> >>>> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; >>>> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; >>>> andre.draszik@linaro.org; peter.griffin@linaro.org; >>>> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; >>>> igor.belwon@mentallysanemainliners.org; >>>> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- >>>> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >>>> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; >>>> dev.tailor@samsung.com; faraz.ata@samsung.com; >>>> muhammed.ali@samsung.com; selvarasu.g@samsung.com >>>> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: >>>> add >>>> ExynosAutov920 HS phy compatible >>>> >>>> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: >>>>> Document support for the USB20 phy found on the ExynosAutov920 SoC. >>>>> The >>>>> USB20 phy is functionally identical to that on the Exynos850 SoC, so >>>>> no driver changes are needed to support this phy. However, add a >>>>> dedicated compatible string for USB20 phy found in this SoC. >>>>> >>>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> >>>> >>>> You just dropped all tags without explaining why. >>> >>> Regretted inconvenience. >>> >>> There were significant changes in supplies' names in driver and >>> schemas (patch-set v8). This led to make changes in patch no 5. And >>> review for these changes is needed. Hence, removed RB tag in this patch-set. >>> >>> There was a ask for the same https://lore.kernel.org/linux- >> phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me% >> 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20 >> removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch% >> 201%20and%203. >>> >> >> >> Where in the changelog you explained why you dropped the tags? > > Along with supplies' names, there were similar commit messages > for patch no 1, 3 as patch no 5 (v7). (though, they were explaining > schema more than h/w). Changed commit messages of the > patch no 1, 3, 5 (v7) as per reference commits and would like > to get them reviewed again, so did not add RB for patch 1 and 3, > which you had given RB (in v7). I do not have time to review the same second time and I find such request quite a waste of my time. It's v8 so I am surprised to see it getting changed even after review. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 18 September 2025 08:13 AM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 04/09/2025 19:21, Pritam Manohar Sutar wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: 04 September 2025 03:12 PM > >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > >> andre.draszik@linaro.org; peter.griffin@linaro.org; > >> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > >> igor.belwon@mentallysanemainliners.org; > >> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > >> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > >> dev.tailor@samsung.com; faraz.ata@samsung.com; > >> muhammed.ali@samsung.com; selvarasu.g@samsung.com > >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 HS phy compatible > >> > >> On 04/09/2025 09:51, Pritam Manohar Sutar wrote: > >>> Hi Krzysztof, > >>> > >>>> -----Original Message----- > >>>> From: Krzysztof Kozlowski <krzk@kernel.org> > >>>> Sent: 04 September 2025 12:18 PM > >>>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >>>> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > >>>> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > >>>> andre.draszik@linaro.org; peter.griffin@linaro.org; > >>>> kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > >>>> igor.belwon@mentallysanemainliners.org; > >>>> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > >>>> phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >>>> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com; > >>>> dev.tailor@samsung.com; faraz.ata@samsung.com; > >>>> muhammed.ali@samsung.com; selvarasu.g@samsung.com > >>>> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: > >>>> add > >>>> ExynosAutov920 HS phy compatible > >>>> > >>>> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote: > >>>>> Document support for the USB20 phy found on the ExynosAutov920 SoC. > >>>>> The > >>>>> USB20 phy is functionally identical to that on the Exynos850 SoC, > >>>>> so no driver changes are needed to support this phy. However, add > >>>>> a dedicated compatible string for USB20 phy found in this SoC. > >>>>> > >>>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> > >>>> > >>>> You just dropped all tags without explaining why. > >>> > >>> Regretted inconvenience. > >>> > >>> There were significant changes in supplies' names in driver and > >>> schemas (patch-set v8). This led to make changes in patch no 5. And > >>> review for these changes is needed. Hence, removed RB tag in this patch- > set. > >>> > >>> There was a ask for the same https://lore.kernel.org/linux- > >> > phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me% > >> > 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20 > >> > removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch% > >> 201%20and%203. > >>> > >> > >> > >> Where in the changelog you explained why you dropped the tags? > > > > Along with supplies' names, there were similar commit messages for > > patch no 1, 3 as patch no 5 (v7). (though, they were explaining schema > > more than h/w). Changed commit messages of the patch no 1, 3, 5 (v7) > > as per reference commits and would like to get them reviewed again, so > > did not add RB for patch 1 and 3, which you had given RB (in v7). > > I do not have time to review the same second time and I find such request quite > a waste of my time. It's v8 so I am surprised to see it getting changed even after > review. > OK, those were only commit message changes, so I am going to retain your RB tags for patch 1 and 3. Sorry about noise. However, do you want me to send v9 by retaining RB tags in respective patches? > > Best regards, > Krzysztof Thank you, Regards, Pritam
© 2016 - 2026 Red Hat, Inc.