From: Aaron Kling <webgeek1234@gmail.com>
Each memory client has unique hardware ID, add these IDs.
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644
--- a/include/dt-bindings/memory/tegra210-mc.h
+++ b/include/dt-bindings/memory/tegra210-mc.h
@@ -75,4 +75,62 @@
#define TEGRA210_MC_RESET_ETR 28
#define TEGRA210_MC_RESET_TSECB 29
+#define TEGRA210_MC_PTCR 0
+#define TEGRA210_MC_DISPLAY0A 1
+#define TEGRA210_MC_DISPLAY0AB 2
+#define TEGRA210_MC_DISPLAY0B 3
+#define TEGRA210_MC_DISPLAY0BB 4
+#define TEGRA210_MC_DISPLAY0C 5
+#define TEGRA210_MC_DISPLAY0CB 6
+#define TEGRA210_MC_AFIR 14
+#define TEGRA210_MC_AVPCARM7R 15
+#define TEGRA210_MC_DISPLAYHC 16
+#define TEGRA210_MC_DISPLAYHCB 17
+#define TEGRA210_MC_HDAR 21
+#define TEGRA210_MC_HOST1XDMAR 22
+#define TEGRA210_MC_HOST1XR 23
+#define TEGRA210_MC_NVENCSRD 28
+#define TEGRA210_MC_PPCSAHBDMAR 29
+#define TEGRA210_MC_PPCSAHBSLVR 30
+#define TEGRA210_MC_SATAR 31
+#define TEGRA210_MC_MPCORER 39
+#define TEGRA210_MC_NVENCSWR 43
+#define TEGRA210_MC_AFIW 49
+#define TEGRA210_MC_AVPCARM7W 50
+#define TEGRA210_MC_HDAW 53
+#define TEGRA210_MC_HOST1XW 54
+#define TEGRA210_MC_MPCOREW 57
+#define TEGRA210_MC_PPCSAHBDMAW 59
+#define TEGRA210_MC_PPCSAHBSLVW 60
+#define TEGRA210_MC_SATAW 61
+#define TEGRA210_MC_ISPRA 68
+#define TEGRA210_MC_ISPWA 70
+#define TEGRA210_MC_ISPWB 71
+#define TEGRA210_MC_XUSB_HOSTR 74
+#define TEGRA210_MC_XUSB_HOSTW 75
+#define TEGRA210_MC_XUSB_DEVR 76
+#define TEGRA210_MC_XUSB_DEVW 77
+#define TEGRA210_MC_ISPRAB 78
+#define TEGRA210_MC_ISPWAB 80
+#define TEGRA210_MC_ISPWBB 81
+#define TEGRA210_MC_TSECSRD 84
+#define TEGRA210_MC_TSECSWR 85
+#define TEGRA210_MC_A9AVPSCR 86
+#define TEGRA210_MC_A9AVPSCW 87
+#define TEGRA210_MC_GPUSRD 88
+#define TEGRA210_MC_GPUSWR 89
+#define TEGRA210_MC_DISPLAYT 90
+#define TEGRA210_MC_SDMMCRA 96
+#define TEGRA210_MC_SDMMCRAA 97
+#define TEGRA210_MC_SDMMCR 98
+#define TEGRA210_MC_SDMMCRAB 99
+#define TEGRA210_MC_SDMMCWA 100
+#define TEGRA210_MC_SDMMCWAA 101
+#define TEGRA210_MC_SDMMCW 102
+#define TEGRA210_MC_SDMMCWAB 103
+#define TEGRA210_MC_VICSRD 108
+#define TEGRA210_MC_VICSWR 109
+#define TEGRA210_MC_VIW 114
+#define TEGRA210_MC_DISPLAYD 115
+
#endif
--
2.50.1On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote: > Each memory client has unique hardware ID, add these IDs. > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > --- > include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644 > --- a/include/dt-bindings/memory/tegra210-mc.h > +++ b/include/dt-bindings/memory/tegra210-mc.h > @@ -75,4 +75,62 @@ > #define TEGRA210_MC_RESET_ETR 28 > #define TEGRA210_MC_RESET_TSECB 29 > > +#define TEGRA210_MC_PTCR 0 There is no driver user of this ABI, so does not look like a binding. You have entire commit msg to clarify such unusual things, like lack of users. Please use it. Best regards, Krzysztof
On Thu, Sep 4, 2025 at 3:20 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote: > > Each memory client has unique hardware ID, add these IDs. > > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > > --- > > include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > > > diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > > index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644 > > --- a/include/dt-bindings/memory/tegra210-mc.h > > +++ b/include/dt-bindings/memory/tegra210-mc.h > > @@ -75,4 +75,62 @@ > > #define TEGRA210_MC_RESET_ETR 28 > > #define TEGRA210_MC_RESET_TSECB 29 > > > > +#define TEGRA210_MC_PTCR 0 > > There is no driver user of this ABI, so does not look like a binding. > > You have entire commit msg to clarify such unusual things, like lack of > users. Please use it. The tegra210-mc driver has these hardcoded and should probably be updated to use the bindings instead, but I think that's outside of the scope of this series. I will clarify such in the updated message. Aaron
On 04/09/2025 19:33, Aaron Kling wrote: > On Thu, Sep 4, 2025 at 3:20 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote: >>> Each memory client has unique hardware ID, add these IDs. >>> >>> Signed-off-by: Aaron Kling <webgeek1234@gmail.com> >>> --- >>> include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 58 insertions(+) >>> >>> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h >>> index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644 >>> --- a/include/dt-bindings/memory/tegra210-mc.h >>> +++ b/include/dt-bindings/memory/tegra210-mc.h >>> @@ -75,4 +75,62 @@ >>> #define TEGRA210_MC_RESET_ETR 28 >>> #define TEGRA210_MC_RESET_TSECB 29 >>> >>> +#define TEGRA210_MC_PTCR 0 >> >> There is no driver user of this ABI, so does not look like a binding. >> >> You have entire commit msg to clarify such unusual things, like lack of >> users. Please use it. > > The tegra210-mc driver has these hardcoded and should probably be > updated to use the bindings instead, but I think that's outside of the > scope of this series. I will clarify such in the updated message. If you introduce the binding, change the drivers to use it. Otherwise there is no point benefit in this binding, really. > > Aaron Best regards, Krzysztof
On Fri, Sep 5, 2025 at 1:56 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/09/2025 19:33, Aaron Kling wrote: > > On Thu, Sep 4, 2025 at 3:20 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote: > >>> Each memory client has unique hardware ID, add these IDs. > >>> > >>> Signed-off-by: Aaron Kling <webgeek1234@gmail.com> > >>> --- > >>> include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++ > >>> 1 file changed, 58 insertions(+) > >>> > >>> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h > >>> index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644 > >>> --- a/include/dt-bindings/memory/tegra210-mc.h > >>> +++ b/include/dt-bindings/memory/tegra210-mc.h > >>> @@ -75,4 +75,62 @@ > >>> #define TEGRA210_MC_RESET_ETR 28 > >>> #define TEGRA210_MC_RESET_TSECB 29 > >>> > >>> +#define TEGRA210_MC_PTCR 0 > >> > >> There is no driver user of this ABI, so does not look like a binding. > >> > >> You have entire commit msg to clarify such unusual things, like lack of > >> users. Please use it. > > > > The tegra210-mc driver has these hardcoded and should probably be > > updated to use the bindings instead, but I think that's outside of the > > scope of this series. I will clarify such in the updated message. > > If you introduce the binding, change the drivers to use it. Otherwise > there is no point benefit in this binding, really. Ack. I was adding the bindings to avoid magic numbers in the dt commits at the end of this series. But I can update the mc driver as well. Aaron
© 2016 - 2025 Red Hat, Inc.