[PATCH v5 0/3] Add SDM660 LPASS LPI TLMM

Nickolay Goppen posted 3 patches 4 weeks, 1 day ago
There is a newer version of this series
.../pinctrl/qcom,sdm660-lpass-lpi-pinctrl.yaml     | 109 ++++++++++++++
drivers/pinctrl/qcom/Kconfig                       |  10 ++
drivers/pinctrl/qcom/Makefile                      |   1 +
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c           |  18 ++-
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h           |  18 +++
drivers/pinctrl/qcom/pinctrl-sdm660-lpass-lpi.c    | 161 +++++++++++++++++++++
6 files changed, 315 insertions(+), 2 deletions(-)
[PATCH v5 0/3] Add SDM660 LPASS LPI TLMM
Posted by Nickolay Goppen 4 weeks, 1 day ago
This patch series adds SDM660 LPASS LPI TLMM pinctrl driver and
introduces pin_offset field for LPI pinctrl drivers to support
SDM660's quirky pin_offsets taken from an array with 
predefined offsets from downstream [1].

[1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107

Signed-off-by: Nickolay Goppen <setotau@yandex.ru>
---
Changes in v5:
- As suggested by Konrad Dybcio Renamed pdm_2_gpios to pdm_tx, dmic12 and dmic34 to dmic1_[clk, data] and dmic2_[clk, data].
- As suggested by Krzysztof Kozlowski Added pinmux nodes to dt-binding example.
- Link to v4: https://lore.kernel.org/r/20250828-sdm660-lpass-lpi-v4-0-af4afdd52965@yandex.ru

Changes in v4:
- Replaced pin_offset callback with a pin_offset field in lpi_pingroup struct.
- Introduced LPI_PINGROUP_OFFSET macro with additional pin_offset field handling.
- Introduced LPI_FLAG_USE_PREDEFINED_PIN_OFFSET flag for indicating use of predefined pin_offsets.
- Replaced an array with offsets in SDM660 LPASS LPI TLMM driver with pin_offset defined for each pin in the new pin_offset field.
- Link to v3: https://lore.kernel.org/r/20250825-sdm660-lpass-lpi-v3-0-65d4a4db298e@yandex.ru

Changes in v3:
- Fixed compilation of LPI drivers as modules by changing pin_offset function determination logic.
- Link to v2: https://lore.kernel.org/r/20250825-sdm660-lpass-lpi-v2-0-af7739f5c27e@yandex.ru

Changes in v2:
- Extended description of "pinctrl: qcom: Add SDM660 LPASS LPI TLMM" patch.
- Resent using b4 relay
- Link to v1: https://lore.kernel.org/r/20250824-sdm660-lpass-lpi-v1-0-003d5cc28234@yandex.ru

---
Nickolay Goppen (2):
      pinctrl: qcom: lpass-lpi: Add ability to use custom pin offsets
      dt-bindings: pinctrl: qcom: Add SDM660 LPI pinctrl

Richard Acayan (1):
      pinctrl: qcom: Add SDM660 LPASS LPI TLMM

 .../pinctrl/qcom,sdm660-lpass-lpi-pinctrl.yaml     | 109 ++++++++++++++
 drivers/pinctrl/qcom/Kconfig                       |  10 ++
 drivers/pinctrl/qcom/Makefile                      |   1 +
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c           |  18 ++-
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h           |  18 +++
 drivers/pinctrl/qcom/pinctrl-sdm660-lpass-lpi.c    | 161 +++++++++++++++++++++
 6 files changed, 315 insertions(+), 2 deletions(-)
---
base-commit: ef67c54a170cee962b09c638514d55790b68bdf5
change-id: 20250824-sdm660-lpass-lpi-a8b02a23861a

Best regards,
-- 
Nickolay Goppen <setotau@mainlining.org>
Re: [PATCH v5 0/3] Add SDM660 LPASS LPI TLMM
Posted by Linus Walleij 3 weeks, 3 days ago
On Wed, Sep 3, 2025 at 3:43 PM Nickolay Goppen <setotau@mainlining.org> wrote:

> This patch series adds SDM660 LPASS LPI TLMM pinctrl driver and
> introduces pin_offset field for LPI pinctrl drivers to support
> SDM660's quirky pin_offsets taken from an array with
> predefined offsets from downstream [1].
>
> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107
>
> Signed-off-by: Nickolay Goppen <setotau@yandex.ru>

This seems ready for merge if you fix the last few comments
and collect the ACKs/Reviewed-by, can you send a v6
addressing this?

Yours,
Linus Walleij
Re: [PATCH v5 0/3] Add SDM660 LPASS LPI TLMM
Posted by Nickolay Goppen 3 weeks, 3 days ago
08.09.2025 15:18, Linus Walleij пишет:
> On Wed, Sep 3, 2025 at 3:43 PM Nickolay Goppen <setotau@mainlining.org> wrote:
>
>> This patch series adds SDM660 LPASS LPI TLMM pinctrl driver and
>> introduces pin_offset field for LPI pinctrl drivers to support
>> SDM660's quirky pin_offsets taken from an array with
>> predefined offsets from downstream [1].
>>
>> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107
>>
>> Signed-off-by: Nickolay Goppen <setotau@yandex.ru>
> This seems ready for merge if you fix the last few comments
> and collect the ACKs/Reviewed-by, can you send a v6
> addressing this?

Yes, of course. Just a moment.

> Yours,
> Linus Walleij

-- 
Best regards,
Nickolay